[perl-WWW-Splunk] Attempt at saner SPEC file formatting
Lubomir Rintel
lkundrak at fedoraproject.org
Thu Oct 24 09:54:02 UTC 2013
commit f3f939e5e6ee76e7663c8f15423502056dc186cd
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Thu Oct 24 11:39:54 2013 +0200
Attempt at saner SPEC file formatting
I'm doing this semi-automatically across all packages I maintain, since some
are several years old and since then several have suffered bit-rot and such.
I'm fixing up the following:
- Old RPM relics (such as %defattr, BuildRoot or %clean sections)
- Whitespace errors (such as trailing spaces)
- Consistent use of %{buildroot}
- Dropping useless %{name} expansions that harm legibility
- Consistent spacing between RPM sections
- Bad days in %changelogs
perl-WWW-Splunk.spec | 23 +++++++++--------------
1 files changed, 9 insertions(+), 14 deletions(-)
---
diff --git a/perl-WWW-Splunk.spec b/perl-WWW-Splunk.spec
index 89cf275..06ebff2 100644
--- a/perl-WWW-Splunk.spec
+++ b/perl-WWW-Splunk.spec
@@ -1,12 +1,11 @@
Name: perl-WWW-Splunk
Version: 2.05
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Client for Splunk log search engine
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/WWW-Splunk/
Source0: http://www.cpan.org/authors/id/L/LK/LKUNDRAK/WWW-Splunk-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: perl(Date::Manip)
BuildRequires: perl(HTTP::Request::Common)
@@ -18,8 +17,8 @@ BuildRequires: perl(XML::LibXML)
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
%description
-WWW::Splunk is a client for Splunk log search engine. It consists of a utility
-with command-line interface, sc, and a supporting library. It lets you query
+WWW::Splunk is a client for Splunk log search engine. It consists of a utility
+with command-line interface, sc, and a supporting library. It lets you query
the archived logs or conduct a real-time search.
@@ -33,24 +32,17 @@ the archived logs or conduct a real-time search.
%install
-rm -rf $RPM_BUILD_ROOT
+./Build install destdir=%{buildroot} create_packlist=0
+find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+%{_fixperms} %{buildroot}/*
%check
./Build test
-%clean
-rm -rf $RPM_BUILD_ROOT
-
-
%files
-%defattr(-,root,root,-)
%doc ChangeLog
%{perl_vendorlib}/*
%{_mandir}/man3/*
@@ -59,6 +51,9 @@ rm -rf $RPM_BUILD_ROOT
%changelog
+* Thu Oct 24 2013 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> - 2.05-2
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
* Mon Sep 23 2013 Lubomir Rintel (GoodData) <lubo.rintel at gooddata.com> 2.05-1
- Rebase to address a POD issue (Ralf Corsepius, #999052)
More information about the scm-commits
mailing list