[plexus-graph] Attempt at saner SPEC file formatting
Lubomir Rintel
lkundrak at fedoraproject.org
Thu Oct 24 09:54:18 UTC 2013
commit dc81c0b64d0dabf4ee77e9fad542e7719f318d18
Author: Lubomir Rintel <lkundrak at v3.sk>
Date: Thu Oct 24 11:39:54 2013 +0200
Attempt at saner SPEC file formatting
I'm doing this semi-automatically across all packages I maintain, since some
are several years old and since then several have suffered bit-rot and such.
I'm fixing up the following:
- Old RPM relics (such as %defattr, BuildRoot or %clean sections)
- Whitespace errors (such as trailing spaces)
- Consistent use of %{buildroot}
- Dropping useless %{name} expansions that harm legibility
- Consistent spacing between RPM sections
- Bad days in %changelogs
plexus-graph.spec | 25 ++++++++++---------------
1 files changed, 10 insertions(+), 15 deletions(-)
---
diff --git a/plexus-graph.spec b/plexus-graph.spec
index 6006483..37aa449 100644
--- a/plexus-graph.spec
+++ b/plexus-graph.spec
@@ -2,14 +2,13 @@
Name: plexus-graph
Version: 0.13.1
-Release: 9%{?dist}
+Release: 10%{?dist}
Summary: Graph data structures manipulation library
Group: Development/Libraries
License: CPL
URL: http://plexus.sourceforge.net/
Source0: http://download.sourceforge.net/plexus/plexus-src-%{version}.tgz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Requires: log4j apache-commons-collections java jpackage-utils
BuildRequires: %{requires} ant java-devel
@@ -19,7 +18,7 @@ BuildArch: noarch
%description
Plexus is a Java library with specifications and implementations for
generic graph data structures. Like the Java Collections Framework,
-vertices and edges are containers for arbitrary user-defined objects.
+vertices and edges are containers for arbitrary user-defined objects.
%package javadoc
@@ -41,33 +40,29 @@ CLASSPATH=$(build-classpath commons-collections log4j) ant dist javadoc
%install
-rm -rf $RPM_BUILD_ROOT
-
# Directory structure
-install -d $RPM_BUILD_ROOT%{_javadir}
-install -d $RPM_BUILD_ROOT%{_javadocdir}/%{name}
+install -d %{buildroot}%{_javadir}
+install -d %{buildroot}%{_javadocdir}/%{name}
# JARs and JavaDoc
-install -m 644 build/dist/plexus-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}-%{version}.jar
-ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
-cp -rp doc/javadoc/. $RPM_BUILD_ROOT%{_javadocdir}/%{name}
-
-%clean
-rm -rf $RPM_BUILD_ROOT
+install -m 644 build/dist/plexus-%{version}.jar %{buildroot}%{_javadir}/%{name}-%{version}.jar
+ln -s %{name}-%{version}.jar %{buildroot}%{_javadir}/%{name}.jar
+cp -rp doc/javadoc/. %{buildroot}%{_javadocdir}/%{name}
%files
-%defattr(-,root,root,-)
%{_javadir}/*
%doc CHANGELOG LICENSE README
%files javadoc
-%defattr(-,root,root,-)
%{_javadocdir}/%{name}
%changelog
+* Thu Oct 24 2013 Lubomir Rintel <lkundrak at v3.sk> - 0.13.1-10
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
* Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.13.1-9
- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
More information about the scm-commits
mailing list