[fedora-virt] Revert Snapshots - VM Definition won't revert

[Eric Blake]

On 03/26/2014 09:24 AM, Cole Robinson wrote:
> On 03/26/2014 09:52 AM, Jorge Fábregas wrote:
>> On 03/26/2014 09:29 AM, Jorge Fábregas wrote:
>>> Those UI changes you made in the details dialog will still remain (which is
>>> counter-intuitive).
>>
>> I forgot to mention that, reverting to a snapshot & restoring its
>> disk-sate, memory-state & *settings* as well, is the norm with the other
>> tools around:  VMware vSphere/Workstation and VirtualBox as well.
>>
>> It would be great if virt-manager behaved like that as I think that's
>> what the user expects.  In the end, it's a snapshot of the whole virtual
>> machine (not just a snapshot of the virtual machine's disk & memory).
>>
> 
> As mentioned in the other mail, libvirt should be doing that when the VM
> starts as shutoff.
> 
> I guess we could support it for a running VM as well, but we'd need to fully
> stop the VM first and restart a new qemu process. That's not how libvirt does
> it currently, so it's restricted to only switching between snapshots with
> idential hw config.

Libvirt already tracks the config at the time of the snapshot.  Revert
is _supposed_ to refuse to happen _unless_ the config is API compatible
or if you pass a force flag; you may be tripping up on bugs in libvirt
where intention is not matching reality.  Or is virt-manager using the
force flag?


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://lists.fedoraproject.org/pipermail/virt/attachments/20140326/723f543e/attachment.sig>