[389-commits] [389-ds-base] 01/01: Issue 49188 - retrocl can crash server at shutdown

[git repository hosting]

This is an automated email from the git hooks/post-receive script.

mreynolds pushed a commit to branch master
in repository 389-ds-base.

commit b2f76abe10bfbe621308410a1e7f41287cf2ff9e
Author: Mark Reynolds <mreynolds(a)redhat.com&gt;
Date:   Wed Mar 22 10:18:13 2017 -0400

    Issue 49188 - retrocl can crash server at shutdown
    
    Description:  We do not calloc enough elements when processing nsslapd-attribute
                  from the retrocl plugin configuration.  This causes invalid memory
                  to be freed at shutdown(via slapi_ch_array_free).
    
    https://pagure.io/389-ds-base/issue/49188
    
    Reviewed by: mreynolds(one line commit rule)
---
 ldap/servers/plugins/retrocl/retrocl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ldap/servers/plugins/retrocl/retrocl.c
b/ldap/servers/plugins/retrocl/retrocl.c
index 32b30c7..6e68667 100644
--- a/ldap/servers/plugins/retrocl/retrocl.c
+++ b/ldap/servers/plugins/retrocl/retrocl.c
@@ -470,8 +470,8 @@ static int retrocl_start (Slapi_PBlock *pb)
 
         retrocl_nattributes = n;
 
-        retrocl_attributes = (char **)slapi_ch_calloc(n, sizeof(char *));
-        retrocl_aliases = (char **)slapi_ch_calloc(n, sizeof(char *));
+        retrocl_attributes = (char **)slapi_ch_calloc(n + 1, sizeof(char *));
+        retrocl_aliases = (char **)slapi_ch_calloc(n + 1, sizeof(char *));
 
         slapi_log_err(SLAPI_LOG_PLUGIN, RETROCL_PLUGIN_NAME, "retrocl_start -
Attributes:\n");
 

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.