June 2009 - cobbler-devel - Fedora Mailing-Lists

by Pete Wright

Hi, Attached is a patch that will allow cobbler to run on a Ubuntu system. It parses /etc/lsb-release to get the distribution name and version needed in utils.py os_release() def. I also have updated the debian/control file that is used to build the cobbler .deb. It will now pickup some missing dependencies. -pete -- Pete Wright Systems Engineer Demonware pete(a)demonware.net office: 310.255.2000 ext 3704 mobile: 604.802.5059 >From 68c527a25f2887558dcd65bef9da097142c2774d Mon Sep 17 00:00:00 2001 From: Pete Wright <pete(a)clyde.demonware.net> Date: Tue, 30 Jun 2009 21:24:15 +0100 Subject: [PATCH] updating utils.py os_release() so that ubuntu and other debian based distributions are detected correctly. updated control file so that newer dependencies get picked up. --- cobbler/utils.py | 18 ++++++++++++------ debian/changelog | 5 +++++ debian/control | 4 ++-- 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/cobbler/utils.py b/cobbler/utils.py index 5639045..7e8786f 100644 --- a/cobbler/utils.py +++ b/cobbler/utils.py @@ -781,7 +781,7 @@ def check_dist(): """ Determines what distro we're running under. """ - if os.path.exists("/etc/debian_version"): + if os.path.exists("/etc/lsb-release"): return "debian" elif os.path.exists("/etc/SuSE-release"): return "suse" @@ -818,11 +818,17 @@ def os_release(): version = float(version[0]) return (make, float(version), rest) elif check_dist() == "debian": - fd = open("/etc/debian_version") - parts = fd.read().split(".") - version = parts[0] - rest = parts[1] - make = "debian" + fd = open("/etc/lsb-release") + lines=fd.readlines() + for line in lines: + if "DISTRIB_ID" in line: + dparts = line.split("=") + make = dparts[1] + if "DISTRIB_RELEASE" in line: + vparts = line.split("=") + version = vparts[1] +# just returning nil for now + rest = 0 return (make, float(version), rest) elif check_dist() == "suse": fd = open("/etc/SuSE-release") diff --git a/debian/changelog b/debian/changelog index 7e4a7a1..0a3d198 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,8 @@ +cobbler (1.7.0-1) unstable; urgency=low + + * Release bump + + -- Pete Wright <pete(a)demownare.net> Thu, 25 Jun 2009 23:14:59 +0000 cobbler (1.5.0-1) unstable; urgency=low * Release bump diff --git a/debian/control b/debian/control index 8e8b039..648be4a 100644 --- a/debian/control +++ b/debian/control @@ -1,14 +1,14 @@ Source: cobbler Section: unknown Priority: optional -Maintainer: Jasper Poppe <jpoppe(a)ebay.com> +Maintainer: Pete Wright <pete(a)demonware.net> Build-Depends: debhelper (>= 7), python-cheetah, python-yaml, git-core, python Standards-Version: 3.8.0 Homepage: https://fedoraproject.org/cobbler Package: cobbler Architecture: all -Depends: ${python:Depends}, python, apache2, libapache2-mod-python, python-support, python-yaml, python-netaddr, python-cheetah, syslinux | syslinux-common +Depends: ${python:Depends}, python, apache2, libapache2-mod-python, python-support, python-yaml, python-netaddr, python-cheetah, python-urlgrabber, syslinux | syslinux-common Suggests: rsync, tftpd-hpa, mkisofs, tftpd-hpa, dhcp3-server, createrepo Description: Install server Cobbler is a network install server. Cobbler -- 1.5.4.3

14 years, 10 months

4
4
0 / 0

Second Ubuntu Patch, allows "cobbler check"

by Pete Wright

attached is a second patch i've written for cobbler that'll allow one to run "cobbler check". looks like it was a type in action_check.py, did not dig to deep on this one, but it works now. -pete -- Pete Wright Systems Engineer Demonware pete(a)demonware.net office: 310.255.2000 ext 3704 mobile: 604.802.5059 >From 8243776ffb636e38ca3b77efe3bc592c15c60ca4 Mon Sep 17 00:00:00 2001 From: Pete Wright <pete(a)clyde.demonware.net> Date: Tue, 30 Jun 2009 22:46:45 +0100 Subject: [PATCH] Typo for debian in check_service() --- cobbler/action_check.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/cobbler/action_check.py b/cobbler/action_check.py index 6d7145f..0c0581b 100644 --- a/cobbler/action_check.py +++ b/cobbler/action_check.py @@ -108,7 +108,7 @@ class BootCheck: if os.path.exists("/etc/init.d/%s" % which): rc = sub_process.call("/etc/init.d/%s status /dev/null 2>/dev/null" % which, shell=True, close_fds=True) if rc != 0: - status.append(_("service %s is not running%s") % which,notes) + status.append(_("service %s is not running%s") % (which,notes)) return False else: status.append(_("Unknown distribution type, cannot check for running service %s" % which)) -- 1.5.4.3

14 years, 10 months

1
0
0 / 0

Cobbler/Koan Debian/Ubuntu packages

by Brummelen, M. van (ICT)

Hi, I am interested in building Cobbler and Koan packages for Debian and Ubuntu. Perhaps some one is already working on this? If so who is? :) Any info or experiance about building Cobbler and Koan packages is welcome. Regards, Martijn van Brummelen

14 years, 10 months

4
4
0 / 0

Questions that get asked too much ... and how to eliminate them

by Michael DeHaan

Thinking aloud here, and really it's just thinking because I don't have a tremendous amount of bandwidth to enact many of these thoughts. Often folks do wrong things with import... though it's documented on the Wiki and in the manpage. I'm getting somewhat frustrated with answering the question, so when that happens, I typically think... what about the application can be done so that folks who do /not/ fully read and understand the documentation end up (A) figuring things out, and (B) not asking the question. So far, I think it's because import does not strongly enough force folks down the path of using a DVD or ... if not ... entering the right arguments to important for what they want to do. A wizard based approach versus command line flags /might/ work ... though it would have to be done for both the web app and the CLI. (I think there's also a lot of questions asked about repos and so forth. What others?) We could perhaps start with the web app and somehow suggest most folks start there ... and leave the command line as is (which is probably easier). This might just mean pushing the docs about the Web app and manpage higher up so folks find those first, and once we can do important from the WUI, that would perhaps solve it. --Michael

14 years, 10 months

1
0
0 / 0

Removing "raise" as well as print... and a demo of running a background reposync with proper task-specific logging

by Michael DeHaan

I've added a function "utils.die(logger, msg)" that I'm going to be moving things to instead of raise while I'm in the process of removing print statements. def die(logger, msg): # log the exception once in the per-task log or the main # log if this is not a background op. try: raise CX(msg) except: if logger is not None: log_exc(logger) else: log_exc(main_logger) # now re-raise it so the error can fail the operation raise CX(msg) The reason for this is that different task logs need to log their exceptions (if any) in the individual task files as opposed to in the main log, and there is not any global try/catch logic in the actions or the API... this is normally done in the web application or CLI. This is not totally refined yet (just added for reposync so far), though the intent is that the full traceback will be in the log file for any utils.die() calls and that these will also show up as the nicely formatted error messages we have today (no traceback) in the web app or CLI, with a link to the logs, where relevant. This may also eventually mean there is more logic in the die call later, TBD. It's a little weird, but it's all in the course of implementing our system of being able to run things in the background or the foreground and have them log (conditionally) to the correct place. For example, added distributions should go to the main log, but import is a background task, so added distributions added during the import go to the main log. Perhaps this can be a little cleaner but it is a start. Next week, we'll work on removing the remaining print calls throughout the actions and also cleaning up the exception handling. For trying this all out, download a new checkout of cobbler-devel, run "make webtest" to make sure the new daemon is running, and run the test program: #!/usr/bin/python import xmlrpclib import time s = xmlrpclib.Server("http://127.0.0.1/cobbler_api") token = s.login("testing","testing") # task1 = s.background_sync(token) task2 = s.background_reposync(["r1","r2"], 3, token) # new function names are subject to change until released #print s.get_task_status(task1) while True: print s.get_task_status(task2) time.sleep(1) While that is running, issue the following 3 times: sudo pkill reposync sudo pkill reposync sudo pkill reposync You should see the task status move to "failed" If you look in the logfile /var/log/cobbler/tasks/0.log, you should see the exception. (In the above example, I've briefly commented out the code to also try a background sync, which ends up being so instanteous in my environment there is little point in backgrounding it, but it is true that folks could have post-sync triggers installed that fire off other actions). Obviously in addition to all of this cleanup and making the CLI be remoted we also have to make tasks show up in the web app so you can see the results of the task that you kick off, as well as list tasks (and if there's a task queue, which there currently is not one implemented/needed). --Michael

14 years, 10 months

1
0
0 / 0

Logging

by Michael DeHaan

Plans for logging changes, which are a prereq to further work on background tasks: * Moving forward, we are going to be removing all /print/ calls from cobblerd actions, as all actions will be through cobblerd, as a result, there will be no printing. * We will be replacing all traceback.print_exc() calls with utils.log_exc(logger) * All subprocess calls will be replaced with a utils.something() call that also takes a logger, logs the command executed as a "info" entry and then logs the output in the same file. * All prints will be replaced, for starters, with logger.info, unless it's obvious that they are warning messages (logger.warning) or error messages (logger.error). * All CobblerExceptions will be logged by logger.error. * Each background task gets a log in /var/log/cobbler/tasks/$id.log, if there is no task, it will be logged in /var/log/cobbler/cobbler.log * Cobblerd.log goes away -- there's no need to seperate local and remote logs * When new tasks are created, the name of the log file will be mentioned in the log -- ditto for tasks completing or failing. * The CLI will most likely tail log files (unless requested not too) to give the impression of being local. Hopefully that makes sense. If not, it should be more self evident from coming commits. The changes are actually relatively minimal and somewhat overdue. Because of the changes for logging, the local CLI (which now has a split-brain problem with cobblerd until it is properly remoted on the 2.0 branch as planned) -- may not show output for some actions like you would expect. Given, however, this is /the/ item I'm working on until it's finished, so don't dispair for long... If you are using the development branch in any sort of "important" capacity, consider the warning that we do not intend for it to be useful or stable at this time :) --Michael

14 years, 10 months

3
4
0 / 0

cobblerd on ubuntu

by Pete Wright

hi all, i started working on getting cobblerd running on ubuntu-8.x. I have been able to build a debian package from source, it picks up the expected dependencies etc. yea! now i'm running into this problem when i try to run cobbler: pete@clyde:$ sudo cobbler list index out of range File "/usr/lib/python2.5/site-packages/cobbler/cobbler.py", line 83, in main rc = BootCLI().run(sys.argv) File "/usr/lib/python2.5/site-packages/cobbler/cobbler.py", line 45, in __init__ self.api = api.BootAPI(is_cobblerd=False) File "/usr/lib/python2.5/site-packages/cobbler/api.py", line 110, in __init__ self.os_version = utils.os_release() File "/usr/lib/python2.5/site-packages/cobbler/utils.py", line 824, in os_release rest = parts[1] This seems to be due to this bit of code in utils.py os_release() definition: elif check_dist() == "debian": fd = open("/etc/debian_version") parts = fd.read().split(".") version = parts[0] rest = parts[1] make = "debian" return (make, float(version), rest) On ubuntu /etc/debian_version reads as so on ubuntu 8 system: lenny/sid simply changing the split to happen on a "/" does not work as it seems that the code is expecting float for version. I started working on patching this and I think the best way to go about fixing this is to change utils.py's check_dist() function so that we read /etc/lsb-release, which I *think* should help us figure out if we are on a debian or ubuntu system - and which version it is. So quick question: - would it make sense to figure out what platform we are on for all systems by reading /etc/lsb-release oh yea, this is from the main git branch that i pulled today (06.25.09). it's tagged at cobbler-1.7.0 on my system... thanks! -pete -- Pete Wright Systems Engineer Demonware pete(a)demonware.net office: 310.255.2000 ext 3704 mobile: 604.802.5059

14 years, 10 months

2
1
0 / 0

RPM & handling cobblerd in %post

by Michael DeHaan

I've been told it's a bad idea for RPM scriptlets to call RPM in post. Calling condrestart on cobbler does this, certaintly. As a result, I'm thinking about /not/ calling condrestart in %post... so effectively after an upgrade, you are still running the old cobbler with the new CLI, and we'll have to detect that problem and work around it... things looking for version data should of course use /var/lib/cobbler/version first ... though perhaps we can avoid calling RPM altogether where we do today ... thoughts? (Yes, I know we don't call RPM on non-RPM platforms, this much is obvious... and we don't do so today) --Michael

14 years, 10 months

2
2
0 / 0

[PATCH] background task patches

by Vreman, Peter

Please find a couple of small patches for background tasks: Improvements: - Add background_power_system method. This makes it powering 10 systems with HP ILO using usefull, because it will take 20 seconds instead of 10x20=200 seconds. - Call background_sync and background_power_sytstem from WebUI - Add logging to task methods - Replaced STARTED state by SCHEDULED and RUNNING Hack to make saving of objects work: - Disable no_ctrlc (SIGINT) setting. It is not allowed in Threads. Regards, Peter This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.

14 years, 10 months

3
7
0 / 0

[Patch] keep_ssh_host_keys snippet - fix for fedora 11, added RAID support

by Leonid Flaks

I made two changes keep_ssh_host_keys snippet - list-harddrives does not work on fedora 11, also RAID array supprt is added. I see similar snippet keep_rhn_kees which could be patched in similar way. I tested it on fedora only. Leon diff --git a/snippets/keep_ssh_host_keys b/snippets/keep_ssh_host_keys index 527c992..655de7f 100644 --- a/snippets/keep_ssh_host_keys +++ b/snippets/keep_ssh_host_keys @@ -10,11 +10,7 @@ insmod /lib/ext3.o mkdir -p /tmp/ssh -drives=$(list-harddrives | awk '{print $1}') -for disk in $drives; do - DISKS="$DISKS $(fdisk -l /dev/$disk | awk '/^\/dev/{print $1}')" -done - +DISKS=$(cat /proc/partitions | sed -n '/^.*$sd[a-z][1-9].*$/{s||/dev/\1|p}') # Try to find the keys on ordinary partitions for disk in $DISKS; do name=$(basename $disk) @@ -33,6 +29,28 @@ for disk in $DISKS; do rm -r /tmp/$name done +# Try software RAID +if [ "$keys_found" = "no" ]; then + if mdadm -As; then + RDISKS="$(awk '/md/{print $1}' /proc/mdstat)" + for rdisk in $RDISKS; do + mkdir -p /tmp/$rdisk + mount /dev/$rdisk /tmp/$rdisk + [ $? -eq 0 ] || continue # Skip to the next partition if the mount fails + # Copy current ssh host keys out to be reused + if [ -d /tmp/${rdisk}/etc/ssh ]; then + cp -a /tmp/${rdisk}/etc/ssh/ssh_host* /tmp/ssh + keys_found="yes" + umount /tmp/$rdisk + break + fi + umount /tmp/$rdisk + rm -r /tmp/$rdisk + done + fi +fi + + # Try LVM if that didn't work if [ "$keys_found" = "no" ]; then lvm lvmdiskscan

14 years, 10 months

3
11
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

cobbler-devel June 2009