From: Scott Henson shenson@redhat.com To: cobbler-devel cobbler-devel@lists.fedorahosted.org Sent: Wed, January 13, 2010 5:21:50 PM Subject: Re: FW: [PATCH] Logging and cli error patches for master
Excerpts from Vreman, Peter's message of Tue Jan 12 05:51:13 -0500 2010:
Koan:
- afda8a88249ed3a124651a25fc52e9f78d1ab414 update string_to_hash and
hash_to_string from cobblerd to support multiple kernel options with the same name
Instead of type(hash) != dict, try isinstance(hash, dict), it should catch subclasses of dict as well. Otherwise this patch looks good.
(quoting from an old email of mine) If string values are legacy why not test against (base)str, so that we could use dictionary like objects in future?
Also, you could make buffer a list of strings ("key=val") and then join them by doing " ".join(buffer).
Cheers, Cristian