Excerpts from Vreman, Peter's message of Wed Jan 13 11:33:30 -0500 2010:
The change to isinstance() shall also be applied in cobbler/utils.py:hash_to_string()
I've gone ahead and checked this closer. It seems that isinstance doesn't work on el2.1AS, which means that we can't use it in koan unless we want to drop support for that.
As far as cobbler goes, I'd love to use it, as it should give a more accurate response. It should work on everything down to el3. I've gone ahead and merged these changes because there are plenty of examples of using that idiom all over cobbler. I'll probably look into redoing this sometime soonish.
I did this change to have a single configuration to change the verbosity of the logging. Now the logging depends on both the log level and the verbosity flag. When the verbose options is not set you get logging without contexts which action did make a call to a failed procedure.
For example the generation of a PXE file was not traced. When you change the netboot flag from CLI/WebUI it was never logged that a PXE file in tftpboot was created. And for sync the logging was inconsistent, the removal of the PXE files was logged, but not the creation.
Sounds good. Merging to my github.
There was one additional commit I missed in the mail:
remove none from interface dict 99ffc8ebd59f6209828385707f11ae1202dacc34
This fixes a single issue of RHEL4 XMLRPC not supporting None values. But it looks like it is a general problem. For the responses from the cobblerd the None values are translated to ~. But for the POST requests they are not. The commit fixes one situation, but i have already seen another place. But no time yet to patch that also.
Sounds good. Merged everything. I'll try to test in the next couple of days and merge it up to fh.