find not working because of unicode object data

[Vreman, Peter]

Maybe the it comes from the change to json, but the find for distro and repo is not
working:

2009-03-27 17:37:44,375 - api - find_distro; user(?)
2009-03-27 17:37:44,375 - api - {'name': 'RHEL'}; user(?)
2009-03-27 17:37:44,375 - api - Exception occured: cobbler.cexceptions.CX
2009-03-27 17:37:44,375 - api - Exception value: "find cannot compare type: <type
'unicode'>"
2009-03-27 17:37:44,376 - api - Exception Info:
  File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 1604, in
_dispatch
    return method_handle(*params)
   File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 604, in
find_distro
    data = self.__find(self.api.find_distro,criteria,expand=expand,token=token)
   File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 597, in
__find
    data = [x.to_datastruct_with_cache() for x in find_function(name, True, True,
**criteria)]
   File "/usr/lib/python2.3/site-packages/cobbler/api.py", line 432, in
find_distro
    return self._config.distros().find(name=name, return_list=return_list,
no_errors=no_errors, **kargs)
   File "/usr/lib/python2.3/site-packages/cobbler/collection.py", line 91, in
find
    if obj.find_match(kargs, no_errors=no_errors):
   File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 268, in
find_match
    if not self.find_match_single_key(data,key,value,no_errors):
   File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 295, in
find_match_single_key
    return self.__find_compare(value, data[key])
   File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 336, in
__find_compare
    raise CX(_("find cannot compare type: %s") % type(from_obj))

The following patch fixes this for me:

--- old/cobbler/item.py 2009-03-27 14:51:25.000000000 +0100
+++ build/cobbler/item.py       2009-03-27 17:54:16.000000000 +0100
@@ -297,7 +297,7 @@

     def __find_compare(self, from_search, from_obj):

-        if type(from_obj) == type(""):
+        if type(from_obj) == type("") or type(from_obj) == unicode:
             # FIXME: fnmatch is only used for string to string comparisions
             # which should cover most major usage, if not, this deserves fixing
             if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):


Regards,
Peter



This e-mail and any attachment is for authorised use by the intended recipient(s) only. It
may contain proprietary material, confidential information and/or be subject to legal
privilege. It should not be copied, disclosed to, retained or used by, any other party. If
you are not an intended recipient then please promptly delete this e-mail and any
attachment and all copies and inform the sender. Thank you.

[James Cammarata]

On Fri, 27 Mar 2009 18:10:24 +0100, "Vreman, Peter - Acision"
<peter.vreman(a)acision.com&gt; wrote:
>  Maybe the it comes from the change to json, but the find for distro
> and
>  repo is not working:
>  
>  2009-03-27 17:37:44,375 - api - find_distro; user(?)
>  2009-03-27 17:37:44,375 - api - {'name': 'RHEL'}; user(?)
>  2009-03-27 17:37:44,375 - api - Exception occured: cobbler.cexceptions.CX
>  2009-03-27 17:37:44,375 - api - Exception value: "find cannot compare 
type:
>  <type 'unicode'>"
>  2009-03-27 17:37:44,376 - api - Exception Info:
>    File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 1604,
in
>    _dispatch
>      return method_handle(*params)
>     File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 604,
in
>     find_distro
>      data =
>      self.__find(self.api.find_distro,criteria,expand=expand,token=token)
>     File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 597,
in
>     __find
>      data = [x.to_datastruct_with_cache() for x in find_function(name, 
True,
>      True, **criteria)]
>     File "/usr/lib/python2.3/site-packages/cobbler/api.py", line 432, in
>     find_distro
>      return self._config.distros().find(name=name, 
return_list=return_list,
>      no_errors=no_errors, **kargs)
>     File "/usr/lib/python2.3/site-packages/cobbler/collection.py", line
91,
>     in find
>      if obj.find_match(kargs, no_errors=no_errors):
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 268, in
>     find_match
>      if not self.find_match_single_key(data,key,value,no_errors):
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 295, in
>     find_match_single_key
>      return self.__find_compare(value, data[key])
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 336, in
>     __find_compare
>      raise CX(_("find cannot compare type: %s") % type(from_obj))
>  
>  The following patch fixes this for me:
>  
>  --- old/cobbler/item.py 2009-03-27 14:51:25.000000000 +0100
>  +++ build/cobbler/item.py       2009-03-27 17:54:16.000000000 +0100
>  @@ -297,7 +297,7 @@
>  
>       def __find_compare(self, from_search, from_obj):
>  
>  -        if type(from_obj) == type(""):
>  +        if type(from_obj) == type("") or type(from_obj) == unicode:
>               # FIXME: fnmatch is only used for string to string
>               comparisions
>               # which should cover most major usage, if not, this deserves
>               fixing
>               if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):
>  
>   

Funny, we were just talking about this in IRC...

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

[Scott Henson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

James Cammarata wrote:
| On Fri, 27 Mar 2009 18:10:24 +0100, "Vreman, Peter - Acision"
| <peter.vreman(a)acision.com&gt; wrote:
|> Maybe the it comes from the change to json, but the find for distro and
|> repo is not working:
|> <snip>
|>
|>
|> -        if type(from_obj) == type(""):
|> +        if type(from_obj) == type("") or type(from_obj) == unicode:
|>              # FIXME: fnmatch is only used for string to string
|>              comparisions
|>              # which should cover most major usage, if not, this deserves
|>              fixing
|>              if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):
|>
|>
|
|
| Funny, we were just talking about this in IRC...
|

Indeed, I also get the same error on cobblerd start and on system add 
from a similar thing.  John came up with a better solution, which is to 
test isinstance(from_obj, basestring).  Might be better to go with that 
instead.


- --
Scott Henson
Red Hat CIS Operator
WVU Alum BSAE/BSME
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iEYEARECAAYFAknNCkAACgkQZ+CEIfzQ+EqbJQCgifwUPdCbAaRB67xrbrdNd8Px
> Ci4An1F8SJbpWWcnkJKDVhf0B3almKbh
> =5pJ4
> -----END PGP SIGNATURE-----

[PATCH] Re: find not working because of unicode object data

[Scott Henson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Attached is a patch to fix this problem using isinstance in the three 
places that I have seen this cause problems.

- --
Scott Henson
Red Hat CIS Operator
WVU Alum BSAE/BSME
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iEYEARECAAYFAknNGqUACgkQZ+CEIfzQ+EoefACggBwZ2QULdCw0Fafs18+2X95J
> 9oIAn1pmamT+RGMvIz/yD8ghgU/v2kA4
> =Xr/i
> -----END PGP SIGNATURE----- 

> From 962fcc5937e824faaf7a1b3f39fda9d409e6cae1 Mon Sep 17 00:00:00 2001
From: Scott Henson <shenson(a)redhat.com&gt;
Date: Fri, 27 Mar 2009 14:26:37 -0400
Subject: [PATCH] Switch to using isinstance to determine if an input is a string

---
 cobbler/item.py        |    4 ++--
 cobbler/item_system.py |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cobbler/item.py b/cobbler/item.py
index fc3a914..2493c45 100644
--- a/cobbler/item.py
+++ b/cobbler/item.py
@@ -122,7 +122,7 @@ class Item(serializable.Serializable):
         """
         if self.name not in ["",None] and self.parent not in
["",None] and self.name == self.parent:
             raise CX(_("self parentage is weird"))
-        if type(name) != type(""):
+        if isinstance(name, basestring):
             raise CX(_("name must be a string"))
         for x in name:
             if not x.isalnum() and not x in [ "_", "-",
".", ":", "+" ] :
@@ -297,7 +297,7 @@ class Item(serializable.Serializable):
 
     def __find_compare(self, from_search, from_obj):
 
-        if type(from_obj) == type(""):
+        if isinstance(from_obj, basestring):
             # FIXME: fnmatch is only used for string to string comparisions
             # which should cover most major usage, if not, this deserves fixing
             if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):
diff --git a/cobbler/item_system.py b/cobbler/item_system.py
index b7e7744..999b6d4 100644
--- a/cobbler/item_system.py
+++ b/cobbler/item_system.py
@@ -317,7 +317,7 @@ class System(item.Item):
 
         if self.name not in ["",None] and self.parent not in
["",None] and self.name == self.parent:
             raise CX(_("self parentage is weird"))
-        if type(name) != type(""):
+        if isinstance(name, basestring):
             raise CX(_("name must be a string"))
         for x in name:
             if not x.isalnum() and not x in [ "_", "-",
".", ":", "+" ] :
-- 
1.6.0.6

[PATCH] Re: find not working because of unicode object data

[Scott Henson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Scott Henson wrote:
| Attached is a patch to fix this problem using isinstance in the three 
places that I have seen this cause problems.
|
This as well.  Just to be on the safe side.
- -------------------------

_______________________________________________
cobbler-devel mailing list
cobbler-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel


- --
Scott Henson
Red Hat CIS Operator
WVU Alum BSAE/BSME
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iEYEARECAAYFAknNG7MACgkQZ+CEIfzQ+EoVQQCeP46TecU08glXS/GJbKSmaQ0J
> CxkAni/GgTzz8/zkwN4xgyghn/DBNR8L
> =QL1V
> -----END PGP SIGNATURE----- 

> From 0f181b6159f46cc2dfbc0952f5c3c99bb478ace1 Mon Sep 17 00:00:00 2001
From: Scott Henson <shenson(a)redhat.com&gt;
Date: Fri, 27 Mar 2009 14:31:45 -0400
Subject: [PATCH] This use might cause problems as well

---
 cobbler/item.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cobbler/item.py b/cobbler/item.py
index 2493c45..1913d78 100644
--- a/cobbler/item.py
+++ b/cobbler/item.py
@@ -306,7 +306,7 @@ class Item(serializable.Serializable):
                 return False    
         
         else:
-            if type(from_search) == type(""):
+            if isinstance(from_search, basestring):
                 if type(from_obj) == type([]):
                     from_search =
utils.input_string_or_list(from_search,delim=',')
                     for x in from_search:
-- 
1.6.0.6

[PATCH] Re: find not working because of unicode object data

[Michael DeHaan]

Scott Henson wrote:
>  -----BEGIN PGP SIGNED MESSAGE-----
>  Hash: SHA1
>
>  Scott Henson wrote:
>  | Attached is a patch to fix this problem using isinstance in the 
>  three places that I have seen this cause problems.
>  |
>  This as well.  Just to be on the safe side.
>  - -------------------------
>
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>
>
>  - --
>  Scott Henson
>  Red Hat CIS Operator
>  WVU Alum BSAE/BSME
> >  -----BEGIN PGP SIGNATURE-----
> >  Version: GnuPG v1.4.9 (GNU/Linux)
> >  Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
> >
> >  iEYEARECAAYFAknNG7MACgkQZ+CEIfzQ+EoVQQCeP46TecU08glXS/GJbKSmaQ0J
> >  CxkAni/GgTzz8/zkwN4xgyghn/DBNR8L
> >  =QL1V
> >  -----END PGP SIGNATURE----- 
>  ------------------------------------------------------------------------
>
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel 
Applied to master and devel (both patches), thanks!

I'm still curious as to what the root cause is... perhaps simplejson is 
sending back unicode depending on the locale.... it doesn't happen on my 
F10 machines.

Anyway, fix applied... the code is definitely better this way.

--Michael

[Michael DeHaan]

Vreman, Peter - Acision wrote:
>  Maybe the it comes from the change to json, but the find for distro 
>  and repo is not working:
>
>   
>
>  2009-03-27 17:37:44,375 - api - find_distro; user(?)
>
>  2009-03-27 17:37:44,375 - api - {'name': 'RHEL'}; user(?)
>
>  2009-03-27 17:37:44,375 - api - Exception occured: cobbler.cexceptions.CX
>
>  2009-03-27 17:37:44,375 - api - Exception value: "find cannot compare 
>  type: <type 'unicode'>"
>
>  2009-03-27 17:37:44,376 - api - Exception Info:
>
>    File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
>  1604, in _dispatch
>
>      return method_handle(*params)
>
>     File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
>  604, in find_distro
>
>      data = 
>  self.__find(self.api.find_distro,criteria,expand=expand,token=token)
>
>     File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
>  597, in __find
>
>      data = [x.to_datastruct_with_cache() for x in find_function(name, 
>  True, True, **criteria)]
>
>     File "/usr/lib/python2.3/site-packages/cobbler/api.py", line 432, 
>  in find_distro
>
>      return self._config.distros().find(name=name, 
>  return_list=return_list, no_errors=no_errors, **kargs)
>
>     File "/usr/lib/python2.3/site-packages/cobbler/collection.py", line 
>  91, in find
>
>      if obj.find_match(kargs, no_errors=no_errors):
>
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 268, 
>  in find_match
>
>      if not self.find_match_single_key(data,key,value,no_errors):
>
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 295, 
>  in find_match_single_key
>
>      return self.__find_compare(value, data[key])
>
>     File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 336, 
>  in __find_compare
>
>      raise CX(_("find cannot compare type: %s") % type(from_obj))
>
>   
>
>  The following patch fixes this for me:
>
>   
>
>  --- old/cobbler/item.py 2009-03-27 14:51:25.000000000 +0100
>
>  +++ build/cobbler/item.py       2009-03-27 17:54:16.000000000 +0100
>
>  @@ -297,7 +297,7 @@
>
>   
>
>       def __find_compare(self, from_search, from_obj):
>
>   
>
>  -        if type(from_obj) == type(""):
>
>  +        if type(from_obj) == type("") or type(from_obj) == unicode:
>
>               # FIXME: fnmatch is only used for string to string 
>  comparisions
>
>               # which should cover most major usage, if not, this 
>  deserves fixing
>
>               if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):
>
>   
>
>   
>
>  Regards,
>
>  Peter
>
>   
>
>
>  This e-mail and any attachment is for authorised use by the intended 
>  recipient(s) only. It may contain proprietary material, confidential 
>  information and/or be subject to legal privilege. It should not be 
>  copied, disclosed to, retained or used by, any other party. If you are 
>  not an intended recipient then please promptly delete this e-mail and 
>  any attachment and all copies and inform the sender. Thank you.
>  ------------------------------------------------------------------------
>
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>     
Thanks for the fix Peter,

We're going to go with Scott's patch just because it seems a bit cleaner.

Much appreciated just the same!

--Michael

[Michael DeHaan]

Michael DeHaan wrote:
>  Vreman, Peter - Acision wrote:
>    
> > Maybe the it comes from the change to json, but the find for distro 
> > and repo is not working:
> >
> >  
> >
> > 2009-03-27 17:37:44,375 - api - find_distro; user(?)
> >
> > 2009-03-27 17:37:44,375 - api - {'name': 'RHEL'}; user(?)
> >
> > 2009-03-27 17:37:44,375 - api - Exception occured: cobbler.cexceptions.CX
> >
> > 2009-03-27 17:37:44,375 - api - Exception value: "find cannot compare 
> > type: <type 'unicode'>"
> >
> > 2009-03-27 17:37:44,376 - api - Exception Info:
> >
> >   File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
> > 1604, in _dispatch
> >
> >     return method_handle(*params)
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
> > 604, in find_distro
> >
> >     data = 
> > self.__find(self.api.find_distro,criteria,expand=expand,token=token)
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/remote.py", line 
> > 597, in __find
> >
> >     data = [x.to_datastruct_with_cache() for x in find_function(name, 
> > True, True, **criteria)]
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/api.py", line 432, 
> > in find_distro
> >
> >     return self._config.distros().find(name=name, 
> > return_list=return_list, no_errors=no_errors, **kargs)
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/collection.py", line 
> > 91, in find
> >
> >     if obj.find_match(kargs, no_errors=no_errors):
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 268, 
> > in find_match
> >
> >     if not self.find_match_single_key(data,key,value,no_errors):
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 295, 
> > in find_match_single_key
> >
> >     return self.__find_compare(value, data[key])
> >
> >    File "/usr/lib/python2.3/site-packages/cobbler/item.py", line 336, 
> > in __find_compare
> >
> >     raise CX(_("find cannot compare type: %s") % type(from_obj))
> >
> >  
> >
> > The following patch fixes this for me:
> >
> >  
> >
> > --- old/cobbler/item.py 2009-03-27 14:51:25.000000000 +0100
> >
> > +++ build/cobbler/item.py       2009-03-27 17:54:16.000000000 +0100
> >
> > @@ -297,7 +297,7 @@
> >
> >  
> >
> >      def __find_compare(self, from_search, from_obj):
> >
> >  
> >
> > -        if type(from_obj) == type(""):
> >
> > +        if type(from_obj) == type("") or type(from_obj) == unicode:
> >
> >              # FIXME: fnmatch is only used for string to string 
> > comparisions
> >
> >              # which should cover most major usage, if not, this 
> > deserves fixing
> >
> >              if fnmatch.fnmatch(from_obj.lower(), from_search.lower()):
> >
> >  
> >
> >  
> >
> > Regards,
> >
> > Peter
> >
> >  
> >
> >
> > This e-mail and any attachment is for authorised use by the intended 
> > recipient(s) only. It may contain proprietary material, confidential 
> > information and/or be subject to legal privilege. It should not be 
> > copied, disclosed to, retained or used by, any other party. If you are 
> > not an intended recipient then please promptly delete this e-mail and 
> > any attachment and all copies and inform the sender. Thank you.
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > cobbler-devel mailing list
> > cobbler-devel(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/cobbler-devel
> >   
> >     
>
>  Thanks for the fix Peter,
>
>  We're going to go with Scott's patch just because it seems a bit cleaner.
>
>  Much appreciated just the same!
>
>  --Michael
>
>
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>     
Actually I'm seeing "name must be a string" after having applied Scott's

patch.

We may use the above... I'll figure it out.

--Michael

[Michael DeHaan]

>  Actually I'm seeing "name must be a string" after
> having applied Scott's 
>  patch.
>
>  We may use the above... I'll figure it out.
>
>  --Michael
>
>
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>     
Scott forgot a few "nots" in that patch, I'll fix them and apply.