[PATCH] adding support for bridged interfaces and fixing the json settings issue

[James Cammarata]

I've created a new feature branch on my github named bridge-interface,
which contains these commits.

Commit ea97db0b54d4e9ef593b326ac0cc6b2624bf4e7b is the JSON settings
fix for utils.py, it's in both the master and bridge-interface branch.

These patches represent a pretty major change in some of the code
paths, especially the network config snippets, so we'll need a lot of
testing. I've done testing with mixed bridges/vlans, but I haven't yet
done a bridge of a bond yet (does anyone actually do that?), so there
could be some weird corner case that I haven't run into yet.


commit de0aacd40116b35e86f6de3d7d2c4e0282f37cb8
Author: James Cammarata <jimi(a)sngx.net&gt;
Date:   Sat Jul 30 09:14:47 2011 -0500

    Cleanup of bonding stuff in all files, including webui and koan.
Additional cleanup in the
    network config scripts, and re-added the modprobe.conf renaming
code to the post install
    network config.

commit cc07f35804058b49ea09499c0f70d211d6d4b5ef
Author: James Cammarata <jimi(a)sngx.net&gt;
Date:   Wed Jul 27 22:08:29 2011 -0500

    Initial rework to allow bridge/bridge slave interfaces
    Added static route configuration to pre_install_network_config
    Major cleanup/reworking of post_install_network_config script

    * TODO:
    Need to fix web interface/templates, manage_isc, buildiso,
snippets/network_config{,_esx*} and koan

commit ea97db0b54d4e9ef593b326ac0cc6b2624bf4e7b
Author: James Cammarata <jimi(a)sngx.net&gt;
Date:   Wed Jul 27 21:23:18 2011 -0500

    Fix for bad commit of some json settings test

[Jörgen Maas]

James,

Would this be a good time to rename "subnet" to "netmask" aswell?
Good work!

Grtz,
Jörgen Maas


On Sat, Jul 30, 2011 at 6:01 PM, James Cammarata <jimi(a)sngx.net&gt; wrote:
>  I've created a new feature branch on my github named
> bridge-interface,
>  which contains these commits.
>
>  Commit ea97db0b54d4e9ef593b326ac0cc6b2624bf4e7b is the JSON settings
>  fix for utils.py, it's in both the master and bridge-interface branch.
>
>  These patches represent a pretty major change in some of the code
>  paths, especially the network config snippets, so we'll need a lot of
>  testing. I've done testing with mixed bridges/vlans, but I haven't yet
>  done a bridge of a bond yet (does anyone actually do that?), so there
>  could be some weird corner case that I haven't run into yet.
>
>
>  commit de0aacd40116b35e86f6de3d7d2c4e0282f37cb8
>  Author: James Cammarata <jimi(a)sngx.net&gt;
>  Date:   Sat Jul 30 09:14:47 2011 -0500
>
>     Cleanup of bonding stuff in all files, including webui and koan.
>  Additional cleanup in the
>     network config scripts, and re-added the modprobe.conf renaming
>  code to the post install
>     network config.
>
>  commit cc07f35804058b49ea09499c0f70d211d6d4b5ef
>  Author: James Cammarata <jimi(a)sngx.net&gt;
>  Date:   Wed Jul 27 22:08:29 2011 -0500
>
>     Initial rework to allow bridge/bridge slave interfaces
>     Added static route configuration to pre_install_network_config
>     Major cleanup/reworking of post_install_network_config script
>
>     * TODO:
>     Need to fix web interface/templates, manage_isc, buildiso,
>  snippets/network_config{,_esx*} and koan
>
>  commit ea97db0b54d4e9ef593b326ac0cc6b2624bf4e7b
>  Author: James Cammarata <jimi(a)sngx.net&gt;
>  Date:   Wed Jul 27 21:23:18 2011 -0500
>
>     Fix for bad commit of some json settings test
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>

[James Cammarata]

On Sun, Jul 31, 2011 at 7:57 AM, Jörgen Maas <jorgen.maas(a)gmail.com&gt; wrote:
>  James,
>
>  Would this be a good time to rename "subnet" to "netmask" aswell?
>  Good work!
>
>  Grtz,
>  Jörgen Maas 
Hrm, I thought we had changed that a while back? Maybe it was from
--network to --subnet though. Is there a trac RFE for this change?

[Jörgen Maas]

Yes there is ;-).

https://fedorahosted.org/cobbler/ticket/513


On Sun, Jul 31, 2011 at 5:56 PM, James Cammarata <jimi(a)sngx.net&gt; wrote:
>  On Sun, Jul 31, 2011 at 7:57 AM, Jörgen Maas
> <jorgen.maas(a)gmail.com&gt; wrote:
> > James,
> >
> > Would this be a good time to rename "subnet" to "netmask"
> aswell?
> > Good work!
> >
> > Grtz,
> > Jörgen Maas
>
>  Hrm, I thought we had changed that a while back? Maybe it was from
>  --network to --subnet though. Is there a trac RFE for this change?
>  _______________________________________________
>  cobbler-devel mailing list
>  cobbler-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler-devel
>

[Scott Henson]

On Sun, 31 Jul 2011 14:57:09 +0200, Jörgen Maas <jorgen.maas(a)gmail.com&gt; wrote:
>  James,
>  
>  Would this be a good time to rename "subnet" to "netmask" aswell?
>  Good work! 
This has been discussed heavily in the past, I think the migration would
be a big pain. I would probably support to add a patch that makes subnet
an alias for netmask. Then sometime further down the road switch, then
eventually delete subnet.

-- 
Scott Henson
Red Hat SOC Operator
WVU Alum BSAE/BSME

[Scott Henson]

On Sat, 30 Jul 2011 11:01:34 -0500, James Cammarata <jimi(a)sngx.net&gt; wrote:
>  I've created a new feature branch on my github named
> bridge-interface,
>  which contains these commits. 
Commited. Thanks.

-- 
Scott Henson
Red Hat SOC Operator
WVU Alum BSAE/BSME