8:49 p.m.
https://github.com/jimi1283/cobbler/tree/dynamicsettings
commit 862e3f583efc6055e5a605a60ee29298a968e53b
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 1 20:29:51 2012 -0500
Initial support for modifying settings live
Changed settings do not survive a reboot and revert to what's in
/etc/cobbler/settings
TODO:
* report --name show a single setting
* validate settings based on type (string, list, bool, etc.)
* web support for editing
* persisting settings after change
Obviously, a lot still todo, but I think this is something that's been
long overdue. I haven't quite figured out the best way to save
settings without mangling the /etc/cobbler/settings file, but I'm
leaning towards a template to preserve the existing format with all
the comments. Any other suggestions are welcome.
Not sure if this would get done for 2.4, but I would like to target it
for that release.
9:15 p.m.
On Sun, Apr 1, 2012 at 20:49, James Cammarata <jimi(a)sngx.net> wrote:
https://github.com/jimi1283/cobbler/tree/dynamicsettings
commit 862e3f583efc6055e5a605a60ee29298a968e53b
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 1 20:29:51 2012 -0500
Initial support for modifying settings live
Changed settings do not survive a reboot and revert to what's in
/etc/cobbler/settings
TODO:
* report --name show a single setting
* validate settings based on type (string, list, bool, etc.)
* web support for editing
* persisting settings after change
Obviously, a lot still todo, but I think this is something that's been
long overdue. I haven't quite figured out the best way to save
settings without mangling the /etc/cobbler/settings file, but I'm
leaning towards a template to preserve the existing format with all
the comments. Any other suggestions are welcome.
I would see if you can accomplish what you want using augeas... it
already has lenses for cobbler's settings file.
-greg
10:36 p.m.
Kewl. Fyi python-augeas won't be in stable EPEL till sometime next week,
but its in updates-testing now.
On Apr 1, 2012 9:54 PM, "James Cammarata" <jimi(a)sngx.net> wrote:
> I would see if you can accomplish what you want using augeas...
it
> already has lenses for cobbler's settings file.
I hadn't considered augeas, I usually associate that with ruby and
puppet only. I added a commit to that branch that now writes settings
via python-augeas.
_______________________________________________
cobbler-devel mailing list
cobbler-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel
5:10 p.m.
just pushed python-augeas to stable for EPEL 5+6
-greg
On Sun, Apr 1, 2012 at 22:36, Greg Swift <gregswift(a)gmail.com> wrote:
Kewl. Fyi python-augeas won't be in stable EPEL till sometime
next week,
but its in updates-testing now.
On Apr 1, 2012 9:54 PM, "James Cammarata" <jimi(a)sngx.net> wrote:
>
> > I would see if you can accomplish what you want using augeas... it
> > already has lenses for cobbler's settings file.
>
> I hadn't considered augeas, I usually associate that with ruby and
> puppet only. I added a commit to that branch that now writes settings
> via python-augeas.
> _______________________________________________
> cobbler-devel mailing list
> cobbler-devel(a)lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/cobbler-devel
3:23 a.m.
On Sun, Apr 1, 2012 at 22:36, Greg Swift <gregswift(a)gmail.com>
wrote:
> Kewl. Fyi python-augeas won't be in stable EPEL till sometime next week,
> but its in updates-testing now.
>
> On Apr 1, 2012 9:54 PM, "James Cammarata" <jimi(a)sngx.net> wrote:
>>
>> > I would see if you can accomplish what you want using augeas... it
>> > already has lenses for cobbler's settings file.
>>
>> I hadn't considered augeas, I usually associate that with ruby and
>> puppet only. I added a commit to that branch that now writes settings
>> via python-augeas.
https://github.com/jimi1283/cobbler/commit/a3983bf249bb3080106addd4bf4b25...
commit a3983bf249bb3080106addd4bf4b250b2b367001
Author: James Cammarata <jimi(a)sngx.net>
Date: Tue Apr 3 03:12:10 2012 -0500
Dynamic settings edit support for the web GUI
Next up is adding support to determine if a setting is a string,
boolean, list, etc. with appropriate editing option for the web GUI
(combo box, multi-select, whatever). Also, need to disallow editing of
the "server" variable dynamically - it breaks things quite quickly.
CLI options I'm considering adding too:
--no-persist: don't rewrite the settings file. Might be useful for
testing changes you don't want to save so a cobblerd restart restores
things to the way they were.
--sync: force a full sync after the setting is changed.
8:57 a.m.
commit b9b842b34237a19f9ea2c01fb915b13259af6d74
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 15 08:50:21 2012 -0500
Add setting to enable/disable dynamic settings changes
Adding cobblersettings.aug to distributed files, since we need a
copy that doesn't insert tabs
Added a "cobbler check" that checks if dynamic settings is enabled
and prints a sed command to cleanup the settings file spacing/indent
---
In order to avoid some potential problems with augeas and indents in
YAML, I've made the following changes above. Essentially, to do
dynamic settings you have to specifically enable them via the
allow_dynamic_settings variable, which defaults to 0. If it is
enabled, "cobbler check" will print out a sed command to run on the
settings file to ensure all of the indents for lists/dicts are
consistent.
We are also adding an augeas lens to the distribution which is based
on the officially distributed one but with some fixes (no tabs, which
are invalid in YAML). After running the above sed command on the
settings file, augeas can manage it without fear of corruption due to
inconsistent indentation (which is all over the default file).
10:03 a.m.
Did you verify the default settings file is consistent?
On Apr 15, 2012 8:57 AM, "James Cammarata" <jimi(a)sngx.net> wrote:
commit b9b842b34237a19f9ea2c01fb915b13259af6d74
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 15 08:50:21 2012 -0500
Add setting to enable/disable dynamic settings changes
Adding cobblersettings.aug to distributed files, since we need a
copy that doesn't insert tabs
Added a "cobbler check" that checks if dynamic settings is enabled
and prints a sed command to cleanup the settings file spacing/indent
---
In order to avoid some potential problems with augeas and indents in
YAML, I've made the following changes above. Essentially, to do
dynamic settings you have to specifically enable them via the
allow_dynamic_settings variable, which defaults to 0. If it is
enabled, "cobbler check" will print out a sed command to run on the
settings file to ensure all of the indents for lists/dicts are
consistent.
We are also adding an augeas lens to the distribution which is based
on the officially distributed one but with some fixes (no tabs, which
are invalid in YAML). After running the above sed command on the
settings file, augeas can manage it without fear of corruption due to
inconsistent indentation (which is all over the default file).
_______________________________________________
cobbler-devel mailing list
cobbler-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel
10:08 a.m.
On Sun, Apr 15, 2012 at 10:06 AM, James Cammarata <jimi(a)sngx.net> wrote:
On Sun, Apr 15, 2012 at 10:03 AM, Greg Swift
<gregswift(a)gmail.com> wrote:
> Did you verify the default settings file is consistent?
>
Not yet, I realized I should have done that after this commit... I'll
take care of that on the next one.
In fact, here you go:
commit ada7db54532d9846d1f4558fafb29453738e4b81
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 15 10:07:07 2012 -0500
Run the same sed command on the default distributed config file to
ensure consistent indentation
6:20 p.m.
Nice
On Apr 15, 2012 10:08 AM, "James Cammarata" <jimi(a)sngx.net> wrote:
On Sun, Apr 15, 2012 at 10:06 AM, James Cammarata
<jimi(a)sngx.net> wrote:
> On Sun, Apr 15, 2012 at 10:03 AM, Greg Swift <gregswift(a)gmail.com>
wrote:
>> Did you verify the default settings file is consistent?
>>
>
> Not yet, I realized I should have done that after this commit... I'll
> take care of that on the next one.
In fact, here you go:
commit ada7db54532d9846d1f4558fafb29453738e4b81
Author: James Cammarata <jimi(a)sngx.net>
Date: Sun Apr 15 10:07:07 2012 -0500
Run the same sed command on the default distributed config file to
ensure consistent indentation
_______________________________________________
cobbler-devel mailing list
cobbler-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/cobbler-devel
4399
days inactive
4412
days old
cobbler-devel@lists.fedorahosted.org
10 comments
2 participants
participants (2)
-
Greg Swift -
James Cammarata