Re: [cobbler] can't save networking options of a system in cobbler web interface. (#8)

[James Cammarata]

On Fri, Dec 2, 2011 at 4:36 AM, harveyzh
<reply+i-2425913-a30f42d840f54cb26b206edd25ffbc4a6b62a94a-26403(a)reply.github.com&gt;
wrote:
>  After modifying and saving the networking options of a system in
> cobbler web interface, i found that the modification was lost.
>
>  I am using the cobbler-2.3.1-1 and cobbler-web-2.3.1-1 on centos 6.0, which are built
> from the git master (the latest commit is 525122d267c3a0ec3a353d52458be9d1612b3388 ). But
> in cobbler-2.2.2-1, it works fine.
>
>  How to reproduce
>  -----
>  1. add a new interface
>  2. click the "Generate Random MAC" button
>  3. fill the IP Address
>  4. check the "static" option checked
>  5. fill the Subnet Mask and Virt Bridge
>  6. finanlly save 
After lots of git bisects...

18eb1c06779b37d89dfb2962a08236dd1bab24a6 is the first bad commit
commit 18eb1c06779b37d89dfb2962a08236dd1bab24a6
Author: James Cammarata <jimi(a)sngx.net&gt;
Date:   Fri Nov 4 02:33:38 2011 -0500

    Additional CSRF work. All URLs that modify state are now required
to be POSTs only.

:040000 040000 1398d8f5fe4818f34cdce702b073eb974f368065
47770201913af8bb2a0a97f03fecdc4f4449504e M      web

So something about saving interfaces doesn't like CSRF apparently.
Which is odd, because saving any other attribute on the system works
just fine - it's just the interface stuff that doesn't save correctly.

[cobbler] can't save networking options of a system in cobbler web interface. (#8)

[James Cammarata]

On Mon, Dec 5, 2011 at 6:26 PM, James Cammarata <jimi(a)sngx.net&gt; wrote:
>  On Fri, Dec 2, 2011 at 4:36 AM, harveyzh
>  <reply+i-2425913-a30f42d840f54cb26b206edd25ffbc4a6b62a94a-26403(a)reply.github.com&gt;
>  wrote:
> > After modifying and saving the networking options of a system in cobbler web
> interface, i found that the modification was lost.
> >
> > I am using the cobbler-2.3.1-1 and cobbler-web-2.3.1-1 on centos 6.0, which are built
> from the git master (the latest commit is 525122d267c3a0ec3a353d52458be9d1612b3388 ). But
> in cobbler-2.2.2-1, it works fine. 
Found the issue. As part of the CSRF work, we changed everything over
to posts, and added a general form for various javascript functions to
use. The generic edit template was using forms[0], which no longer
pointed at the correct form. This may bite us again with other pages,
but I haven't dug through all of the javascript yet to check if we use
forms[0] anywhere else.

Pushed to both master and release22:

commit 5e75d8ef04e53d611d3eb0ee948db484f8b1af46
Author: James Cammarata <jimi(a)sngx.net&gt;
Date:   Tue Dec 6 19:13:27 2011 -0600

    BUGFIX - fix for following issue:
    can't save networking options of a system in cobbler web interface. (#8)

    Problem caused by using forms[0] in javascript instead of a named
form. When implementing CSRF some other forms were added, causing a
conflict.