Re: [PATCH 1/2] KerneloopsReporter: fix missing bt

[Denys Vlasenko]

On Tue, 2010-08-31 at 19:16 +0200, Nikola Pajkovsky wrote:
>  when post failed, abrt still show message
>  that everything is fine
>  
>  Signed-off-by: Nikola Pajkovsky <npajkovs(a)redhat.com&gt;
>  ---
>   lib/plugins/KerneloopsReporter.cpp |   26 +++++++++++++-------------
>   1 files changed, 13 insertions(+), 13 deletions(-)
>  
>  diff --git a/lib/plugins/KerneloopsReporter.cpp b/lib/plugins/KerneloopsReporter.cpp
>  index cee1bad..76f8ed1 100644
>  --- a/lib/plugins/KerneloopsReporter.cpp
>  +++ b/lib/plugins/KerneloopsReporter.cpp
>  @@ -90,24 +90,24 @@ std::string CKerneloopsReporter::Report(const map_crash_data_t&
> pCrashData,
>                                           const map_plugin_settings_t& pSettings,
>                                           const char *pArgs)
>   {
>  -    CURLcode ret;
>  +    CURLcode ret = CURLE_OK;
>   
>       update_client(_("Creating and submitting a report..."));
>   
>       map_crash_data_t::const_iterator it = pCrashData.find(FILENAME_BACKTRACE);
>  -    if (it != pCrashData.end())
>  +    if (it == pCrashData.end())
>  +        return "Kernel oops report was failed, missiging backtrace"; 
NAK. It needs to be a proper English.

-- 
vda