RFC: Proposing incompatible upgrade of python-asgiref from 3.4.1 to 3.7.2

[Michel Lind]

Dear all,

Django 4.2 (the only currently supported LTS series) requires asgiref >=
3.6, so I would like to propose updating python-asgiref in EPEL 9 at
least to 3.6.0, but ideally to 3.8.1 for future proofing.

The affected packages (maintainers bcc:ed) are python-django3 (which I
maintain, and has just reached EOL) and python-opentelemetry

❯ fedrq whatrequires 'python3dist(asgiref)' -b epel9
python-django3-3.2.20-3.el9.src                                       
python-opentelemetry-1.12.0-8.el9.src

❯ fedrq pkgs --src -P python-django3 -F requires -b epel9 | grep asgi
python3dist(asgiref) >= 3.3.2
(python3dist(asgiref) < 4~~ with python3dist(asgiref) >= 3.3.2)

❯ fedrq pkgs --src -P python-opentelemetry -F requires -b epel9 | grep asgi
(python3dist(asgiref) >= 3 with python3dist(asgiref) < 4)

The relevant breaking changes seem to be (starting from the safest
option of upgrading only to 3.6.0)

https://github.com/django/asgiref/blob/main/CHANGELOG.txt

* 3.6.0
  Support for the ``ASGI_THREADS`` environment variable, used by
  ``SyncToAsync``, is removed. In general, a running event-loop is not
  available to `asgiref` at import time, and so the default thread pool
  executor cannot be configured. Protocol servers, or applications, should set
  the default executor as required when configuring the event loop at
  application startup.

I don't see anything that could be breaking in 3.7.x and 3.8.x, but PTAL

Note that Fedora's opentelemetry 1.24 has not bumped its asgiref
requirement, so we are probably OK leaving it as is

❯ fedrq pkgs --src -P python-opentelemetry -F requires | grep asgi
python3dist(asgiref)
(python3dist(asgiref) >= 3 with python3dist(asgiref) < 4)

❯ fedrq pkgs --src python-opentelemetry 
python-opentelemetry-1.24.0-3.fc41.src

Best regards,

-- 
 _o) Michel Lind (né Salim)
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

[Michel Lind]

Dear all,

On 4/11/24 16:25, Michel Lind wrote:
>  Dear all,
>  
>  Django 4.2 (the only currently supported LTS series) requires asgiref >=
>  3.6, so I would like to propose updating python-asgiref in EPEL 9 at
>  least to 3.6.0, but ideally to 3.8.1 for future proofing.
>  
>  The affected packages (maintainers bcc:ed) are python-django3 (which I
>  maintain, and has just reached EOL) and python-opentelemetry
>  
>  ❯ fedrq whatrequires 'python3dist(asgiref)' -b epel9
>  python-django3-3.2.20-3.el9.src
>  python-opentelemetry-1.12.0-8.el9.src
>  
>  ❯ fedrq pkgs --src -P python-django3 -F requires -b epel9 | grep asgi
>  python3dist(asgiref) >= 3.3.2
>  (python3dist(asgiref) < 4~~ with python3dist(asgiref) >= 3.3.2)
>  
>  ❯ fedrq pkgs --src -P python-opentelemetry -F requires -b epel9 | grep asgi
>  (python3dist(asgiref) >= 3 with python3dist(asgiref) < 4)
>  
>  
The latest python-django3 and python-opentelemetry epel9 commits have been rebuilt
successfully in COPR against F39's asgiref 3.7.2, all rebuilt for both epel9 and
epel9-next.

https://copr.fedorainfracloud.org/coprs/salimma/asgiref-3.7/packages/

I'll confirm whether we can go ahead with updating this at the EPEL meeting tomorrow,
or we
should wait a full week per
https://tdawson.fedorapeople.org/epel-docs/public/epel/epel-policy-incomp...
since this blocks the packaging of python-django4.2, and Django 3 is already EOL.

(per private discussion with the opentelemetry maintainer, music greenlit the upgrade
provided opentelemetry scratch-rebuilds
fine as is)

Best regards,

-- 
  _o) Michel Lind (né Salim)
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

[Michel Lind]

On 4/16/24 15:56, Michel Lind wrote:
>  I'll confirm whether we can go ahead with updating this at the
> EPEL meeting tomorrow, or we
>  should wait a full week per
> https://tdawson.fedorapeople.org/epel-docs/public/epel/epel-policy-incomp...
>  since this blocks the packaging of python-django4.2, and Django 3 is already EOL.
>  
>  
Google failed me, this is the actual policy
https://docs.fedoraproject.org/en-US/epel/epel-policy-incompatible-upgrades/

-- 
  _o) Michel Lind (né Salim)
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

[Michel Lind]

Hi all,

On 4/11/24 16:25, Michel Lind wrote:
>  Dear all,
>  
>  Django 4.2 (the only currently supported LTS series) requires asgiref >=
>  3.6, so I would like to propose updating python-asgiref in EPEL 9 at
>  least to 3.6.0, but ideally to 3.8.1 for future proofing.
>  
>  The affected packages (maintainers bcc:ed) are python-django3 (which I
>  maintain, and has just reached EOL) and python-opentelemetry
>  
>  ❯ fedrq whatrequires 'python3dist(asgiref)' -b epel9
>  python-django3-3.2.20-3.el9.src
>  python-opentelemetry-1.12.0-8.el9.src
>  
>  ❯ fedrq pkgs --src -P python-django3 -F requires -b epel9 | grep asgi
>  python3dist(asgiref) >= 3.3.2
>  (python3dist(asgiref) < 4~~ with python3dist(asgiref) >= 3.3.2)
>  
>  ❯ fedrq pkgs --src -P python-opentelemetry -F requires -b epel9 | grep asgi
>  (python3dist(asgiref) >= 3 with python3dist(asgiref) < 4)
>  
>  
It's been a week, the maintainers of the specific packages have granted their
approval and the Steering Committee has been consulted.

Since opentelemetry and django3 builds fine with asgiref 3.7.2 from Fedora, I
have now built it and published an update:

https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d56e78a735

Best regards,

-- 
  _o) Michel Lind
_( ) identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2