question about review process excemptions for Python 3

[Felix Schwarz]

Hi,

the packaging guidelines have a few excemptions for the package review process 
[1]. I'm working on updating certbot to Python 3 in EPEL 7 (rhbz 1797129, 
[2]). I need some additional Python 3 packages in EPEL 7 to achieve that and 
my question is which of these packages should get a proper review.


A) python3-augeas
https://bugzilla.redhat.com/show_bug.cgi?id=2043744

This is mostly the Fedora spec with just on additional bugfix (already upstream).


B) python3-josepy
intended spec file: 
https://github.com/FelixSchwarz/certbot-epel7-python3/blob/rawhide/python...

I did not want to upgrade the existing EPEL 7 package as the required version 
is Python 3 only. We can not use some newer macros like %pytest but otherwise 
the spec is the same as in Fedora.


C) python3-boto3
python-boto3 (Python 2) version is in RHEL and won't get a Python3 package.
intended spec file: 
https://github.com/FelixSchwarz/certbot-epel7-python3/blob/rawhide/python...

The spec file is very close to the RHEL spec file just with some 
customizations removed.

Should I try to get reviews for each of the three packages or can I skip some 
of these according to the Fedora review policy?

Felix



[1] 
https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuideline...
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1797129

[Nick Howitt]

On 21/01/2022 22:23, Felix Schwarz wrote:
>  
>  Hi,
>  
>  the packaging guidelines have a few excemptions for the package review 
>  process [1]. I'm working on updating certbot to Python 3 in EPEL 7 (rhbz 
>  1797129, [2]). I need some additional Python 3 packages in EPEL 7 to 
>  achieve that and my question is which of these packages should get a 
>  proper review.
>  
>  
>  A) python3-augeas
>  https://bugzilla.redhat.com/show_bug.cgi?id=2043744
>  
>  This is mostly the Fedora spec with just on additional bugfix (already 
>  upstream).
>  
>  
>  B) python3-josepy
>  intended spec file: 
>
> https://github.com/FelixSchwarz/certbot-epel7-python3/blob/rawhide/python...
>
>  
>  
>  I did not want to upgrade the existing EPEL 7 package as the required 
>  version is Python 3 only. We can not use some newer macros like %pytest 
>  but otherwise the spec is the same as in Fedora.
>  
>  
>  C) python3-boto3
>  python-boto3 (Python 2) version is in RHEL and won't get a Python3 package.
>  intended spec file: 
>
> https://github.com/FelixSchwarz/certbot-epel7-python3/blob/rawhide/python...
>
>  
>  
>  The spec file is very close to the RHEL spec file just with some 
>  customizations removed.
>  
>  Should I try to get reviews for each of the three packages or can I skip 
>  some of these according to the Fedora review policy?
>  
>  Felix
>  
>  
>  
>  [1] 
>
> https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuideline...
>
>  
>  [2] https://bugzilla.redhat.com/show_bug.cgi?id=1797129 
A bit o/t, but will you be updating the python2-certbot-dns-* packages 
as well?

[Felix Schwarz]

Am 23.01.22 um 10:57 schrieb Nick Howitt via epel-devel:
>  A bit o/t, but will you be updating the python2-certbot-dns-*
> packages as well? 
All certbot plugins currently in EPEL 7 will transition to Python 3 as well 
(all packages will be in a single upgrade). So technically the Python 2 
packages will go away but yum will replace it with a Python 3 version of the 
certbot plugin.

- Does that answer your question?
- Is not having a *Python 2* version of a plugin a problem for you?
- Which dns plugin do you care about most? Assuming I can get certbot
   eventually to use Python 3 (this task is haunting me for too many
   months/years now) could you test the upgrade to ensure everything keeps
   working?

Felix

[Nick Howitt]

On 23/01/2022 22:20, Felix Schwarz wrote:
>  Am 23.01.22 um 10:57 schrieb Nick Howitt via epel-devel:
> > A bit o/t, but will you be updating the python2-certbot-dns-* 
> > packages as well?
>
>  All certbot plugins currently in EPEL 7 will transition to Python 3 as 
>  well (all packages will be in a single upgrade). So technically the 
>  Python 2 packages will go away but yum will replace it with a Python 3 
>  version of the certbot plugin.
>
>  - Does that answer your question?
>  - Is not having a *Python 2* version of a plugin a problem for you?
>  - Which dns plugin do you care about most? Assuming I can get certbot
>    eventually to use Python 3 (this task is haunting me for too many
>    months/years now) could you test the upgrade to ensure everything keeps
>    working?
>
>  Felix 
I use python2-certbot-dns-cloudflare, so if certbot were to go to 
python3 then I would need this plugin to go as well, and yes, I can test 
it. Obviously python2-certbot would need to go to 3 at the same time, 
but I assume you have that covered.

Nick

[Manuel Wolfshant]

On 1/24/22 00:20, Felix Schwarz wrote:
>  Am 23.01.22 um 10:57 schrieb Nick Howitt via epel-devel:
> > A bit o/t, but will you be updating the python2-certbot-dns-* 
> > packages as well?
>
>  All certbot plugins currently in EPEL 7 will transition to Python 3 as 
>  well (all packages will be in a single upgrade). So technically the 
>  Python 2 packages will go away but yum will replace it with a Python 3 
>  version of the certbot plugin.
>
>  - Does that answer your question?
>  - Is not having a *Python 2* version of a plugin a problem for you?
>  - Which dns plugin do you care about most? Assuming I can get certbot
>    eventually to use Python 3 (this task is haunting me for too many
>    months/years now) could you test the upgrade to ensure everything keeps
>    working? 
>  

I would certainly test the upgrade but I am not using any dns plugin.