https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Bug ID: 2293727 Summary: Extras subpackages are arched, they should not be Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: python-dask Severity: medium Assignee: quantum.analyst@gmail.com Reporter: awilliam@redhat.com QA Contact: extras-qa@fedoraproject.org CC: epel-packagers-sig@lists.fedoraproject.org, jonathan@almalinux.org, python-packagers-sig@lists.fedoraproject.org, quantum.analyst@gmail.com Target Milestone: --- Classification: Fedora
python-dask.spec has this comment:
# We have an arched package to detect arch-dependent issues in dependencies, # but all of the installable RPMs are noarch and there is no compiled code.
however, it is a lie, because of the use of `%pyproject_extras_subpkg`:
%pyproject_extras_subpkg -n python3-%{srcname} array bag dataframe delayed
that macro does not include BuildArch: noarch when expanded:
[adamw@xps13a python-dask (rawhide %)]$ rpm --eval "%pyproject_extras_subpkg -n python3-foo bar" %package -n python3-foo+bar Summary: Metapackage for python3-foo: bar extras Requires: python3-foo = %{version}-%{release} %description -n python3-foo+bar This is a metapackage bringing in bar extras requires for python3-foo. It makes sure the dependencies are installed.
%files -n python3-foo+bar -f /home/adamw/rpmbuild/BUILD/%{name}-%{version}-%{release}.x86_64-pyproject-ghost-distinfo
so all these subpackages are actually archful, as you can see in a dask build: https://koji.fedoraproject.org/koji/buildinfo?buildID=2477169
assigning to Ben Beasley, as this setup was his idea.
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Adam Williamson awilliam@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|quantum.analyst@gmail.com |code@musicinmybrain.net
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This is a limitation of the Python macros: https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/174
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
--- Comment #2 from Ben Beasley code@musicinmybrain.net --- There are three options:
- make the base package noarch: accept that we are more likely to be surprised by latent arch-specific test failures
- decide we don’t care that the extras metapackages are arched (after all, they are metapackages, so they are tiny), and perhaps adjust the spec-file comment to make it clear that this is a conscious decision: accept that these metapackages are unnecessarily arched
- manually define each of the extras metapackages, similar to the expansion of %pyproject_extras_subpkg…, so that we can make them noarch: accept that this means a lot more boilerplate in the spec file
Elliot, I’m happy to open a PR implementing whichever of these approaches you prefer.
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- (In reply to Ben Beasley from comment #2)
Elliot, I’m happy to open a PR implementing whichever of these approaches you prefer.
Elliott, that is – apologies for the name typo.
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
--- Comment #4 from Ben Beasley code@musicinmybrain.net --- See also: https://bugzilla.redhat.com/show_bug.cgi?id=1686307#c26
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@redhat.com
--- Comment #5 from Miro Hrončok mhroncok@redhat.com ---
manually define each of the extras metapackages, similar to the expansion of %pyproject_extras_subpkg…, so that we can make them noarch: accept that this means a lot more boilerplate in the spec file
I would prefer this option as a temporary solution until https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/174 is merged.
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #6 from Ben Beasley code@musicinmybrain.net --- (In reply to Miro Hrončok from comment #5)
manually define each of the extras metapackages, similar to the expansion of %pyproject_extras_subpkg…, so that we can make them noarch: accept that this means a lot more boilerplate in the spec file
I would prefer this option as a temporary solution until https://src.fedoraproject.org/rpms/python-rpm-macros/pull-request/174 is merged.
https://src.fedoraproject.org/rpms/python-dask/pull-request/11
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e8187782f3 (python-dask-2024.6.2-4.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e8187782f3
https://bugzilla.redhat.com/show_bug.cgi?id=2293727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Fixed In Version| |python-dask-2024.6.2-4.fc41 Last Closed| |2024-06-26 22:26:28
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-e8187782f3 (python-dask-2024.6.2-4.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
epel-packagers-sig@lists.fedoraproject.org