[Bug 2270412] New: missing exception handling in Twisted

https://bugzilla.redhat.com/show_bug.cgi?id=2270412

            Bug ID: 2270412
           Summary: missing exception handling in Twisted
           Product: Fedora
           Version: 38
            Status: NEW
         Component: matrix-synapse
          Severity: medium
          Assignee: V02460(a)gmail.com
          Reporter: customercare(a)resellerdesktop.de
        QA Contact: extras-qa(a)fedoraproject.org
                CC: djc(a)djc.id.au,
                    epel-packagers-sig(a)lists.fedoraproject.org,
                    fedora(a)alex-m.co.uk, jonathan(a)almalinux.org,
                    V02460(a)gmail.com
  Target Milestone: ---
    Classification: Fedora



Version-Release number of selected component (if applicable):

matrix-synapse-1.101.0-1.fc38.x86_64


Description of problem:

3 of those exception happen per day, but we do not have that much user on the
server, so others may have way more.


024-03-19 21:54:29,564 - twisted - 282 - CRITICAL - sentinel - Unhandled Error
Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/twisted/python/log.py", line 96, in
callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/lib/python3.11/site-packages/twisted/python/log.py", line 80, in
callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/lib/python3.11/site-packages/twisted/python/context.py", line 117,
in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib/python3.11/site-packages/twisted/python/context.py", line 82,
in callWithContext
    return func(*args, **kw)
--- <exception caught here> ---
  File "/usr/lib/python3.11/site-packages/twisted/internet/posixbase.py", line
487, in _doReadOrWrite
    why = selectable.doRead()
  File "/usr/lib/python3.11/site-packages/twisted/internet/tcp.py", line 248,
in doRead
    return self._dataReceived(data)
  File "/usr/lib/python3.11/site-packages/twisted/internet/tcp.py", line 253,
in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/usr/lib/python3.11/site-packages/twisted/web/http.py", line 3151, in
dataReceived
    return self._channel.dataReceived(data)
  File "/usr/lib/python3.11/site-packages/twisted/web/http.py", line 2465, in
dataReceived
    return basic.LineReceiver.dataReceived(self, data)
  File "/usr/lib/python3.11/site-packages/twisted/protocols/basic.py", line
549, in dataReceived
    why = self.lineReceived(line)
  File "/usr/lib/python3.11/site-packages/twisted/web/http.py", line 2319, in
lineReceived
    self.allContentReceived()
  File "/usr/lib/python3.11/site-packages/twisted/web/http.py", line 2447, in
allContentReceived
    req.requestReceived(command, path, version)
  File "/usr/lib64/python3.11/site-packages/synapse/http/site.py", line 558, in
requestReceived
    return super().requestReceived(command, path, version)
  File "/usr/lib/python3.11/site-packages/twisted/web/http.py", line 1032, in
requestReceived
    self.process()
  File "/usr/lib/python3.11/site-packages/twisted/web/server.py", line 218, in
process
    self._handleStar()
  File "/usr/lib/python3.11/site-packages/twisted/web/server.py", line 601, in
_handleStar
    self.finish()
  File "/usr/lib64/python3.11/site-packages/synapse/http/site.py", line 353, in
finish
    assert self.logcontext is not None
builtins.AssertionError:


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2270412

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2270412] missing exception handling in Twisted

https://bugzilla.redhat.com/show_bug.cgi?id=2270412

Kai A. Hiller <V02460(a)gmail.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #1 from Kai A. Hiller <V02460(a)gmail.com&gt; ---
If I remember correctly, log contexts are a bit of a pain point for the Synapse
developers. There are a lot of edge cases messing with correctly entering and
leaving those. Looking at the backtrace you provided, I think there sadly isn’t
any information really helping to pin down the root problem.

In case you don’t experience any actual problems with using Synapse, you might
simply choose to ignore those errors; they should just affect logging and not
the actual functioning of Synapse. If you want to help the developers debug and
fix this problem, you can file an issue at
https://github.com/element-hq/synapse/issues/new?template=BUG_REPORT.yml.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2270412

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...

[Bug 2270412] missing exception handling in Twisted

https://bugzilla.redhat.com/show_bug.cgi?id=2270412

Aoife Moloney <amoloney(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|---                         |EOL
        Last Closed|                            |2024-05-31 09:17:48



--- Comment #2 from Aoife Moloney <amoloney(a)redhat.com&gt; ---
Fedora Linux 38 entered end-of-life (EOL) status on 2024-05-21.

Fedora Linux 38 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora
Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2270412

Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...