October 2023 - golang - Fedora Mailing-Lists

[go-rpm-macros] Issue #3: %goprep should apply patches automatically

by Nicolas Mailhot

nim reported a new issue against the project: `go-rpm-macros` that you are following: `` `%goprep` should apply patches automatically, so there is no convenience gap with `%autosetup`. This is generic work that should be done *redhat-rpm-config* side in forge macros and then reused in`%goprep`. Basically: 1. define a `patch_flags<suffix>` rpm variable holding the parameters that should be passed to `%patch<suffix>` 2. define a `default_flags<suffix>` fallback 3. define a `source_patches<suffix>` holding an ordered space separated list of patch suffixes associated with a particular forge/go source. And then write the usual lua loops to apply it all at the right moment in the spec. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/3

4 weeks, 1 day

5
7
0 / 0

[golist] Issue #32: exclude md files from install

by Robert-André Mauchin

eclipseo reported a new issue against the project: `golist` that you are following: `` We shouldn't install md files by default. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/32

1 month

2
1
0 / 0

[golist] PR #33: Exclude .md files by default

by Robert-André Mauchin

eclipseo opened a new pull-request against the project: `golist` that you are following: `` Exclude .md files by default `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/33

1 month, 1 week

1
1
0 / 0

[go-rpm-macros] PR #56: Fix goname generation to match versioning guildelines

by Robert-André Mauchin

eclipseo opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Fix goname generation to match versioning guildelines `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/56

1 month, 1 week

2
16
0 / 0

[Fedocal] Reminder meeting : Go SIG

by jcajka＠fedoraproject.org

Dear all, You are kindly invited to the meeting: Go SIG on 2023-10-23 from 20:00:00 to 21:00:00 Europe/Prague At fedora-golang(a)libera.chat The meeting will be about: Fedora's Go SIG meeting More information available at: [https://pagure.io/GoSIG/go-sig/](https://pagure.io/GoSIG/go-sig/) Source: https://calendar.fedoraproject.org//meeting/10012/

1 month, 2 weeks

1
0
0 / 0

Re: Strange(?) build failures for golang package

by Jakub Čajka

_build/src/github.com/go-task/task/internal/orderedmap/orderedmap.go:94:24 <http://github.com/go-task/task/internal/orderedmap/orderedmap.go:94:24>: type func(i K, j K) bool of less does not match inferred type func(a K, b K) int for func(a E, b E) int is the error. Jakub Čajka Oct 11, 2023, 14:02 by fuller(a)fedoraproject.org: > I am trying to update go-task for some time now and consistently getting a build error/failure with no clear indication of what's happened: > https://download.copr.fedorainfracloud.org/results/fuller/test-builds/fed... > > Is it possible that there are build flags are default settings in the golang macros that might be leading to this? > > Thanks, > fuller > _______________________________________________ > devel mailing list -- devel(a)lists.fedoraproject.org > To unsubscribe send an email to devel-leave(a)lists.fedoraproject.org > Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue >

1 month, 3 weeks

1
0
0 / 0

Strange(?) build failures for golang package

by Mark E. Fuller

I am trying to update go-task for some time now and consistently getting a build error/failure with no clear indication of what's happened: https://download.copr.fedorainfracloud.org/results/fuller/test-builds/fed... Is it possible that there are build flags are default settings in the golang macros that might be leading to this? Thanks, fuller

1 month, 3 weeks

1
0
0 / 0

[Fedocal] Reminder meeting : Go SIG

by jcajka＠fedoraproject.org

Dear all, You are kindly invited to the meeting: Go SIG on 2023-10-09 from 20:00:00 to 21:00:00 Europe/Prague At fedora-golang(a)libera.chat The meeting will be about: Fedora's Go SIG meeting More information available at: [https://pagure.io/GoSIG/go-sig/](https://pagure.io/GoSIG/go-sig/) Source: https://calendar.fedoraproject.org//meeting/10012/

1 month, 4 weeks

1
0
0 / 0

Important: Package naming issues wrt Packaging Guidelines: an update / Please vote for the solution or propose an alternative

by Robert-André Mauchin

Hello folks, So, following the ticket to the packaging-commitee: https://pagure.io/packaging-committee/issue/1307 The summary of the meeting is the following: > We discussed this during today's meeting, and there was consensus for two things: > > we don't like that package Name is controlled by a macro where its implementation can change and could lead to situations where source package name != dist-git package name > we don't like the situation we have ended up with wrt/ the Go package naming, since the guidelines around compat packages have been around when the diverging scheme for Go packages was devised, and don't want this to set a precedent for "ignore the guidelines for long enough and it will become accepted practice" > > Our suggestions are: > > If the package names would continue to use a hyphen as separator for the version specifier ("-vN"), we would like the package suffix to be "-vN" as well. > If you would like the current Go naming practices to remain in place, we would consider documenting the exception for using a hyphen as a separator for this purpose. > > For the first option, I think no changes to the Naming Guidelines would be needed. For the second option, an exception would need to be documented in either the Naming Guidelines, or in the Go Packaging Guidelines directly. > > (if I am mis-characterizing something in this summary, please correct me). Maxwell said: >> If you would like the current Go naming practices to remain in place, we would consider documenting the exception for using a hyphen as a separator for this purpose. > > I think that's the best way forward. Carl said: >> Right, this is one of the reasons I'm hesitant to make that change at this point. We could always add a flag to enable the "new" scheme, but I'm not sure that's worthwhile. > > Rather than changing the macro implementation, we can just change the guidelines to say maintainers SHOULD NOT use %{goname}. This is already the case for "well-known application" like containerd, etcd, hugo, and more. Libraries would switch from using %{goname} to an explicit name that follows the package naming guidelines. That wouldn't make the process of requesting a new dist-git repo any easier, but it would make the spec file changes trivial. At some point after all usage of %{goname} is absent from rawhide spec files, the macro could be changed to trigger an error if it's used. > > I would prefer we pick the option that makes the most technical sense, rather than the one that has the most inertia. I'd be open to a "going forward" policy, letting non-compliant package names age out over time (or get converted gradually as people get to them). What I propose: - New packages should adopt the correct guidelines, no hyphen before version. - Older packages should be kept as is for compatibility, i.e. an exception based on existing import path. - In go2rpm we do not use the %goname macro but hardcode the result of it, so if goname change, the Name: field doesn't. - Change the Go packaging guidelines to remove reference to %goname - Progressively replace Name: %{goname} by the hardcoded value while the package are updated. As such: - in go-rpm-macro, I make a list of 130-ish goipath exception list. If it is not in the list, the goname is computed according to official guidelines. - in go2rpm, same thing, and instead of putting %goname in Name: field, we put the computed value. Here are the merge requests: - go-rpm-macros: https://pagure.io/go-rpm-macros/pull-request/56 - go2rpm: https://pagure.io/GoSIG/go2rpm/pull-request/31 Testing is done here: https://copr.fedorainfracloud.org/coprs/eclipseo/macros-fix3/builds/ /!\ I'd like your opinion as soon as possible so we can unstuck packages in fedora-scm-requests /!\ I do not want to wait for the next meeting in a week. Please vote, propose other solutions here or in the Pagure SIG ticket: https://pagure.io/GoSIG/go-sig/issue/53#comment-877603 Best regards, Robert-André

1 month, 4 weeks

1
0
0 / 0

[go-rpm-macros] PR #55: Fix goname generation to match versioning guildelines

by Robert-André Mauchin

eclipseo opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Fix goname generation to match versioning guildelines `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/55

1 month, 4 weeks

4
10
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

golang October 2023