proletarius101 reported a new issue against the project: `go-rpm-macros` that you are following: `` Although go-rpm-macros haven't support Go modules, which bascially means no lockfile & always use the latest deps available in Fedora's repo, it might be good to provide some macro to (imperfectly) handle some easy problems introduced by Go modules.
One of them is that when a module uses `replace` keyword to substitute module with another goipath (e.g. `replace golang.org/x/crypto => github.com/ProtonMail/crypto` in https://github.com/emersion/hydroxide/blob/master/go.mod). My proposal is to replace the `golang.org/x/crypto` with its real path `github.com/ProtonMail/crypto`. But any other ideas will be welcomed. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27
nim added a new comment to an issue you are following: `` replace can not work in Fedora anyway because it is not transitive (it’s the kind of broken by design idea people invent when their primary target is to bundle piles of junk and avoid fixing their code).
source code that uses replace needs patching to use the real module/import name with or without modules. We have %patch and (soonish) patchlists for that, not sure a macro would be a lot more convenient, and it would certainly be more brittle. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27
proletarius101 added a new comment to an issue you are following: `` Agreed that it looks messy. But in this case `replace` just means redirection and some name overlapping. Or maybe there should be some notes in Fedora's packaging guidelines to instruct the best practice to handle this? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27
nim added a new comment to an issue you are following: `` rpm dependencies are transitive. That means replace can not be supported in rpm. That means the only sane way to handle replace is to remove it by patching code imports (which is not long or hard)
As to why non-transitive deps and 'to hell will everyone else, I only care about by own leaf node' approaches are a false good idea see the discussion on modules in devel right now. You win a little short term, you lose a lot long term as soon as the deferred technical debts catches up with you (as it caught up with the java module experiment). ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27
proletarius101 added a new comment to an issue you are following: `` Yeah. Not trying to really support `replace` but was asking how to deal with such case is acceptable and right for Fedora. Now I know that just to replace the goipath to its real one by patches. Thanks for answering! ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27
The status of the issue: `Add macro for packages with `replace` in go.mod` of project: `go-rpm-macros` has been updated to: Closed by proletarius101.
golang@lists.fedoraproject.org
-
Nicolas Mailhot -
Simpson