branch master updated: Permit testing sans Valgrind
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
rharwood pushed a commit to branch master
in repository gssproxy.
The following commit(s) were added to refs/heads/master by this push:
new f91e23f Permit testing sans Valgrind
f91e23f is described below
commit f91e23f896ec3cb0afe60485fc7ab72b63011281
Author: Alexander Scheel <ascheel(a)redhat.com>
AuthorDate: Mon Mar 18 17:26:00 2019 -0400
Permit testing sans Valgrind
Only run the check_exec on Valgrind when present as the prefix to the
--valgrind-cmd argument. This lets us run the test suite without
Valgrind via:
./tests/runtests.py --valgrind-cmd ""
Signed-off-by: Alexander Scheel <ascheel(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Merges: #243
---
tests/runtests.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/runtests.py b/tests/runtests.py
index 4150543..9cd546f 100755
--- a/tests/runtests.py
+++ b/tests/runtests.py
@@ -52,6 +52,9 @@ def runtests_main(testfiles):
for e in ["bash", "pkg-config", "zcat", "kinit", "krb5kdc", "kdb5_util",
"kadmin.local", "kdb5_ldap_util", "slapd", "slapadd",
"ldapmodify", "valgrind"]:
+ if e == "valgrind" and not args['valgrind_cmd'].startswith('valgrind'):
+ continue
+
check_exec(e)
testdir = args['path']
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 8 months
branch master updated: Reorder functions
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
rharwood pushed a commit to branch master
in repository gssproxy.
The following commit(s) were added to refs/heads/master by this push:
new 6accc0a Reorder functions
6accc0a is described below
commit 6accc0afead574e11447447c949f2abcb1a34826
Author: Simo Sorce <simo(a)redhat.com>
AuthorDate: Wed Mar 6 15:06:14 2019 -0500
Reorder functions
Keep related functions closer together like before
Signed-off-by: Simo Sorce <simo(a)redhat.com>
Reviewed-by: Robbie Harwood <rharwood(a)redhat.com>
Resolves: #242
---
src/client/gpm_common.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/client/gpm_common.c b/src/client/gpm_common.c
index 95a39ab..808f350 100644
--- a/src/client/gpm_common.c
+++ b/src/client/gpm_common.c
@@ -140,16 +140,6 @@ static void gpm_close_socket(struct gpm_ctx *gpmctx)
gpmctx->fd = -1;
}
-static void gpm_epoll_close(struct gpm_ctx *gpmctx)
-{
- if (gpmctx->epollfd < 0) {
- return;
- }
-
- close(gpmctx->epollfd);
- gpmctx->epollfd = -1;
-}
-
static void gpm_timer_close(struct gpm_ctx *gpmctx)
{
if (gpmctx->timerfd < 0) {
@@ -160,13 +150,6 @@ static void gpm_timer_close(struct gpm_ctx *gpmctx)
gpmctx->timerfd = -1;
}
-static int gpm_release_sock(struct gpm_ctx *gpmctx)
-{
- gpm_epoll_close(gpmctx);
- gpm_timer_close(gpmctx);
- return pthread_mutex_unlock(&gpmctx->lock);
-}
-
static int gpm_timer_setup(struct gpm_ctx *gpmctx, int timeout_seconds)
{
int ret;
@@ -197,6 +180,16 @@ static int gpm_timer_setup(struct gpm_ctx *gpmctx, int timeout_seconds)
return 0;
}
+static void gpm_epoll_close(struct gpm_ctx *gpmctx)
+{
+ if (gpmctx->epollfd < 0) {
+ return;
+ }
+
+ close(gpmctx->epollfd);
+ gpmctx->epollfd = -1;
+}
+
static int gpm_epoll_setup(struct gpm_ctx *gpmctx)
{
struct epoll_event ev;
@@ -224,6 +217,13 @@ static int gpm_epoll_setup(struct gpm_ctx *gpmctx)
return ret;
}
+static int gpm_release_sock(struct gpm_ctx *gpmctx)
+{
+ gpm_epoll_close(gpmctx);
+ gpm_timer_close(gpmctx);
+ return pthread_mutex_unlock(&gpmctx->lock);
+}
+
static int gpm_grab_sock(struct gpm_ctx *gpmctx)
{
int ret;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 9 months
branch master updated (9e38cd5 -> d55be9f)
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
rharwood pushed a change to branch master
in repository gssproxy.
from 9e38cd5 Move run_as_user check out of drop_privs()
new 0ccfd32 Close epoll fd within the lock
new d55be9f Add a safety timeout to epoll
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/client/gpm_common.c | 111 +++++++++++++++++++++++++-----------------------
1 file changed, 58 insertions(+), 53 deletions(-)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 9 months