[Fedora-i18n-bugs] [Bug 626666] Review Request: groonga - An Embeddable Fulltext Search Engine
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=626666
--- Comment #2 from Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> 2010-10-01 14:54:28 EDT ---
Some notes (checked 1.0.2-2)
* BR
- Looking into bindings/ directory, it seems that some languages bindings
are available for this package (python, php, and also perhaps ruby?).
Would you try to enable these bindings?
* License
-------------------------------------------------------------------
doc/ja/README says LGPLv2
BSD
doc/ja/html/_static/
MIT or GPLv2
doc/ja/html/_static/jquery.js
resource/admin_html/css/ui-lightness/jquery-ui-1.8.1.custom.css
resource/admin_html/js/jquery-1.4.2.min.js
------------------------------------------------------------------
- So -libs license should be "LGPLv2 and (MIT or GPLv2)" and -doc license
should be "LGPLv2 and BSD".
* Timestamps
- Please consider to use
-------------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL~="install -p"
-------------------------------------------------------------------
to keep timestamps on installed files as much as possible.
This method usually works for Makefiles generated by recent autotool
scripts.
* Macros
- Please use macros for standard directories. /var should be %_var or
%_localstatedir, /usr/sbin should be %_sbin, and etc
https://fedoraproject.org/wiki/Packaging/RPMMacros
* SysV script related issues
- Please use %{_initddir} (/etc/rc.d/init.d) instead of %_sysconfdir/init.d
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_th...
- For registering groonga user or group, please follow
https://fedoraproject.org/wiki/Packaging/UsersAndGroups
! Note
The current way of yours is anyway confusing because doing
'echo "Unexpected error adding group \"groonga\". Aborting
installation."'
does not actually abort installation (because $ echo foo will perhaps
exit
with status 0).
-------------------------------------------------------------------
/usr/sbin/useradd -r -s /sbin/nologin -c 'groonga' \
-d %{_localstatedir}/lib/groonga --create-home \
-------------------------------------------------------------------
- $ env LANG=C man useradd says "--create-home" will copy files in skeleton
directory into the created home directory. Is it needed?
- And anyway %_localstatedir/lib/groonga must also be listed in %files
entry, so I don't think --create-home option is needed here.
- The lines
-------------------------------------------------------------------
%post
/bin/mkdir -p /var/run/groonga
/bin/chown -R groonga:groonga /var/run/groonga
-------------------------------------------------------------------
is wrong. In this case, the directory %_localstatedir/run/%name must be
registered in %files entry with proper %attr added.
-------------------------------------------------------------------
%post munin-plugins
/usr/sbin/munin-node-configure --shell --remove-also | grep -e 'groonga_' | sh
[ -f /var/lock/subsys/munin-node ] && \
/sbin/service munin-node restart > /dev/null 2>&1
-------------------------------------------------------------------
- Some Requires(post) is required here (Requires(post): munin-node)
- Doesn't munin-node service support condrestart?
- We don't usually call userdel / groupdel on scriptlets:
https://fedoraproject.org/wiki/Packaging/UsersAndGroups
- Would you explain why this is needed?
--------------------------------------------------------------------
%postun munin-plugins
if [ $1 -eq 0 ]; then
rm %{_sysconfdir}/munin/plugins/groongar_* > /dev/null 2>&1
--------------------------------------------------------------------
- By the way calling /sbin/service or /sbin/chkconfig or getent or
so requires writing Proper "Requires(foo): bar"s. Please
refer to:
https://fedoraproject.org/wiki/Packaging/UsersAndGroups
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_in_sp...
* %files
- We now prefer to use %defattr(-,root,root,-)
- Files under %_mandir (note: please use %_mandir instead of %_datadir/man)
are
automatically marked as %doc, so there is no need to write explicit %doc
attribute
for %_mandir/foo.
- Please take care of directory ownership issue.
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ow...
https://fedoraproject.org/wiki/Packaging/UnownedDirectories
! The point is that when installing a (binary) rpm creates some new
directories,
the created directories should also be owned by the (just installed) rpm.
For example, when installing groonga-libs rpm, installing
%_libdir/groonga/modules/suggest/suggest.so (on i686)
newly creates the following directories:
--------------------------------------------------------------
%_libdir/%name
%_libdir/%name/modules
%_libdir/%name/modules/suggest
--------------------------------------------------------------
so -libs subpackage should also own these directories. Also please refer
to
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
! Instead if the needed directories for a rpm are already created by the
packages
which the rpm depends on, the rpm (to be newly installed) should not own
the
directory.
For example the directory %_sysconfdir/munin/plugin-conf.d is already
owned by
munin-node, so -munin-plugins subpackage should not own this directory
itself.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 7 months
[Fedora-i18n-bugs] [Bug 582988] New: [Indic] Dependent Vowels are joined with other Dependent Vowels without any dotted circle
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: [Indic] Dependent Vowels are joined with other Dependent Vowels without any dotted circle
https://bugzilla.redhat.com/show_bug.cgi?id=582988
Summary: [Indic] Dependent Vowels are joined with other
Dependent Vowels without any dotted circle
Product: Fedora
Version: 13
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: qt
AssignedTo: than(a)redhat.com
ReportedBy: aalam(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: rdieter(a)math.unl.edu, than(a)redhat.com,
kevin(a)tigcc.ticalc.org, itamar(a)ispbrasil.com.br,
ltinkl(a)redhat.com, jreznik(a)redhat.com,
i18n-bugs(a)lists.fedoraproject.org, smparrish(a)gmail.com
Classification: Fedora
Target Release: ---
Created an attachment (id=407064)
--> (https://bugzilla.redhat.com/attachment.cgi?id=407064)
Screenshot with gedit (pango), openoffice.org (icu), and kwrite (qt)
Description of problem:
Dependent Vowels are joined with other Dependent Vowels without any dotted
circle for Indic Languages. This is very odd as it was previously working with
qt, but not with GNOME, icu
Version-Release number of selected component (if applicable):
pango-1.28.0-1.fc13.x86_64
qt-4.6.2-13.fc13.x86_64
libicu-4.2.1-8.fc13.x86_6
How reproducible:
100%
Steps to Reproduce:
1. Type following unicode in Text Editor(Copy Paste can also work)
2. 0915+0947+0947+0947 (क + े + े + े = केेे)
3.
Actual results:
Showing only One Character with One Vowel (Seems only)
Expected results:
It should should two dotted circle. Check Screenshot with Gedit/Openoffice
Additional info:
Going to upstream with qt
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 7 months
[Fedora-i18n-bugs] [Bug 586292] New: pinyin keep crash when CPU load high.
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: pinyin keep crash when CPU load high.
https://bugzilla.redhat.com/show_bug.cgi?id=586292
Summary: pinyin keep crash when CPU load high.
Product: Red Hat Enterprise Linux 6
Version: 6.0
Platform: i686
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: ibus-pinyin
AssignedTo: phuang(a)redhat.com
ReportedBy: phuang(a)redhat.com
QAContact: desktop-bugs(a)redhat.com
CC: eng-i18n-bugs(a)redhat.com, phuang(a)redhat.com,
i18n-bugs(a)lists.fedoraproject.org, biaji.cn(a)gmail.com
Depends on: 552445
Group: rhel_beta
Classification: Red Hat
Target Release: ---
Clone Of: 552445
+++ This bug was initially created as a clone of Bug #552445 +++
Description of problem:
Can't use pinyin input method when in high cpu load condition. Pinyin keep
crashing. You have to restart from applet and after a while , it crashed again.
Version-Release number of selected component (if applicable):
ibus-libs-1.2.0.20091204-2.fc12.i686
ibus-gtk-1.2.0.20091204-2.fc12.i686
ibus-pinyin-1.2.0.20090915-1.fc12.noarch
ibus-1.2.0.20091204-2.fc12.i686
How reproducible:
Do some CPU consuming work, and input characters using ibus-pinyin.
Steps to Reproduce:
1. Do some CPU consuming work
2. input something using ibus-pinyin
3. BOOM!!!
Actual results:
it crash again and again. input panel disappear and can't using ctrl-space
shortcut to call out pinyin input method again.
Expected results:
nothing special happened
Additional info:
After crash, the daemon complained:
(ibus-daemon:29976): IBUS-WARNING **: org.freedesktop.DBus.Error.NoReply: Did
not receive a reply. Possible causes include: the remote application did not
send a reply, the message bus security policy blocked the reply, the reply
timeout expired, or the network connection was broken.
--- Additional comment from phuang(a)redhat.com on 2010-01-20 03:45:54 EST ---
Please try new ibus.
http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0385
--- Additional comment from phuang(a)redhat.com on 2010-04-07 22:41:06 EDT ---
Fixed in ibus-pinyin-1.3.1-1.fc12
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 7 months