[Fedora-i18n-bugs] [Bug 705348] Lohit fonts accidentally disable the bytecode interpreter for Qt
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705348
--- Comment #21 from Behdad Esfahbod <behdad(a)fedoraproject.org> 2011-06-06 12:18:24 EDT ---
The way Pango is using fontconfig is completely correct and the way fontconfig
is designed to be used. In short, this is how to use fontconfig:
- Create a pattern specifying the characteristics you are looking for (ie.
"sans bold 18"). Call this pat.
- Call FcConfigSubstitute (NULL, pat, FcMatchPattern). That's where
target="pattern" configuration is applied.
- Call FcDefaultSubstitute (pat)
- Then either: {
- Call FcFontSort (NULL, pat, ...). This will return a fontset, lets call
it fs.
- For any item in fs that you want to use (call that 'font'), you should:
- Call FcRenderPrepare (NULL, pat, font). This will implicitly call
FcConfigSubstituteWithPat (NULL, res, pat, FcMatchFont) on the pattern that it
returns. That's where target="font" configuration is applied.
- Use the resulting pattern to open the font and render it.
} or {
- Call FcFontMatch (NULL, pat, &result). This will return what we call a
"font" pattern. It already has FcFontRenderPrepare (NULL, pat, font) called on
it by FcFontMatch.
}
Now! The way Qt is abusing fontconfig is:
- qt_fontSetForPattern calls FcFontSort (NULL, pat, ...) and gets the
resulting fontset 'fs' and saves it.
*** Note that it should have called FcConfigSubstitute (pattern,
FcMatchPattern) and FcDefaultSubstitute (pattern) first, but it didn't.
- In QFontEngineMultiFT::loadEngine(), it gets font patterns out of fs, and
calls it pattern. Note that this is a target="font" kind of pattern.
- Then it calls:
FcConfigSubstitute(0, pattern, FcMatchPattern);
FcDefaultSubstitute(pattern);
*** This is completely wrong, since pattern is a font pattern, not a query
pattern!
So, that's it. It's completely b0rked. Those two calls should be made before
FcFontSort(), and FcRenderPrepare called in place of those two.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years
[Fedora-i18n-bugs] [lohit-kannada-fonts/f15] Resolved bug 705348
by Pravin Satpute
commit 2538f1fc45402d2e84c451f28cf3a35beda3c895
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 19:39:04 2011 +0530
Resolved bug 705348
bug-705348.patch | 12 ++++++++++++
lohit-kannada-fonts.spec | 7 ++++++-
2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/bug-705348.patch b/bug-705348.patch
new file mode 100644
index 0000000..40d5ce4
--- /dev/null
+++ b/bug-705348.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-kannada-2.4.6/66-lohit-kannada.conf lohit-kannada-2.4.6_mod/66-lohit-kannada.conf
+--- lohit-kannada-2.4.6/66-lohit-kannada.conf 2011-05-12 16:52:55.000000000 +0530
++++ lohit-kannada-2.4.6_mod/66-lohit-kannada.conf 2011-06-06 19:32:24.147525664 +0530
+@@ -13,7 +13,7 @@
+ </edit>
+ </match>
+ <match target="font">
+- <test name="family" compare="eq">
++ <test qual="first" name="family" compare="eq">
+ <string>Lohit Kannada</string>
+ </test>
+ <edit name="autohint" mode="assign">
diff --git a/lohit-kannada-fonts.spec b/lohit-kannada-fonts.spec
index 218f568..5e33360 100644
--- a/lohit-kannada-fonts.spec
+++ b/lohit-kannada-fonts.spec
@@ -3,7 +3,7 @@
Name: %{fontname}-fonts
Version: 2.4.6
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Free Kannada font
Group: User Interface/X
@@ -15,6 +15,7 @@ BuildArch: noarch
BuildRequires: fontforge >= 20080429
BuildRequires: fontpackages-devel
Requires: fontpackages-filesystem
+Patch1: bug-705348.patch
Obsoletes: lohit-fonts-common < %{version}-%{release}
%description
@@ -23,6 +24,7 @@ This package provides a free Kannada truetype/opentype font.
%prep
%setup -q -n %{fontname}-%{version}
+%patch1 -p1 -b .1-conf-fix-for-qt
%build
make
@@ -52,6 +54,9 @@ rm -fr %{buildroot}
%changelog
+* Mon Jun 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.6-2
+- Resolved bug 705348
+
* Fri May 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.6-1
- upstream new release 2.4.6
13 years
[Fedora-i18n-bugs] [lohit-kannada-fonts] Resolved bug 705348
by Pravin Satpute
commit ba5b0337a70e81fd57eaf87e57cd5712801ab7a9
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 19:36:04 2011 +0530
Resolved bug 705348
bug-705348.patch | 12 ++++++++++++
lohit-kannada-fonts.spec | 7 ++++++-
2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/bug-705348.patch b/bug-705348.patch
new file mode 100644
index 0000000..40d5ce4
--- /dev/null
+++ b/bug-705348.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-kannada-2.4.6/66-lohit-kannada.conf lohit-kannada-2.4.6_mod/66-lohit-kannada.conf
+--- lohit-kannada-2.4.6/66-lohit-kannada.conf 2011-05-12 16:52:55.000000000 +0530
++++ lohit-kannada-2.4.6_mod/66-lohit-kannada.conf 2011-06-06 19:32:24.147525664 +0530
+@@ -13,7 +13,7 @@
+ </edit>
+ </match>
+ <match target="font">
+- <test name="family" compare="eq">
++ <test qual="first" name="family" compare="eq">
+ <string>Lohit Kannada</string>
+ </test>
+ <edit name="autohint" mode="assign">
diff --git a/lohit-kannada-fonts.spec b/lohit-kannada-fonts.spec
index e37c5e3..1e040bb 100644
--- a/lohit-kannada-fonts.spec
+++ b/lohit-kannada-fonts.spec
@@ -3,7 +3,7 @@
Name: %{fontname}-fonts
Version: 2.4.6
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Free Kannada font
Group: User Interface/X
@@ -15,6 +15,7 @@ BuildArch: noarch
BuildRequires: fontforge >= 20080429
BuildRequires: fontpackages-devel
Requires: fontpackages-filesystem
+Patch1: bug-705348.patch
Obsoletes: lohit-fonts-common < %{version}-%{release}
%description
@@ -23,6 +24,7 @@ This package provides a free Kannada truetype/opentype font.
%prep
%setup -q -n %{fontname}-%{version}
+%patch1 -p1 -b .1-conf-fix-for-qt
%build
make
@@ -52,6 +54,9 @@ rm -fr %{buildroot}
%changelog
+* Mon Jun 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.6-2
+- Resolved bug 705348
+
* Thu May 12 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.6-1
- upstream new release 2.4.6
13 years
[Fedora-i18n-bugs] [lohit-bengali-fonts/f15] Resolved bug 705348
by Pravin Satpute
commit ceae649318151cf7dd67c389b02e6f2c935a6711
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 17:54:06 2011 +0530
Resolved bug 705348
bug-705348.patch | 12 ++++++++++++
lohit-bengali-fonts.spec | 7 ++++++-
2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/bug-705348.patch b/bug-705348.patch
new file mode 100644
index 0000000..9e376bc
--- /dev/null
+++ b/bug-705348.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-bengali-2.4.3/66-lohit-bengali.conf lohit-bengali-2.4.3_mod/66-lohit-bengali.conf
+--- lohit-bengali-2.4.3/66-lohit-bengali.conf 2011-06-06 17:13:50.372909293 +0530
++++ lohit-bengali-2.4.3_mod/66-lohit-bengali.conf 2011-06-06 17:13:14.382053238 +0530
+@@ -13,7 +13,7 @@
+ </edit>
+ </match>
+ <match target="font">
+- <test name="family" compare="eq">
++ <test qual="first" name="family" compare="eq">
+ <string>Lohit Bengali</string>
+ </test>
+ <edit name="autohint" mode="assign">
diff --git a/lohit-bengali-fonts.spec b/lohit-bengali-fonts.spec
index a5267ac..6d01b79 100644
--- a/lohit-bengali-fonts.spec
+++ b/lohit-bengali-fonts.spec
@@ -3,7 +3,7 @@
Name: %{fontname}-fonts
Version: 2.4.3
-Release: 7%{?dist}
+Release: 8%{?dist}
Summary: Free Bengali font
Group: User Interface/X
@@ -18,6 +18,7 @@ Requires: fontpackages-filesystem
Patch1: bug-549319-578030.patch
Patch2: bug-673412.patch
Patch3: bug-692360.patch
+Patch4: bug-705348.patch
Obsoletes: lohit-fonts-common < %{version}-%{release}
%description
@@ -29,6 +30,7 @@ This package provides a free Bengali truetype/opentype font.
%patch1 -p1 -b .1-fix-font-conf
%patch2 -p1 -b .2-rupee-sign
%patch3 -p1 -b .3-auto-hint-conf
+%patch4 -p1 -b .4-fix-for-qt
%build
./generate.pe *.sfd
@@ -58,6 +60,9 @@ rm -fr %{buildroot}
%changelog
+* Mon Jun 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-8
+- fixed bug 705348
+
* Wed Apr 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-7
- fixed bug 692360
13 years
[Fedora-i18n-bugs] [lohit-bengali-fonts] updated date in changelog
by Pravin Satpute
commit aba52c9cb7ddaef3f206ce49787ad53267a76372
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 17:20:03 2011 +0530
updated date in changelog
lohit-bengali-fonts.spec | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/lohit-bengali-fonts.spec b/lohit-bengali-fonts.spec
index e3f6081..6d01b79 100644
--- a/lohit-bengali-fonts.spec
+++ b/lohit-bengali-fonts.spec
@@ -60,7 +60,7 @@ rm -fr %{buildroot}
%changelog
-* Mon June 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-8
+* Mon Jun 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-8
- fixed bug 705348
* Wed Apr 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-7
13 years
[Fedora-i18n-bugs] [lohit-bengali-fonts] Resolved bug 705348
by Pravin Satpute
commit 33121fcc7145104a5525a6ab31352e5ba1d6d5d4
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 17:17:56 2011 +0530
Resolved bug 705348
bug-705348.patch | 12 ++++++++++++
lohit-bengali-fonts.spec | 7 ++++++-
2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/bug-705348.patch b/bug-705348.patch
new file mode 100644
index 0000000..9e376bc
--- /dev/null
+++ b/bug-705348.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-bengali-2.4.3/66-lohit-bengali.conf lohit-bengali-2.4.3_mod/66-lohit-bengali.conf
+--- lohit-bengali-2.4.3/66-lohit-bengali.conf 2011-06-06 17:13:50.372909293 +0530
++++ lohit-bengali-2.4.3_mod/66-lohit-bengali.conf 2011-06-06 17:13:14.382053238 +0530
+@@ -13,7 +13,7 @@
+ </edit>
+ </match>
+ <match target="font">
+- <test name="family" compare="eq">
++ <test qual="first" name="family" compare="eq">
+ <string>Lohit Bengali</string>
+ </test>
+ <edit name="autohint" mode="assign">
diff --git a/lohit-bengali-fonts.spec b/lohit-bengali-fonts.spec
index a5267ac..e3f6081 100644
--- a/lohit-bengali-fonts.spec
+++ b/lohit-bengali-fonts.spec
@@ -3,7 +3,7 @@
Name: %{fontname}-fonts
Version: 2.4.3
-Release: 7%{?dist}
+Release: 8%{?dist}
Summary: Free Bengali font
Group: User Interface/X
@@ -18,6 +18,7 @@ Requires: fontpackages-filesystem
Patch1: bug-549319-578030.patch
Patch2: bug-673412.patch
Patch3: bug-692360.patch
+Patch4: bug-705348.patch
Obsoletes: lohit-fonts-common < %{version}-%{release}
%description
@@ -29,6 +30,7 @@ This package provides a free Bengali truetype/opentype font.
%patch1 -p1 -b .1-fix-font-conf
%patch2 -p1 -b .2-rupee-sign
%patch3 -p1 -b .3-auto-hint-conf
+%patch4 -p1 -b .4-fix-for-qt
%build
./generate.pe *.sfd
@@ -58,6 +60,9 @@ rm -fr %{buildroot}
%changelog
+* Mon June 06 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-8
+- fixed bug 705348
+
* Wed Apr 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-7
- fixed bug 692360
13 years
[Fedora-i18n-bugs] [lohit-assamese-fonts/f15] Resolved bug 705348
by Pravin Satpute
commit c3740eff12aefd1408b2c31c3c0980f94d9e9aef
Author: प्रविण सातपुते <psatpute(a)redhat.com>
Date: Mon Jun 6 16:42:41 2011 +0530
Resolved bug 705348
bug-705348.patch | 12 ++++++++++++
fsf-add.patch | 12 ++++++++++++
lohit-assamese-fonts.spec | 10 +++++++++-
3 files changed, 33 insertions(+), 1 deletions(-)
---
diff --git a/bug-705348.patch b/bug-705348.patch
new file mode 100644
index 0000000..eed3ee9
--- /dev/null
+++ b/bug-705348.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-assamese-2.4.3/66-lohit-assamese.conf lohit-assamese-2.4.3_mod/66-lohit-assamese.conf
+--- lohit-assamese-2.4.3/66-lohit-assamese.conf 2011-06-06 15:59:39.488902947 +0530
++++ lohit-assamese-2.4.3_mod/66-lohit-assamese.conf 2011-06-06 15:57:45.290519782 +0530
+@@ -13,7 +13,7 @@
+ </edit>
+ </match>
+ <match target="font">
+- <test name="family" compare="eq">
++ <test qual="first" name="family" compare="eq">
+ <string>Lohit Assamese</string>
+ </test>
+ <edit name="autohint" mode="assign">
diff --git a/fsf-add.patch b/fsf-add.patch
new file mode 100644
index 0000000..0971ddf
--- /dev/null
+++ b/fsf-add.patch
@@ -0,0 +1,12 @@
+diff -rup lohit-assamese-2.4.3/COPYING lohit-assamese-2.4.3_mod/COPYING
+--- lohit-assamese-2.4.3/COPYING 2009-09-09 15:18:33.000000000 +0530
++++ lohit-assamese-2.4.3_mod/COPYING 2011-06-06 16:33:00.495749382 +0530
+@@ -2,7 +2,7 @@
+ Version 2, June 1991
+
+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.
+- 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
++ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ Everyone is permitted to copy and distribute verbatim copies
+ of this license document, but changing it is not allowed.
+
diff --git a/lohit-assamese-fonts.spec b/lohit-assamese-fonts.spec
index c9628e9..ca0a0cb 100644
--- a/lohit-assamese-fonts.spec
+++ b/lohit-assamese-fonts.spec
@@ -3,7 +3,7 @@
Name: %{fontname}-fonts
Version: 2.4.3
-Release: 8%{?dist}
+Release: 9%{?dist}
Summary: Free Assamese font
Group: User Interface/X
@@ -18,6 +18,8 @@ Requires: fontpackages-filesystem
Patch1: bug-549319-578029-586308.patch
Patch2: bug-673411.patch
Patch3: bug-692359.patch
+Patch4: bug-705348.patch
+Patch5: fsf-add.patch
Obsoletes: lohit-fonts-common < %{version}-%{release}
%description
@@ -29,6 +31,8 @@ This package provides a free Assamese truetype/opentype font.
%patch1 -p1 -b .1-fix-font-conf
%patch2 -p1 -b .2-rupee-sign
%patch3 -p1 -b .3-auto-hint-conf
+%patch4 -p1 -b .4-auto-hint-fix-qt
+%patch5 -p1 -b .5-fsf-address-correction
%build
@@ -60,6 +64,10 @@ rm -fr %{buildroot}
%changelog
+* Wed Apr 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-9
+- fixes bug 705348
+- patch for correcting fsf address
+
* Wed Apr 13 2011 Pravin Satpute <psatpute(a)redhat.com> - 2.4.3-8
- fixes bug 692359
13 years