[Fedora-i18n-bugs] [Bug 1013651] New: fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Bug ID: 1013651
           Summary: fi_FI compose keys not working with ibus
           Product: Fedora
           Version: 20
         Component: ibus
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail], [e-mail]

Description of problem as discussed on IRC:

With F18 and later setting LC_CTYPE=fi_FI.UTF-8 does not make
/usr/share/X11/locale/fi_FI.UTF-8/Compose keys to work, one needs to set also
XMODIFIERS=@im=none as ibus has special casing only for pt_BR.UTF-8 currently.

ibus should handle also other relevant compose maps in addition to pt_BR.UTF-8.
The list of compose file which really differ from en_US.UTF-8 is:

/usr/share/X11/locale/am_ET.UTF-8/Compose
/usr/share/X11/locale/el_GR.UTF-8/Compose
/usr/share/X11/locale/fi_FI.UTF-8/Compose
/usr/share/X11/locale/pt_BR.UTF-8/Compose

Version-Release number of selected component (if applicable):
ibus-1.5.4-1.fc20

Additional info:
The quick test to see whether fi_FI compose keys work is that with
LC_CTYPE=fi_FI.UTF-8 dead_acute + space should produce acute (not apostrophe as
with en_US.UTF-8).

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #1 from Marko Myllynen  ---
Note that /etc/X11/xinit/xinitrc.d/50-xinput.sh defines:

_xcompose_language_list="am_ET el_GR fi_FI pt_BR ru_RU"

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #2 from fujiwara  ---
(In reply to Marko Myllynen from comment #0)

I compared en_US.UTF-8/Compose and fi_FI.UTF-8/Compose and it seems only
'<dead_acute> <space>' is different and others are same.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #3 from Marko Myllynen  ---
(In reply to fujiwara from comment #2)
> I compared en_US.UTF-8/Compose and fi_FI.UTF-8/Compose and it seems only
> '<dead_acute> <space>' is different and others are same.

That should pretty much be the case nowadays, some time ago the mappings which
were only in fi_FI.UTF-8 were added to en_US.UTF-8:

http://cgit.freedesktop.org/xorg/lib/libX11/commit/nls/en_US.UTF-8/Compose.p...

Thanks.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #4 from fujiwara  ---
(In reply to Marko Myllynen from comment #3)
> http://cgit.freedesktop.org/xorg/lib/libX11/commit/nls/en_US.UTF-8/Compose.
> pre?id=9b8d8c9e5b27273e8856a3851ba9b68022bed3cd

OK, thank you for the link and then we need to fix en_US.UTF-8.
ibus en_US.UTF-8 was copied from GTK+ one and it seems it's old.

Now I created the patch of en_US.UTF-8 and fi_FI.UTF-8 but others are not yet.

I'm a bit tired to convert the data and probably it's better to fix this in
post f20 since the change is big and the f20 beta is coming.
Probably it's also better for me to fix the fi problem when running apps with
GTK_IM_MODULE=gtk-im-context-simple .

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #5 from fujiwara  ---
Created attachment 807400
  --> https://bugzilla.redhat.com/attachment.cgi?id=807400&action=edit
Patch for engine/main.vala

Attached the ongoing patch at the moment.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|20                          |rawhide

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #6 from Marko Myllynen  ---
(In reply to fujiwara from comment #4)
> OK, thank you for the link and then we need to fix en_US.UTF-8.
> ibus en_US.UTF-8 was copied from GTK+ one and it seems it's old.
>
> I'm a bit tired to convert the data and probably it's better to fix this in
> post f20 since the change is big and the f20 beta is coming.

No prob - just one additional data point (which you probably already noticed)
that when looking at the changelog for en_US.UTF-8/Compose.pre it looks like a
yearly update or so might be warranted:

http://cgit.freedesktop.org/xorg/lib/libX11/log/nls/en_US.UTF-8/Compose.pre

Thanks.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #7 from fujiwara  ---
(In reply to Marko Myllynen from comment #6)
> http://cgit.freedesktop.org/xorg/lib/libX11/log/nls/en_US.UTF-8/Compose.pre

Yes, my patch was generated with that file by compose-parse.py :
https://git.gnome.org/browse/gtk+/tree/gtk/compose-parse.py#n24

The script referred the old pointer and I changed it to your link yesterday.

--- gtk+-3.9.8/gtk/compose-parse.py.orig
+++ gtk+-3.9.8/gtk/compose-parse.py
@@ -21,8 +21,8 @@
 import getopt

# We grab files off the web, left and right.
-URL_COMPOSE =
'http://gitweb.freedesktop.org/?p=xorg/lib/libX11.git;a=blob_plain;f=nls/en_U...'
-URL_KEYSYMSTXT = "http://www.cl.cam.ac.uk/~mgk25/ucs/keysyms.txt"
+URL_COMPOSE =
'http://cgit.freedesktop.org/xorg/lib/libX11/plain/nls/en_US.UTF-8/Compose.pr...'
+URL_KEYSYMSTXT =
"https://raw.github.com/substack/node-keysym/master/data/keysyms.txt"
 URL_GDKKEYSYMSH = "http://git.gnome.org/browse/gtk%2B/plain/gdk/gdkkeysyms.h"
 URL_UNICODEDATATXT = 'http://www.unicode.org/Public/6.0.0/ucd/UnicodeData.txt'
 FILENAME_COMPOSE_SUPPLEMENTARY = 'gtk-compose-lookaside.txt'

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #807400|0                           |1
        is obsolete|                            |

--- Comment #8 from fujiwara  ---
Created attachment 808759
  --> https://bugzilla.redhat.com/attachment.cgi?id=808759&action=edit
Patch for engine/main.vala

OK, now I finished to generate the candidate patch.
I commented out am_ET Compose file until get the actual request because it uses
ASCII key at first but not compose keys.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
              Flags|                            |needinfo?(myllynen@redhat.c
                   |                            |om)

--- Comment #9 from fujiwara  ---
I created the test rpms:
http://fujiwara.fedorapeople.org/ibus/20131008/6034085/

Could you try the packages?

Please note I fix ibus only but not gtk-im-context-simple .

If you use GNOME, need to add some input methods with 'gnome-control-center
region' command and then GNOME will launch ibus-daemon. You could refer 'ps'
command.
(You don't have to use input method engines actually but need to list the
engines on panel icon to enable IBus on GNOME.)

If you use non-GNOME, ibus can be enabled by im-chooser command and you need to
install some XKB layout engines with ibus-setup command.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #10 from Jens Petersen  ---
BTW if you're not using gnome-shell what you probably want
to do is use im-chooser to switch to XIM input, which supports
locale compose.  We really need to add locale compose also
to the gtk simple immodule.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #11 from Mike FABIAN  ---
I tested the packages from comment#9 on Fedora 20 Beta TC1 and they
work fine.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Marko Myllynen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(myllynen@redhat.c |
                   |om)                         |

--- Comment #12 from Marko Myllynen  ---
(In reply to fujiwara from comment #9)
> I created the test rpms:
> http://fujiwara.fedorapeople.org/ibus/20131008/6034085/
>
> Could you try the packages?
>
> Please note I fix ibus only but not gtk-im-context-simple .
>
> If you use GNOME, need to add some input methods with 'gnome-control-center
> region' command and then GNOME will launch ibus-daemon. You could refer 'ps'
> command.
> (You don't have to use input method engines actually but need to list the
> engines on panel icon to enable IBus on GNOME.)

I updated the packages, rebooted, logged in via GDM, launched gnome-terminal
under gnome-shell and confirmed that LC_CTYPE is fi_FI.UTF-8. Then I added with
'gnome-control-center region' Finnish and French as Input Sources. fi is in use
and 'ps -ef | grep ibus' shows ibus running. However, the simple test
dead_acute + space still produces apostrophe not acute as expected.

Please let me know if there was a hickup in my testing procedure.

Thanks.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #13 from Marko Myllynen  ---
> Please let me know if there was a hickup in my testing procedure.

After some IRC discussion it turned out that I needed to add English (English
AG (Hunspell)) as an Input Source then ibus is enabled and the test packages
work as expected. So from ibus point of view the issue is solved.

Thanks.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #14 from fujiwara  ---
(In reply to Marko Myllynen from comment #13)
> After some IRC discussion it turned out that I needed to add English
> (English AG (Hunspell)) as an Input Source then ibus is enabled and the test
> packages work as expected. So from ibus point of view the issue is solved.

Thank you for the test.
Now I'm working on both ibus and gtk.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST

--- Comment #15 from fujiwara  ---
The patch is upstreamed:
https://github.com/ibus/ibus/commit/e64b25c0ab8fadeae97fe78dcfcbc3a5d0869c6b

Regarding to GTK+, I filed a bug:
https://bugzilla.gnome.org/show_bug.cgi?id=710510

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #16 from fujiwara  ---
Now en-us copmose keys are updated in GTK+:
https://bugzilla.gnome.org/show_bug.cgi?id=710510

I filed the compose keys for locales in GTK+:
https://bugzilla.gnome.org/show_bug.cgi?id=721120

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1051431

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1051431
[Bug 1051431] [RHEL7] fi_FI compose keys not working with ibus

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

fujiwara  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #17 from fujiwara  ---
I fixed ibus side in this bug.
gtk bug is filed in comment 16.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #18 from Fedora Update System  ---
ibus-1.5.5-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-1.5.5-1.fc20

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

--- Comment #19 from Fedora Update System  ---
ibus-1.5.5-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ibus-1.5.5-1.fc19

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #20 from Fedora Update System  ---
Package ibus-1.5.5-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ibus-1.5.5-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0847/ibus-1.5.5-1.fc19
then log in and leave karma (feedback).

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |ibus-1.5.5-1.fc20
         Resolution|---                         |ERRATA
        Last Closed|                            |2014-01-17 00:43:20

--- Comment #21 from Fedora Update System  ---
ibus-1.5.5-1.fc20 has been pushed to the Fedora 20 stable repository.  If
problems still persist, please make note of it in this bug report.

[Fedora-i18n-bugs] [Bug 1013651] fi_FI compose keys not working with ibus

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1013651

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|ibus-1.5.5-1.fc20           |ibus-1.5.5-1.fc19

--- Comment #22 from Fedora Update System  ---
ibus-1.5.5-1.fc19 has been pushed to the Fedora 19 stable repository.  If
problems still persist, please make note of it in this bug report.