[Fedora-i18n-bugs] [Bug 1009350] New: generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Bug ID: 1009350
           Summary: generated output looks not correct
           Product: Fedora
           Version: 19
         Component: ttmkfdir
          Keywords: i18n
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail], [e-mail]
            Blocks: 1007493

Description of problem:
This is output with sazanami fonts:
sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-ascii-0
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso10646-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-15
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-9
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1983-0
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1990-0

Apparently there are no jisx0201.1976-0 for that.

Version-Release number of selected component (if applicable):
ttmkfdir-3.0.9-39.fc19.x86_64

How reproducible:
always

Steps to Reproduce:
1.ttmkfdir -d /path/to/sazanami/font
2.see the generated fonts.scale
3.

Actual results:
no jisx0201.1976-0

Expected results:
should be there

Additional info:
http://en.wikipedia.org/wiki/JIS_X_0201 for more details of JIS X 0201
1976 is a revision number for this spec.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Parag  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Parag  ---
when I try to reproduce this I got fonts.scale with its contents as
5
sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-ascii-0
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso10646-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-15
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-9

whereas stock fonts.scale on system is
7
sazanami-gothic.ttf -misc-Sazanami Gothic-medium-r-normal--0-0-0-0-c-0-ascii-0
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso10646-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-1
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-15
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-iso8859-9
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1983-0
sazanami-gothic.ttf -misc-Sazanami
Gothic-medium-r-normal--0-0-0-0-c-0-jisx0208.1990-0

so exactly what is missing or required? this bug description says no entry for
jisx0201.1976-0 in fonts.scale whereas other bug
https://bugzilla.redhat.com/show_bug.cgi?id=1007493#c4

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #2 from Akira TAGOH  ---
Did you try that with xorg-x11-fonts-misc installed?

Anyway, I see the same result to the system's here and of course presuming that
is missing jisx0201.1976-0 as I mentioned the above.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #3 from Parag  ---
Thanks. I have installed now xorg-x11-fonts-misc package. Now, I got the same
output as system installed fonts.scale

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #4 from Akira TAGOH  ---
got back to investigate this issue. after taking a look at this a bit, I
noticed that the problem is ttmkfdir is going to check the undefined area in
the encoding maps. for instance, jisx0201.1976-0.enc.gz has:

STARTMAPPING unicode
0x5C    0x00A5  # YEN SIGN
0x7E    0x203E  # OVERLINE
0x00A1 0x00DF 0xFF61
ENDMAPPING

this defines 65 characters on the map but ttmkfdir tries to check the undefined
ranges like between 0x5d and 0x7d, and between 0x7f and 0xa0. this is the
unexpected behavior.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #5 from Akira TAGOH  ---
Created attachment 947548
  --> https://bugzilla.redhat.com/attachment.cgi?id=947548&action=edit
proposed patch to avoid checking the undefined character range.

I don't have too much testing with it. there might be a regression perhaps.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #6 from Pravin Satpute  ---
I think we need to create some test cases to avoid regression.

1. Generating fonts.scale for all installed fonts.

2. Generating fonts.scale for all installed fonts with updated ttmkfdir.

3. Comparing them for possible regression.

How do you find this idea?

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |ect.org,
                   |                            |[e-mail]
          Component|ttmkfdir                    |xorg-x11-fonts
           Assignee|[e-mail]         |[e-mail]

--- Comment #7 from Akira TAGOH  ---
Oh, wrong patch. the document for the format of the encoding files says, "Codes
not listed are assumed to map through the identity (i.e. to the same numerical
value). In order to override this default mapping, you may specify a range of
codes to be undefined by using an `UNDEFINE' line"

So where we need to fix seems the encoding file then.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Akira TAGOH  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #947548|0                           |1
        is obsolete|                            |

--- Comment #8 from Akira TAGOH  ---
Created attachment 947790
  --> https://bugzilla.redhat.com/attachment.cgi?id=947790&action=edit
fix for jisx0201.1976-0.enc.gz

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]        |[e-mail]

--- Comment #9 from Hans de Goede  ---
(In reply to Akira TAGOH from comment #8)
> Created attachment 947790 [details]
> fix for jisx0201.1976-0.enc.gz

Thanks, I'm preparing an updated xorg-x11-fonts package with this patch
included, and I'll also send it upstream.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #10 from Fedora Update System  ---
xorg-x11-fonts-7.5-11.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/xorg-x11-fonts-7.5-11.fc21

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #11 from Fedora Update System  ---
Package xorg-x11-fonts-7.5-11.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xorg-x11-fonts-7.5-11.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-13532/xorg-x11-fonts-7.5...
then log in and leave karma (feedback).

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |xorg-x11-fonts-7.5-11.fc21
         Resolution|---                         |ERRATA
        Last Closed|                            |2014-11-01 12:37:53

--- Comment #12 from Fedora Update System  ---
xorg-x11-fonts-7.5-11.fc21 has been pushed to the Fedora 21 stable repository. 
If problems still persist, please make note of it in this bug report.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #13 from Akira TAGOH  ---
Is it possible to backport the fix for f20 too?

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

Simone Caronni  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Simone Caronni  ---
(In reply to Akira TAGOH from comment #13)
> Is it possible to backport the fix for f20 too?

Doing it now.

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #15 from Fedora Update System  ---
xorg-x11-fonts-7.5-10.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/xorg-x11-fonts-7.5-10.fc20

[Fedora-i18n-bugs] [Bug 1009350] generated output looks not correct

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009350

--- Comment #16 from Fedora Update System  ---
xorg-x11-fonts-7.5-10.fc20 has been pushed to the Fedora 20 stable repository. 
If problems still persist, please make note of it in this bug report.