https://bugzilla.redhat.com/show_bug.cgi?id=1036462
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #18 from Christopher Meng <cickumqt(a)gmail.com> ---
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1CcDGnGjxd&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1036462
--- Comment #17 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
(In reply to Nicolas Mailhot from comment #16)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #14)
> > Thank you for the review.
> >
> > (In reply to Christopher Meng from comment #13)
> > > [x]: License file installed when any subpackage combination is installed.
> > > [!]: Package must own all directories that it creates.
> > > Note: Directories without known owners: /usr/share/fonts,
>
> This directory should be owned by fontpackages if the deps have been
> properly declared
Yes. R:fontpackages-filesystem was attached to the wrong subpackage and is now
fixed (in unifont-6.3.20131221-2 above).
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GywaHZCghj&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1036462
--- Comment #16 from Nicolas Mailhot <nicolas.mailhot(a)laposte.net> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #14)
> Thank you for the review.
>
> (In reply to Christopher Meng from comment #13)
> > [x]: License file installed when any subpackage combination is installed.
> > [!]: Package must own all directories that it creates.
> > Note: Directories without known owners: /usr/share/fonts,
This directory should be owned by fontpackages if the deps have been properly
declared
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SWaqD5wwvk&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1036462
--- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
Thank you for the review.
(In reply to Christopher Meng from comment #13)
> [x]: License file installed when any subpackage combination is installed.
> [!]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/share/fonts,
> /usr/share/doc/unifont
Fixed both.
> [x]: Each %files section contains %defattr if rpm < 4.4
> Note: %defattr present but not needed
>
> ---> Caused by font_pkg, may request a bug report later if you can.
https://bugzilla.redhat.com/show_bug.cgi?id=1047031
> Rpmlint
> -------
> Checking: unifont-6.3.20131221-1.fc21.i686.rpm
> unifont-fonts-6.3.20131221-1.fc21.noarch.rpm
> unifont-6.3.20131221-1.fc21.src.rpm
> unifont.i686: W: name-repeated-in-summary C unifont
> unifont-fonts.noarch: W: spelling-error %description -l en_US glyphs ->
> glyph, glyph s
> unifont.src: W: name-repeated-in-summary C unifont
> 3 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
> unifont.i686: W: name-repeated-in-summary C unifont
> 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
> # echo 'rpmlint-done:'
I changed the summaries and descriptions to be more verbose.
Spec URL: http://in.waw.pl/~zbyszek/fedora/unifont.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/unifont-6.3.20131221-2.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hp7JXnkGVu&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1036462
--- Comment #13 from Christopher Meng <cickumqt(a)gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or
later)". Detailed output of licensecheck:
*No copyright* GPL (v2 or later)
--------------------------------
unifont-6.3.20131221/src/unigencircles.c
unifont-6.3.20131221/src/unigenwidth.c
GPL (v2 or later)
-----------------
unifont-6.3.20131221/src/unibdf2hex.c
unifont-6.3.20131221/src/unibmp2hex.c
unifont-6.3.20131221/src/unicoverage.c
unifont-6.3.20131221/src/unidup.c
unifont-6.3.20131221/src/unifontpic.c
unifont-6.3.20131221/src/unihex2bmp.c
unifont-6.3.20131221/src/unihexgen.c
GPL (v3 or later)
-----------------
unifont-6.3.20131221/src/unipagecount.c
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/fonts,
/usr/share/doc/unifont
---> First one aybe a filesystem bug? Second one is an issue.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
---> Caused by font_pkg, may request a bug report later if you can.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Texinfo files are installed using install-info in %post and %preun if
package has .info files.
Note: Texinfo .info file(s) in unifont
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
http://ftp.gnu.org/gnu/unifont/unifont-6.3.20131221/unifont-6.3.20131221.ta…
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
---> My problem, ignored.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in unifont-
fonts
---> Bug of fedora-review, I will patch it later.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 3901440 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: unifont-6.3.20131221-1.fc21.i686.rpm
unifont-fonts-6.3.20131221-1.fc21.noarch.rpm
unifont-6.3.20131221-1.fc21.src.rpm
unifont.i686: W: name-repeated-in-summary C unifont
unifont-fonts.noarch: W: spelling-error %description -l en_US glyphs -> glyph,
glyph s
unifont.src: W: name-repeated-in-summary C unifont
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint unifont-fonts unifont
unifont-fonts.noarch: W: spelling-error %description -l en_US glyphs -> glyph,
glyph s
unifont.i686: W: name-repeated-in-summary C unifont
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'
Requires
--------
unifont-fonts (rpmlib, GLIBC filtered):
/bin/sh
unifont (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/perl
fontpackages-filesystem
info
libc.so.6
perl(GD)
perl(Getopt::Long)
rtld(GNU_HASH)
Provides
--------
unifont-fonts:
font(:lang=aa)
font(:lang=ab)
font(:lang=af)
font(:lang=ak)
font(:lang=am)
font(:lang=an)
font(:lang=ar)
font(:lang=as)
font(:lang=ast)
font(:lang=av)
font(:lang=ay)
font(:lang=az-az)
font(:lang=az-ir)
font(:lang=ba)
font(:lang=be)
font(:lang=ber-dz)
font(:lang=ber-ma)
font(:lang=bg)
font(:lang=bh)
font(:lang=bho)
font(:lang=bi)
font(:lang=bin)
font(:lang=bm)
font(:lang=bn)
font(:lang=bo)
font(:lang=br)
font(:lang=brx)
font(:lang=bs)
font(:lang=bua)
font(:lang=byn)
font(:lang=ca)
font(:lang=ce)
font(:lang=ch)
font(:lang=chm)
font(:lang=chr)
font(:lang=co)
font(:lang=crh)
font(:lang=cs)
font(:lang=csb)
font(:lang=cu)
font(:lang=cv)
font(:lang=cy)
font(:lang=da)
font(:lang=de)
font(:lang=doi)
font(:lang=dv)
font(:lang=dz)
font(:lang=ee)
font(:lang=el)
font(:lang=en)
font(:lang=eo)
font(:lang=es)
font(:lang=et)
font(:lang=eu)
font(:lang=fa)
font(:lang=fat)
font(:lang=ff)
font(:lang=fi)
font(:lang=fil)
font(:lang=fj)
font(:lang=fo)
font(:lang=fr)
font(:lang=fur)
font(:lang=fy)
font(:lang=ga)
font(:lang=gd)
font(:lang=gez)
font(:lang=gl)
font(:lang=gn)
font(:lang=gu)
font(:lang=gv)
font(:lang=ha)
font(:lang=haw)
font(:lang=he)
font(:lang=hi)
font(:lang=hne)
font(:lang=ho)
font(:lang=hr)
font(:lang=hsb)
font(:lang=ht)
font(:lang=hu)
font(:lang=hy)
font(:lang=hz)
font(:lang=ia)
font(:lang=id)
font(:lang=ie)
font(:lang=ig)
font(:lang=ii)
font(:lang=ik)
font(:lang=io)
font(:lang=is)
font(:lang=it)
font(:lang=iu)
font(:lang=ja)
font(:lang=jv)
font(:lang=ka)
font(:lang=kaa)
font(:lang=kab)
font(:lang=ki)
font(:lang=kj)
font(:lang=kk)
font(:lang=kl)
font(:lang=km)
font(:lang=kn)
font(:lang=ko)
font(:lang=kok)
font(:lang=kr)
font(:lang=ks)
font(:lang=ku-am)
font(:lang=ku-iq)
font(:lang=ku-ir)
font(:lang=ku-tr)
font(:lang=kum)
font(:lang=kv)
font(:lang=kw)
font(:lang=kwm)
font(:lang=ky)
font(:lang=la)
font(:lang=lah)
font(:lang=lb)
font(:lang=lez)
font(:lang=lg)
font(:lang=li)
font(:lang=ln)
font(:lang=lo)
font(:lang=lt)
font(:lang=lv)
font(:lang=mai)
font(:lang=mg)
font(:lang=mh)
font(:lang=mi)
font(:lang=mk)
font(:lang=ml)
font(:lang=mn-cn)
font(:lang=mn-mn)
font(:lang=mni)
font(:lang=mo)
font(:lang=mr)
font(:lang=ms)
font(:lang=mt)
font(:lang=my)
font(:lang=na)
font(:lang=nb)
font(:lang=nds)
font(:lang=ne)
font(:lang=ng)
font(:lang=nl)
font(:lang=nn)
font(:lang=no)
font(:lang=nqo)
font(:lang=nr)
font(:lang=nso)
font(:lang=nv)
font(:lang=ny)
font(:lang=oc)
font(:lang=om)
font(:lang=or)
font(:lang=os)
font(:lang=ota)
font(:lang=pa)
font(:lang=pa-pk)
font(:lang=pap-an)
font(:lang=pap-aw)
font(:lang=pl)
font(:lang=ps-af)
font(:lang=ps-pk)
font(:lang=pt)
font(:lang=qu)
font(:lang=quz)
font(:lang=rm)
font(:lang=rn)
font(:lang=ro)
font(:lang=ru)
font(:lang=rw)
font(:lang=sa)
font(:lang=sah)
font(:lang=sat)
font(:lang=sc)
font(:lang=sco)
font(:lang=sd)
font(:lang=se)
font(:lang=sel)
font(:lang=sg)
font(:lang=sh)
font(:lang=shs)
font(:lang=si)
font(:lang=sid)
font(:lang=sk)
font(:lang=sl)
font(:lang=sm)
font(:lang=sma)
font(:lang=smj)
font(:lang=smn)
font(:lang=sms)
font(:lang=sn)
font(:lang=so)
font(:lang=sq)
font(:lang=sr)
font(:lang=ss)
font(:lang=st)
font(:lang=su)
font(:lang=sv)
font(:lang=sw)
font(:lang=syr)
font(:lang=ta)
font(:lang=te)
font(:lang=tg)
font(:lang=th)
font(:lang=ti-er)
font(:lang=ti-et)
font(:lang=tig)
font(:lang=tk)
font(:lang=tl)
font(:lang=tn)
font(:lang=to)
font(:lang=tr)
font(:lang=ts)
font(:lang=tt)
font(:lang=tw)
font(:lang=ty)
font(:lang=tyv)
font(:lang=ug)
font(:lang=uk)
font(:lang=ur)
font(:lang=uz)
font(:lang=ve)
font(:lang=vi)
font(:lang=vo)
font(:lang=vot)
font(:lang=wa)
font(:lang=wal)
font(:lang=wen)
font(:lang=wo)
font(:lang=xh)
font(:lang=yap)
font(:lang=yi)
font(:lang=yo)
font(:lang=za)
font(:lang=zh-cn)
font(:lang=zh-sg)
font(:lang=zh-tw)
font(:lang=zu)
font(unifont)
unifont-fonts
unifont:
unifont
unifont(x86-32)
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn unifont-6.3.20131221-1.fc20.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: BATCH, EPEL5, EXARCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2MDUhKxmJB&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=1043181
Bug ID: 1043181
Summary: epoch revision for f20 is lower than f19 and causes
issues with fedup
Product: Fedora
Version: 20
Component: imsettings
Assignee: tagoh(a)redhat.com
Reporter: BobLfoot(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: i18n-bugs(a)lists.fedoraproject.org, tagoh(a)redhat.com
Description of problem:
Following fedup instructions the f19 imsettings remain because it is "newer"
than the f20 version.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=clMbZFfN56&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=863298
Bug ID: 863298
QA Contact: extras-qa(a)fedoraproject.org
Severity: medium
Version: 18
Priority: unspecified
CC: i18n-bugs(a)lists.fedoraproject.org,
shawn.p.huang(a)gmail.com, tfujiwar(a)redhat.com
Assignee: tfujiwar(a)redhat.com
Summary: Switch shortcut does not work in GNOME ScreenLock
Regression: ---
Story Points: ---
Classification: Fedora
OS: Linux
Reporter: sangu.fedora(a)gmail.com
Type: Bug
Documentation: ---
Hardware: x86_64
Mount Type: ---
Status: NEW
Component: ibus
Product: Fedora
Description of problem:
Switch shortcut does not work in GNOME ScreenLock
Version-Release number of selected component (if applicable):
1.4.99.20120914-2.fc18.x86_64
How reproducible:
always
Steps to Reproduce:
1. ctrl + alt + l (ScreenLock)
2. ctrl + space
3.
Actual results:
Expected results:
Additional info:
gnome-shell-3.6.0-1.fc18.x86_64
gnome-screensaver-3.6.0-1.fc18.x86_64
--
You are receiving this mail because:
You are on the CC list for the bug.