[Fedora-i18n-bugs] [Bug 1038128] Review Request: libeot - a library for parsing Embedded OpenType font files
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1038128
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flags| |fedora-review+
--- Comment #3 from Parag AN(पराग) <panemade(a)gmail.com> ---
Review:
+ mock build for rawhide is successful
+ rpmlint on generated rpms
libeot-devel.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-documentation
libeot-tools.x86_64: W: no-manual-page-for-binary eot2ttf
5 packages and 0 specfiles checked; 0 errors, 3 warnings.
+ source verified with upstream as sha256sum
srpm tarball :
cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a
upstream tarball :
cf5091fa8e7dcdbe667335eb90a2cfdd0a3fe8f8c7c8d1ece44d9d055736a06a
+ License is valid and included in LICENSE file
suggestion:
1) header file timestamp can be preserved if used
make install DESTDIR=%{buildroot} INSTALL="install -p"
2) build.log showing
configure: WARNING: unrecognized options: --disable-werror
so remove that option to ./configure
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XKxmeiB8dR&a=cc_unsubscribe
10 years, 4 months
[Fedora-i18n-bugs] [Bug 1036754] Review Request: ttembed - Remove embedding limitations from TrueType fonts
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1036754
Petr Vobornik <pvoborni(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(pvoborni(a)redhat.c |
|om) |
--- Comment #2 from Petr Vobornik <pvoborni(a)redhat.com> ---
Thank you for the review.
Spec and srpm updated:
* man page included
* %{?_smp_mflags} macro added
* simple smoke test added - The only functionality tested is detection of not a
font file because it has the most distinctive output. Other use cases are very
similar to each other (exit code 0 with no output). Using Buildrequires with
font with incorrect fsType is not used because the test will become incorrect
when the font is fixed. More comprehensive tests should be implemented upstream
and then the %check section should be replaced by simple `make test`.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m3IpYQT2GY&a=cc_unsubscribe
10 years, 5 months