[Fedora-i18n-bugs] [Bug 585424] New: Langpacks goes on crack, for "removals" _and_ "updated"

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Langpacks goes on crack, for "removals" _and_ "updated"

https://bugzilla.redhat.com/show_bug.cgi?id=585424

           Summary: Langpacks goes on crack, for "removals" _and_
                    "updated"
           Product: Fedora
           Version: 13
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: urgent
         Component: yum-langpacks
        AssignedTo: petersen(a)redhat.com
        ReportedBy: james.antill(a)redhat.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: petersen(a)redhat.com, i18n-bugs(a)lists.fedoraproject.org
    Classification: Fedora
    Target Release: ---


Description of problem:

 There are two bugs, which can combine to make yum-langpacks rm most of the
system (and, yes, I introduced both of them).

1. We catch obsoletes as well as removals with:

            elif member.ts_state in ('e', None):
                remove_deps_from_ts(conduit, po)

...but "None" is that state for "obsoleted" _and_ "updated".
So any updated
package can try and remove all it's languages.

2. remove_deps_from_ts() is done via:

     for pkg in yb.rpmdb.returnPackages(patterns=pkgmatches):
        yb.remove(pattern=pkg.name)

...except pkgmatches will == [] _if_ LANG=C, and due to weird back compat.
behaviour rpmdb.returnPackages(patterns=[]) returns all the packages on the
system.

 For F-13 just fix #1 by just checking for == 'e' again, and ignore obsoleted
for now. Again, for F-13 #2 needs an:

  if not pkgmatches: return

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack, for "removals" _and_ "updated"

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

James Antill <james.antill(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|medium                      |urgent
               Flag|                            |needinfo?

--- Comment #1 from James Antill <james.antill(a)redhat.com&gt; 2010-04-23 19:37:02 EDT
---
 I haven't tested an F-13 box with langpacks yet (I can do that later tonight
if nobody else gets around to it) ... but following the code, I'm pretty sure
it can happen.

 Someone just try updating openoffice-core in F-13, with LANG=C.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

James Antill <james.antill(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Langpacks goes on crack,    |Langpacks goes on crack in
                   |for "removals" _and_        |LANG=C, for
"removals"
                   |"updated"                   |_and_ "updated",
removing
                   |                            |everything

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

James Antill <james.antill(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |507681(F13Blocker)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

James Antill <james.antill(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?                   |

--- Comment #2 from James Antill <james.antill(a)redhat.com&gt; 2010-04-23 19:59:30 EDT
---
 99.999% confirmed this on an F-13 box:

% sudo yum install yum-langpacks
[...]
% sudo yum downgrade openoffice.org --releasever=12
[...]
Dep fails.
% LANG=C sudo yum downgrade openoffice.org --releasever=12
[...]
Wants to erase glibc etc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Jens Petersen <petersen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Jens Petersen <petersen(a)redhat.com&gt; 2010-04-24 01:36:59 EDT ---
Thanks James for the report.

I would really appreciate patch please, though if not I will try to grok
your comments as best I can.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Jens Petersen <petersen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|urgent                      |high
           Severity|urgent                      |high

--- Comment #4 from Jens Petersen <petersen(a)redhat.com&gt; 2010-04-24 01:38:59 EDT ---
(I am not really convinced that this is a blocker though given
that yum-langpacks is not installed by default in F13, but sure
let's fix it.  You're also more than welcome to commit the fix.:)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #5 from James Antill <james.antill(a)redhat.com&gt; 2010-04-24 10:40:52 EDT
---
Well I'm pretty sure this is what deleted Jim Meyering's box:

http://lists.fedoraproject.org/pipermail/devel/2010-April/135037.html

...so it seemed kind of important ;).

 I have F-13 changes ready to go, as soon as I get ACLs to commit.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #6 from James Antill <james.antill(a)redhat.com&gt; 2010-04-24 10:42:04 EDT
---
Created an attachment (id=408836)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=408836)
Fix the problems with langpacks deleting systems.

Here is the patch, in case you want to do it yourself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-04-26
09:57:46 EDT ---
yum-langpacks-0.1.5-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/yum-langpacks-0.1.5-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

seth vidal <svidal(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |meyering(a)redhat.com

--- Comment #8 from seth vidal <svidal(a)redhat.com&gt; 2010-04-26 15:39:05 EDT ---
*** Bug 584997 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Jens Petersen <petersen(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #9 from Jens Petersen <petersen(a)redhat.com&gt; 2010-04-27 00:43:47 EDT ---
Thank you very much, James.  Appreciate your assistance.

I didn't realise what a dangerous business I was getting into. :(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-04-27
01:51:24 EDT ---
yum-langpacks-0.1.5-2.fc13 has been pushed to the Fedora 13 testing repository.
 If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update yum-langpacks'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/yum-langpacks-0.1.5-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #11 from Jim Meyering <meyering(a)redhat.com&gt; 2010-04-27 04:09:57 EDT ---
Thanks for the fix, James, and for the heads-up, Seth.
I confirm that LC_ALL=C is often set in my environment (in which case, LANG is
not set at all).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Adam Williamson <awilliam(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |awilliam(a)redhat.com

--- Comment #12 from Adam Williamson <awilliam(a)redhat.com&gt; 2010-05-03 16:44:58 EDT
---
This needs to be tested ASAP to get in for final. I will try and test it later
tonight using the reproduction steps listed above, but any help would obviously
be appreciated :)



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #13 from Adam Williamson <awilliam(a)redhat.com&gt; 2010-05-03 18:50:44 EDT
---
Can't find a reproducer for the actual bug with the current package set, but
the updated yum-langpacks installs correctly and does what it's meant to do.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #14 from Adam Williamson <awilliam(a)redhat.com&gt; 2010-05-04 19:27:52 EDT
---
can the update please be submitted to stable ASAP? it has sufficient karma.
thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org&gt; 2010-05-04
19:54:30 EDT ---
yum-langpacks-0.1.5-2.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Fedora-i18n-bugs] [Bug 585424] Langpacks goes on crack in LANG=C, for "removals" _and_ "updated", removing everything

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=585424

Fedora Update System <updates(a)fedoraproject.org&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |yum-langpacks-0.1.5-2.fc13
         Resolution|                            |ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.