master - tests: enusure lib is initilized
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=91df257b53849ca4206...
Commit: 91df257b53849ca4206f4c3d45c71bff83c4a5ee
Parent: e92d3bd1f75d335fba5303c433516ea4ebe5cab1
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 13:04:29 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
tests: enusure lib is initilized
---
test/Makefile.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/Makefile.in b/test/Makefile.in
index fcb612d..9fa908e 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -315,7 +315,7 @@ lib/dm-version-expected: $(top_srcdir)/VERSION_DM .lib-dir-stamp
CMDS = lvm $(shell cat $(top_builddir)/tools/.commands 2>/dev/null)
LIB = $(addprefix lib/, $(LIB_SECURETEST) $(LIB_DMSECURETEST) $(LIB_SHARED) $(LIB_LOCAL) $(LIB_NOT) $(LIB_LINK_NOT) $(LIB_FLAVOURS))
-.tests-stamp: $(ALL) $(LIB) $(SUBDIRS) lib/version-expected lib/dm-version-expected unit-test
+.tests-stamp: .lib-dir-stamp $(ALL) $(LIB) $(SUBDIRS) lib/version-expected lib/dm-version-expected unit-test
@echo " [TEST-STAMP]"
@if test "$(srcdir)" != . ; then \
echo "Linking tests to builddir."; \
4 years, 5 months
master - debug: enhance debug messages
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e92d3bd1f75d335fba5...
Commit: e92d3bd1f75d335fba5303c433516ea4ebe5cab1
Parent: 14e01d6316479a1ee6225010f36d348c103a26c7
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 17:00:56 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
debug: enhance debug messages
---
lib/label/hints.c | 42 ++++++++++++++++++++++--------------------
1 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/lib/label/hints.c b/lib/label/hints.c
index 45ab2ff..d913b68 100644
--- a/lib/label/hints.c
+++ b/lib/label/hints.c
@@ -192,7 +192,7 @@ static int _hints_exists(void)
if (!stat(_hints_file, &buf))
return 1;
if (errno != ENOENT)
- log_debug("hints_exist errno %d", errno);
+ log_sys_debug("stat", _hints_file);
return 0;
}
@@ -203,7 +203,7 @@ static int _nohints_exists(void)
if (!stat(_nohints_file, &buf))
return 1;
if (errno != ENOENT)
- log_debug("nohints_exist errno %d", errno);
+ log_sys_debug("stat", _nohints_file);
return 0;
}
@@ -214,7 +214,7 @@ static int _newhints_exists(void)
if (!stat(_newhints_file, &buf))
return 1;
if (errno != ENOENT)
- log_debug("newhints_exist errno %d", errno);
+ log_sys_debug("stat", _newhints_file);
return 0;
}
@@ -225,7 +225,7 @@ static int _touch_newhints(void)
if (!(fp = fopen(_newhints_file, "w")))
return_0;
if (fclose(fp))
- stack;
+ log_sys_debug("fclose", _newhints_file);
return 1;
}
@@ -236,7 +236,7 @@ static int _touch_nohints(void)
if (!(fp = fopen(_nohints_file, "w")))
return_0;
if (fclose(fp))
- stack;
+ log_sys_debug("fclose", _nohints_file);
return 1;
}
@@ -247,26 +247,26 @@ static int _touch_hints(void)
if (!(fp = fopen(_hints_file, "w")))
return_0;
if (fclose(fp))
- stack;
+ log_sys_debug("fclose", _hints_file);
return 1;
}
static void _unlink_nohints(void)
{
- if (unlink(_nohints_file))
- log_debug("unlink_nohints errno %d", errno);
+ if (unlink(_nohints_file) && errno != ENOENT)
+ log_sys_debug("unlink", _nohints_file);
}
static void _unlink_hints(void)
{
- if (unlink(_hints_file))
- log_debug("unlink_hints errno %d", errno);
+ if (unlink(_hints_file) && errno != ENOENT)
+ log_sys_debug("unlink", _hints_file);
}
static void _unlink_newhints(void)
{
- if (unlink(_newhints_file))
- log_debug("unlink_newhints errno %d", errno);
+ if (unlink(_newhints_file) && errno != ENOENT)
+ log_sys_debug("unlink", _newhints_file);
}
static int _clear_hints(struct cmd_context *cmd)
@@ -275,7 +275,7 @@ static int _clear_hints(struct cmd_context *cmd)
time_t t;
if (!(fp = fopen(_hints_file, "w"))) {
- log_warn("Failed to clear hint file.");
+ log_warn("WARNING: Failed to clear hint file.");
/* shouldn't happen, but try to unlink in case */
_unlink_hints();
return 0;
@@ -286,10 +286,10 @@ static int _clear_hints(struct cmd_context *cmd)
fprintf(fp, "# Created empty by %s pid %d %s", cmd->name, getpid(), ctime(&t));
if (fflush(fp))
- log_debug("clear_hints flush errno %d", errno);
+ log_sys_debug("fflush", _hints_file);
if (fclose(fp))
- log_debug("clear_hints close errno %d", errno);
+ log_sys_debug("fclose", _hints_file);
return 1;
}
@@ -313,7 +313,7 @@ static int _lock_hints(struct cmd_context *cmd, int mode, int nonblock)
fd = open(_hints_file, O_RDWR);
if (fd < 0) {
- log_debug("lock_hints open errno %d", errno);
+ log_sys_debug("open", _hints_file);
return 0;
}
@@ -641,10 +641,13 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
int ret = 1;
int i;
- if (!(fp = fopen(_hints_file, "r")))
+ if (!(fp = fopen(_hints_file, "r"))) {
+ if (errno != ENOENT)
+ log_sys_debug("fopen", _hints_file);
return 0;
+ }
- log_debug("Reading hint file");
+ log_debug("Reading hint file %s.", _hints_file);
for (i = 0; i < HINT_LINE_WORDS; i++)
split[i] = NULL;
@@ -773,7 +776,7 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
}
if (fclose(fp))
- stack;
+ log_sys_debug("fclose", _hints_file);
if (!ret)
return 0;
@@ -1354,4 +1357,3 @@ int get_hints(struct cmd_context *cmd, struct dm_list *hints_out, int *newhints,
return 1;
}
-
4 years, 5 months
master - hints: drop unneeded memset
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=14e01d6316479a1ee62...
Commit: 14e01d6316479a1ee6225010f36d348c103a26c7
Parent: 1760b96368ae41e76e89a7064254f995713a41e5
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 17:59:32 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
hints: drop unneeded memset
strncpy will zero buffer itself.
---
lib/label/hints.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/label/hints.c b/lib/label/hints.c
index ac2c089..45ab2ff 100644
--- a/lib/label/hints.c
+++ b/lib/label/hints.c
@@ -941,7 +941,6 @@ int write_hint_file(struct cmd_context *cmd, int newhints)
* detect when the devices on the system change, which
* invalidates the existing hints.
*/
- memset(devpath, 0, sizeof(devpath));
strncpy(devpath, dev_name(dev), PATH_MAX);
hash = calc_crc(hash, (const uint8_t *)devpath, strlen(devpath));
count++;
4 years, 5 months
master - hints: no need to check for NULL before free
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=1760b96368ae41e76e8...
Commit: 1760b96368ae41e76e89a7064254f995713a41e5
Parent: 9af1d63b4d96facb0aa055a44c2f61eac01e13f2
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 17:17:09 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
hints: no need to check for NULL before free
free() itself checks for NULL.
---
lib/label/hints.c | 18 ++++++------------
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/lib/label/hints.c b/lib/label/hints.c
index c6039d5..ac2c089 100644
--- a/lib/label/hints.c
+++ b/lib/label/hints.c
@@ -688,13 +688,11 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
_filter_to_str(cmd, devices_global_filter_CFG, &filter_str);
if (!filter_str || strcmp(filter_str, _hint_line + keylen)) {
log_debug("ignore hints with different global_filter");
- if (filter_str)
- free(filter_str);
+ free(filter_str);
*needs_refresh = 1;
break;
}
- if (filter_str)
- free(filter_str);
+ free(filter_str);
continue;
}
@@ -703,13 +701,11 @@ static int _read_hint_file(struct cmd_context *cmd, struct dm_list *hints, int *
_filter_to_str(cmd, devices_filter_CFG, &filter_str);
if (!filter_str || strcmp(filter_str, _hint_line + keylen)) {
log_debug("ignore hints with different filter");
- if (filter_str)
- free(filter_str);
+ free(filter_str);
*needs_refresh = 1;
break;
}
- if (filter_str)
- free(filter_str);
+ free(filter_str);
continue;
}
@@ -907,13 +903,11 @@ int write_hint_file(struct cmd_context *cmd, int newhints)
_filter_to_str(cmd, devices_global_filter_CFG, &filter_str);
fprintf(fp, "global_filter:%s\n", filter_str ?: "-");
- if (filter_str)
- free(filter_str);
+ free(filter_str);
_filter_to_str(cmd, devices_filter_CFG, &filter_str);
fprintf(fp, "filter:%s\n", filter_str ?: "-");
- if (filter_str)
- free(filter_str);
+ free(filter_str);
fprintf(fp, "scan_lvs:%d\n", cmd->scan_lvs);
4 years, 5 months
master - cov: remove unused headers
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=ad0343d8cb964491296...
Commit: ad0343d8cb9644912961a72760df083378104078
Parent: 9ee3af7efc4bece83769a75586ffcb0f07a74d16
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 16:55:09 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
cov: remove unused headers
---
lib/cache/lvmcache.c | 1 -
lib/metadata/cache_manip.c | 1 -
lib/metadata/writecache_manip.c | 2 --
3 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c
index 25d110d..6224fe0 100644
--- a/lib/cache/lvmcache.c
+++ b/lib/cache/lvmcache.c
@@ -21,7 +21,6 @@
#include "lib/locking/locking.h"
#include "lib/metadata/metadata.h"
#include "lib/mm/memlock.h"
-#include "lib/datastruct/str_list.h"
#include "lib/format_text/format-text.h"
#include "lib/config/config.h"
diff --git a/lib/metadata/cache_manip.c b/lib/metadata/cache_manip.c
index 2f35d83..5613a22 100644
--- a/lib/metadata/cache_manip.c
+++ b/lib/metadata/cache_manip.c
@@ -23,7 +23,6 @@
#include "lib/config/defaults.h"
#include "lib/metadata/lv_alloc.h"
#include "lib/misc/lvm-signal.h"
-#include "lib/activate/dev_manager.h"
/* https://github.com/jthornber/thin-provisioning-tools/blob/master/caching/... */
#define DM_TRANSACTION_OVERHEAD 4096 /* KiB */
diff --git a/lib/metadata/writecache_manip.c b/lib/metadata/writecache_manip.c
index 73fbd2e..5a5a759 100644
--- a/lib/metadata/writecache_manip.c
+++ b/lib/metadata/writecache_manip.c
@@ -21,8 +21,6 @@
#include "lib/metadata/segtype.h"
#include "lib/activate/activate.h"
#include "lib/config/defaults.h"
-#include "lib/metadata/lv_alloc.h"
-#include "lib/misc/lvm-signal.h"
#include "lib/activate/dev_manager.h"
int lv_is_writecache_origin(const struct logical_volume *lv)
4 years, 5 months
master - cov: use zalloc
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=9af1d63b4d96facb0aa...
Commit: 9af1d63b4d96facb0aa055a44c2f61eac01e13f2
Parent: 33c1d2e92137876116fd81cdca61874cc8e299c7
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 17:13:58 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
cov: use zalloc
Instead of malloc() memset() -> zalloc()
---
tools/pvck.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tools/pvck.c b/tools/pvck.c
index c9692b0..4a267dd 100644
--- a/tools/pvck.c
+++ b/tools/pvck.c
@@ -655,9 +655,8 @@ static int _dump_meta_area(struct device *dev, const char *tofile,
if (!tofile)
return_0;
- if (!(meta_buf = malloc(mda_size)))
+ if (!(meta_buf = zalloc(mda_size)))
return_0;
- memset(meta_buf, 0, mda_size);
if (!dev_read_bytes(dev, mda_offset, mda_size, meta_buf)) {
log_print("CHECK: failed to read metadata area at offset %llu size %llu",
@@ -713,12 +712,11 @@ static int _dump_current_text(struct device *dev,
int ri = rlocn_index; /* 0 or 1 */
int bad = 0;
- if (!(meta_buf = malloc(meta_size))) {
+ if (!(meta_buf = zalloc(meta_size))) {
log_print("CHECK: mda_header_%d.raw_locn[%d] no mem for metadata text size %llu", mn, ri,
(unsigned long long)meta_size);
return 0;
}
- memset(meta_buf, 0, meta_size);
/*
* Read the metadata text specified by the raw_locn so we can
@@ -1496,9 +1494,8 @@ static int _dump_search(struct cmd_context *cmd,
log_print("Searching for metadata in mda%d at offset %llu size %llu", mda_num,
(unsigned long long)mda_offset, (unsigned long long)mda_size);
- if (!(buf = malloc(mda_size)))
+ if (!(buf = zalloc(mda_size)))
return ECMD_FAILED;
- memset(buf, 0, mda_size);
if (!dev_read_bytes(dev, mda_offset, mda_size, buf)) {
log_print("CHECK: failed to read metadata area at offset %llu size %llu",
4 years, 5 months
master - cov: add explicit ret value ignoring
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=33c1d2e92137876116f...
Commit: 33c1d2e92137876116fd81cdca61874cc8e299c7
Parent: ad0343d8cb9644912961a72760df083378104078
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 17:11:01 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
cov: add explicit ret value ignoring
We don't need to check for any error result codes here.
---
lib/metadata/thin_manip.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c
index f947976..0704f2b 100644
--- a/lib/metadata/thin_manip.c
+++ b/lib/metadata/thin_manip.c
@@ -503,11 +503,11 @@ int update_pool_lv(struct logical_volume *lv, int activate)
* which Node has pool active.
*/
if (!activate_lv(lv->vg->cmd, lv)) {
- init_dmeventd_monitor(monitored);
+ (void) init_dmeventd_monitor(monitored);
return_0;
}
if (!lv_is_active(lv)) {
- init_dmeventd_monitor(monitored);
+ (void) init_dmeventd_monitor(monitored);
log_error("Cannot activate thin pool %s, perhaps skipped in lvm.conf volume_list?",
display_lvname(lv));
return 0;
4 years, 5 months
master - cov: more checks for failing syscalls
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=9ee3af7efc4bece8376...
Commit: 9ee3af7efc4bece83769a75586ffcb0f07a74d16
Parent: cbabdf2fca6131660cfb5525ed9edb3f7a41525a
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 16:56:12 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
cov: more checks for failing syscalls
---
daemons/dmeventd/dmeventd.c | 3 ++-
libdaemon/server/daemon-server.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c
index 33859ef..ae1e6a6 100644
--- a/daemons/dmeventd/dmeventd.c
+++ b/daemons/dmeventd/dmeventd.c
@@ -1745,7 +1745,8 @@ static void _init_thread_signals(void)
sigdelset(&my_sigset, SIGHUP);
sigdelset(&my_sigset, SIGQUIT);
- pthread_sigmask(SIG_BLOCK, &my_sigset, NULL);
+ if (pthread_sigmask(SIG_BLOCK, &my_sigset, NULL))
+ log_sys_error("pthread_sigmask", "SIG_BLOCK");
}
/*
diff --git a/libdaemon/server/daemon-server.c b/libdaemon/server/daemon-server.c
index 66e43d4..0368a94 100644
--- a/libdaemon/server/daemon-server.c
+++ b/libdaemon/server/daemon-server.c
@@ -656,7 +656,8 @@ void daemon_start(daemon_state s)
failed = 1; /* FD out of available selectable set */
sigfillset(&new_set);
- sigprocmask(SIG_SETMASK, NULL, &old_set);
+ if (sigprocmask(SIG_SETMASK, NULL, &old_set))
+ perror("sigprocmask error");
while (!failed) {
_reset_timeout(s);
4 years, 5 months
master - dmeventd: vdo plugin link lvm library
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=cbabdf2fca6131660cf...
Commit: cbabdf2fca6131660cfb5525ed9edb3f7a41525a
Parent: 1da5fd822665e385415ffdf4a0e43e46c6fd7ba5
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 16:52:05 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
dmeventd: vdo plugin link lvm library
Since we fixed linking of proper version of 'libdevmapper' with
linking lvm2 plugin correctly - we already have correct function
available linked with internal lvm library.
So drop unneeded include of parsing function.
---
daemons/dmeventd/plugins/vdo/dmeventd_vdo.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c b/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c
index 9d267eb..7c4ec47 100644
--- a/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c
+++ b/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c
@@ -16,9 +16,6 @@
#include "daemons/dmeventd/plugins/lvm2/dmeventd_lvm.h"
#include "daemons/dmeventd/libdevmapper-event.h"
-/* Use parser from new device_mapper library */
-#include "device_mapper/vdo/status.c"
-
#include <sys/wait.h>
#include <stdarg.h>
4 years, 5 months
master - cov: inline _build_desc_write
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=1da5fd822665e385415...
Commit: 1da5fd822665e385415ffdf4a0e43e46c6fd7ba5
Parent: 61a483a654d87fc514dd4e7570467797247b6031
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Nov 14 16:58:18 2019 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Nov 14 18:06:42 2019 +0100
cov: inline _build_desc_write
Embed function into the code, since the function is actually
simpler written this as there are no memleak troubles
with failing allocation error path.
---
lib/format_text/format-text.c | 31 ++++++-------------------------
1 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c
index f3536e7..2c2b7fa 100644
--- a/lib/format_text/format-text.c
+++ b/lib/format_text/format-text.c
@@ -531,29 +531,6 @@ static struct volume_group *_vg_read_precommit_raw(struct format_instance *fid,
return vg;
}
-#define MAX_DESC_LEN 2048
-
-static char *_build_desc_write(struct cmd_context *cmd, struct volume_group *vg)
-{
- size_t len = strlen(cmd->cmd_line) + 32;
- char *desc;
-
- if (len > MAX_DESC_LEN)
- len = MAX_DESC_LEN;
-
- if (!(desc = zalloc(len)))
- return_NULL;
-
- vg->write_count++;
-
- if (vg->write_count == 1)
- dm_snprintf(desc, len, "Write from %s.", cmd->cmd_line);
- else
- dm_snprintf(desc, len, "Write[%u] from %s.", vg->write_count, cmd->cmd_line);
-
- return desc;
-}
-
/*
* VG metadata updates:
*
@@ -598,6 +575,7 @@ static char *_build_desc_write(struct cmd_context *cmd, struct volume_group *vg)
static int _vg_write_raw(struct format_instance *fid, struct volume_group *vg,
struct metadata_area *mda)
{
+ char desc[2048];
struct mda_context *mdac = (struct mda_context *) mda->metadata_locn;
struct text_fid_context *fidtc = (struct text_fid_context *) fid->private;
struct raw_locn *rlocn_old;
@@ -672,12 +650,15 @@ static int _vg_write_raw(struct format_instance *fid, struct volume_group *vg,
write_buf_size = fidtc->write_buf_size;
new_size = fidtc->new_metadata_size;
} else {
- char *desc = _build_desc_write(fid->fmt->cmd, vg);
+ if (!vg->write_count++)
+ (void) dm_snprintf(desc, sizeof(desc), "Write from %s.", vg->cmd->cmd_line);
+ else
+ (void) dm_snprintf(desc, sizeof(desc), "Write[%u] from %s.", vg->write_count, vg->cmd->cmd_line);
+
new_size = text_vg_export_raw(vg, desc, &write_buf, &write_buf_size);
fidtc->write_buf = write_buf;
fidtc->write_buf_size = write_buf_size;
fidtc->new_metadata_size = new_size;
- free(desc);
}
if (!new_size || !write_buf) {
4 years, 5 months