v2_03_09 annotated tag has been created
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=21d1cf58071b07c598f...
Commit: 21d1cf58071b07c598f57de4f1adaf049a8e528b
Parent: 0000000000000000000000000000000000000000
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: 2020-03-26 11:22 +0000
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: 2020-03-26 11:22 +0000
annotated tag: v2_03_09 has been created
at 21d1cf58071b07c598f57de4f1adaf049a8e528b (tag)
tagging e1c2b4126520f05a5d2d515121e89263ec45a2bf (commit)
replaces v2_03_08
Release 2.03.09
- Fixed compilation errors with GCC 10.
- Fixed few writecache and pvck releated bugs.
- Fixed busy loop in dmeventd.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAABAgAGBQJefJFYAAoJELkRJDHlCQOfByAQAPm6Zhaaww/yoLXQDrP0F/jg
MWLHsKLa8QHiwCMDK56z1mXSFHVKJYW3XVEKn0CiyU6VNOwUNrQJesGlkq8ZdWjv
yfpSldDNUp8co9dL9uJYCcliWVh9yL0dhj358Phzb6Su4J6fRw6udyI8KSkbTD2F
Rlms4j3caIn7YR81OHu6aaKQzKDvohzI8uuydcjn+BRjgn8OOema6aWFFgt5dGPy
HZyexIcQZRROCmDDq4qQk1PJOF3iaLNpfUxA9moTzfV8q8CuqvCTjr83GRlkW+iD
ePIqfrkYTMlfYZpWgMhQg+QqAKAQubMggrP0cnuEA6ZA3gm6RplIz5yGtbu0EvK2
QWSzs/7w8iQKLbW14XrmIy+DHgF3zrkWl9398AHBHfdmuUQ5DD+7IMFa35Ok9ZX6
HMvQ7X2FuFNxHhj5EzTJpFnpbEzI2J80I17Xm97DuM/XsWoWJGltBvzNH2xJ9mM2
0qEuOcWCIZ0NAKhZOAGdyPmAX+2h7WqnhM8v1/EcHEdEOppFx3I1zo4zsmpgYK5J
IJiTqQco8sTIFA2kPBg0Jh4BIlkX7QmWR5yqPdkDAtoy6ZpXNeMx8mtM8WCsyF8r
r5pEEcCEbrTks63VqiydfhCnDoa6Lp71gewvcrkjdno64G83d5hbKVQsysgvWAfb
27+l0LxzBcmBKIEaC5e0
=1eeh
-----END PGP SIGNATURE-----
David Teigland (20):
writecache: check if cachevol is writable
thin: don't use writecache for poolmetadata
writecache: drop real dm suffix
writecache: working real dm uuid suffix for wcorig lv
writecache: fix watermark error message
writecache: allow removing wcorig lv
writecache: check watermark value
hints: free hint list in error exit path
pvck: ensure text lines are terminated
pvck: print longer command description
pvck: improve mda_offset mda_size choices
pvck: fix reading large mda1
pvck: allow dump from file
tests: pvck dump from larger metadata areas
tests: reduce sizes in pvck-dump and improve checks
pvck: use dm_config_parse_without_dup_node_check
writecache: require inactive LV to attach
lvmlockd: use transient LV lock when creating snapshot
man: lvm2-activation-generator fix vgchange comment
reduce device path error messsages
Jonathan Brassow (1):
man: lvmcache raid1 references
Marian Csontos (4):
post-release
test: Can not attach writecache to active volume
test: Fix previous commit
pre-release
Zdenek Kabelac (8):
cachevol: stop dm errors with uncaching cache with cachevol
vdo: fix slab size bits calculation
tests: validate vdo slab_size
dmeventd: enhance time waiting loop
libdm: fix dm_list pointer arithmentic for new gcc 10 optimization
container_of: use offsetof from stddef
WHATS_NEW_DM: update
vdo: make vdopool wrapping device is read-only
3 years, 8 months
master - post-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=06cbe3cfc6958b016d9...
Commit: 06cbe3cfc6958b016d97243b807aaf29b9908b23
Parent: e1c2b4126520f05a5d2d515121e89263ec45a2bf
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Thu Mar 26 12:22:09 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Thu Mar 26 12:22:09 2020 +0100
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index 8c4a9a8e0..0fc8da873 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.09(2) (2020-03-26)
+2.03.10(2)-git (2020-03-26)
diff --git a/VERSION_DM b/VERSION_DM
index 0ae62fd7e..c6a11602b 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.171 (2020-03-26)
+1.02.173-git (2020-03-26)
diff --git a/WHATS_NEW b/WHATS_NEW
index db914c073..bdeab78e4 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+Version 2.03.10 -
+=================================
+
Version 2.03.09 - 26th March 2020
=================================
Fix formating of vdopool (vdo_slab_size_mb was smaller by 2 bits).
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 12bdceac3..ef0461fad 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.173 -
+==================================
+
Version 1.02.171 - 26th March 2020
==================================
Fix dm_list interators with gcc 10 optimization (-ftree-pta).
3 years, 8 months
master - pre-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e1c2b4126520f05a5d2...
Commit: e1c2b4126520f05a5d2d515121e89263ec45a2bf
Parent: caff31df192bc4b06c8b0e9c75cbe93ff79581a5
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Thu Mar 26 12:21:16 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Thu Mar 26 12:21:16 2020 +0100
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 4 ++--
WHATS_NEW_DM | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/VERSION b/VERSION
index d19920bf8..8c4a9a8e0 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.09(2)-git (2020-02-11)
+2.03.09(2) (2020-03-26)
diff --git a/VERSION_DM b/VERSION_DM
index b3b975d24..0ae62fd7e 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.171-git (2020-02-11)
+1.02.171 (2020-03-26)
diff --git a/WHATS_NEW b/WHATS_NEW
index 664df6138..db914c073 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,5 @@
-Version 2.03.09 -
-====================================
+Version 2.03.09 - 26th March 2020
+=================================
Fix formating of vdopool (vdo_slab_size_mb was smaller by 2 bits).
Fix showing of a dm kernel error when uncaching a volume with cachevol.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 4cb0bd33b..12bdceac3 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.171 -
-=====================================
+Version 1.02.171 - 26th March 2020
+==================================
Fix dm_list interators with gcc 10 optimization (-ftree-pta).
Dmeventd handles timer without looping on short intervals.
3 years, 8 months
master - vdo: make vdopool wrapping device is read-only
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=caff31df192bc4b06c8...
Commit: caff31df192bc4b06c8b0e9c75cbe93ff79581a5
Parent: e6b93dc24e293bb06403f914ed5c03f9afa1a8ee
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Wed Mar 11 12:57:44 2020 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 23 17:13:26 2020 +0100
vdo: make vdopool wrapping device is read-only
When vdopool is activated standalone - we use a wrapping linear device
to hold actual vdo device active - for this we can set-up read-only
device to ensure there cannot be made write through this device to
actual pool device.
---
lib/activate/dev_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c
index 3b991319f..75d4df0e6 100644
--- a/lib/activate/dev_manager.c
+++ b/lib/activate/dev_manager.c
@@ -86,7 +86,7 @@ int read_only_lv(const struct logical_volume *lv, const struct lv_activate_opts
return 0; /* Keep RAID SubLvs writable */
if (!layer) {
- if (lv_is_thin_pool(lv))
+ if (lv_is_thin_pool(lv) || lv_is_vdo_pool(lv))
return 1;
}
3 years, 8 months
v2_02_187 annotated tag has been created
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=ff28294988a39072c59...
Commit: ff28294988a39072c59e0a3d3ab871b889c48959
Parent: 0000000000000000000000000000000000000000
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: 2020-03-24 18:24 +0000
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: 2020-03-24 18:24 +0000
annotated tag: v2_02_187 has been created
at ff28294988a39072c59e0a3d3ab871b889c48959 (tag)
tagging 84c239c4e59361bd279fd7fe33fff97399f0a1f7 (commit)
replaces v2_02_186
Release 2.02.187
Bug fix release.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAABAgAGBQJeelCvAAoJELkRJDHlCQOfQsoQAPI35RChB29ctF/V3S4Ahbu2
X5+KMGtw+/eb4Pc2e+OfWg9AGvnbQLm7BVpG61q10qzWVuHyGNMarqjuj5Y0xQTP
zjRpa6VwI/OPRFA/M5AEADiiRBzDySaio1tb/1HVUI9ZftiWGzdpX52hG/MxGIQr
imTHPoGs/7kX+Qh/DozHosYyxCEH0Mv131herpfRkVS4u0MBxnDNImZoqbAmvE9n
tRhjO8jSaeQG9GixqCtykTPrsO+8HszKV9zmk3m4vfmLlSTduQX8oNY27iOKc0wN
f3PKmQoKlzKdH/6d1D3Qg6ZptlfRWFq6GclKxmAGdw/7A2PNFwVeMvOo4jePMLBH
k5Xj29q8PSrKAQTVh0ljXaIrgF50w5IT+km3tH3J0v0hAc8Vqtsp7GRzXvPaPmAc
XtuAVnoSEpxJfIKpJsjeHHeAlGq1KmasONZdsWoo74XFScIEts/D6Fc5qSUIqFNE
97XCp2EZHa6cU85LsRa7ofb5bw4/+fsDGxN72Iii6Rbcvm3ihnMQ2/Ne4DS8uZr6
VFSDN2snpX5vLpXhJdLP8VHf50k3Pua4yUMYROuF8JZSkISxVaqT4265Go/nmJG0
33YDCGx4PmnRWbX3VAigxUku31gxR10thzlh/ldlcEHX14YYYqnWtNBL9oWAC0Ds
zFLYrdhUYCvJcuCcCHbL
=riIu
-----END PGP SIGNATURE-----
Bryn M. Reeves (1):
dmsetup: do not treat no groups as an error in dmstats list --group
David Teigland (16):
pvscan: fix activation of incomplete VGs
tests: add test for pvscan activation of incomplete vg
vgcreate/vgextend: restrict PVs with mixed block sizes
tests: allow-mixed-block-sizes
WHATS_NEW: vgcreate/vgextend logical block size
tests: allow-mixed-block-sizes skip with older losetup
lvmetad: fix sync cache to lvmetad
devs: check for no dev when dropping aliases
Revert "vgcreate/vgextend: restrict PVs with mixed block sizes"
tests: remove allow-mixed-block-sizes
Revert "Revert "vgcreate/vgextend: restrict PVs with mixed block sizes""
Revert "tests: remove allow-mixed-block-sizes"
config: allow_mixed_block_sizes set default to 1
config: allow_mixed_block_sizes set version 2.02.187
Fix rounding writes up to sector size
pvs: fix locking_type 4
Heinz Mauelshagen (9):
lvchange: add --resync help/manual text relative to 'R' attribute
Revert "dmeventd: avoid bail out preventing repair in raid plugin"
dmeventd: avoid bail out preventing repair in raid plugin but keep message
test: add checks for not 100% sync ratio after initiation of check/repair
test: add RAID lvextend resynchronization test
test: increase size of raid10 LV allowing tests to succeed on fast storage
WHATS_NEW: new lvextend-raid.sh test
man: adjust 'disks' to 'devices' as used throughout
lvcreate: ensure striped raid region size is at least stripe size
Heming Zhao (1):
fix dev_unset_last_byte after write error
Joe Thornber (9):
[radix-tree] Bring radix-tree up to date with the master branch
[bcache] Bring bcache into sync with master branch
[bcache] add bcache_abort()
[label] Use bcache_abort_fd() to ensure blocks are no longer in the cache.
[bcache] add unit test
[bcache] pass up the error from io_submit rather than using generic -EIO
[bcache] reverse earlier patch.
[bcache] bcache_invalidate_fd, only remove prefixes on success.
[radix-tree] Add missing test case
Marian Csontos (14):
post-release
cov: Fix memory leak
spec: Move blkdeactivate to device-mapper
lvmetad: Fix function prototype when not configured
build: make generate
spec: Fix lvm2-activation-generator man page handling
cov: Clarify the control flow
dm: Fix compilation of dmsetup
build: autoconf
WHATS_NEW: update
test: Fix handling leftovers from previous tests
base: Get Makefile from master
bcache: Fix memory leak in error path
pre-release
Mikulas Patocka (1):
dm: introduce DM_GET_TARGET_VERSION
Zdenek Kabelac (51):
lvconvert: improve validation thin and cache pool conversion
tests: pool conversion
devices: crypto skip
thin: activate layer pool aas read-only LV
pvmove: check if participating LV is already exlcusively active
lvmetad: fix timeout on shutdown
debug: drop some unneeded backtraces
pvmove: detect exclusively active LVs
debug: avoid to slashes in debug message
tests: really check disabling of lvmetad
snapshot: correctly check device id of merged thin
snapshot: fix checking of merged thin volume
snapshot: use single merging sequence
tests: explicit testing of thin snapshot
WHATS_NEW
tests: needs exclusive activation for conversion
mirror: fix leg splitting
mirror: directly activate updated mirror
mirror: remove unused code
manip: optimize lvs_using_lv
raid: drop internal error
tests: reduce space requirements
WHATS_NEW: update
tests: avoid checking command result in cluster
tests: conversion only of exclusive lv
tests: needs some raid
tests: skip test if scsi_debug is not available
tests: larger are needs to be disabled
tests: be happy with less then 90 percent
gcc: avoid declartion shadowing
cov: missing checks of syscalls
cov: ensure read_ahead is available
lvmcache: free resource on error path
daemon: better error path handling for shutdown
daemons: check for non-zero thread_id
tests: skip unneeded status check
tests: add extra settle
lvextend: fix resizing volumes of different segtype
tests: add test of resize of different segtypes
WHATS_NEW: update
tests: fix else path
raid: disallow reshape of stacked LVs
vdo: avoid running initialization of cache pool vars
WHATS_NEW: update
tests: writeerror_dev
tests: add corruption write on PV test
raid: more limitted prohibition of stacked raid usage
aux: writeerror_dev checks for delay target
tests: skip test when dm-delay is not available
tests: partial revert of test change of b6e6ea2d65785f03f3cee7938be635bcb8ad4944
raid: better place for blocking reshapes
wangjufeng (1):
lvmetad: fix heap memory leak
3 years, 8 months
stable-2.02 - post-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=2e3791b421a773b6377...
Commit: 2e3791b421a773b637705a3ca7a2ffc4efc8c873
Parent: 84c239c4e59361bd279fd7fe33fff97399f0a1f7
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 24 19:22:53 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 24 19:22:53 2020 +0100
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index 79026e7fc..60ed5750e 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.187(2) (2020-03-24)
+2.02.188(2)-git (2020-03-24)
diff --git a/VERSION_DM b/VERSION_DM
index a8e0ff99b..cf4dff740 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.170 (2020-03-24)
+1.02.172-git (2020-03-24)
diff --git a/WHATS_NEW b/WHATS_NEW
index 80d71ac77..cdc2396e6 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+Version 2.02.188 -
+==================================
+
Version 2.02.187 - 24th March 2020
==================================
Avoid running cache input arg validation when creating vdo pool.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 2b213bb2f..925be5a7b 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.172 -
+==================================
+
Version 1.02.170 - 24th March 2020
==================================
Add support for DM_DEVICE_GET_TARGET_VERSION.
3 years, 8 months
stable-2.02 - pre-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=84c239c4e59361bd279...
Commit: 84c239c4e59361bd279fd7fe33fff97399f0a1f7
Parent: 20d61a2553a160570835cad6790108fa2365b936
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 24 19:21:50 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 24 19:21:50 2020 +0100
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 4 ++--
WHATS_NEW_DM | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/VERSION b/VERSION
index f4c4e6820..79026e7fc 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.187(2)-git (2019-08-27)
+2.02.187(2) (2020-03-24)
diff --git a/VERSION_DM b/VERSION_DM
index bd0598af5..a8e0ff99b 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.166-git (2019-08-27)
+1.02.170 (2020-03-24)
diff --git a/WHATS_NEW b/WHATS_NEW
index c885a214d..80d71ac77 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,5 @@
-Version 2.02.187 -
-===================================
+Version 2.02.187 - 24th March 2020
+==================================
Avoid running cache input arg validation when creating vdo pool.
Prevent raid reshaping of stacked volumes.
Ensure minimum required region size on striped RaidLV creation.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 6a909c0a7..2b213bb2f 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.166 -
-===================================
+Version 1.02.170 - 24th March 2020
+==================================
Add support for DM_DEVICE_GET_TARGET_VERSION.
Version 1.02.164 - 27th August 2019
3 years, 8 months
master - test: Fix previous commit
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e6b93dc24e293bb0640...
Commit: e6b93dc24e293bb06403f914ed5c03f9afa1a8ee
Parent: fc32787c1b7f867008f30444a20ba154e0cdc39c
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Wed Mar 18 18:03:12 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Wed Mar 18 18:03:12 2020 +0100
test: Fix previous commit
---
test/shell/writecache.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/shell/writecache.sh b/test/shell/writecache.sh
index a7a2d9564..8852e93f4 100644
--- a/test/shell/writecache.sh
+++ b/test/shell/writecache.sh
@@ -160,11 +160,11 @@ mount "$DM_DEV_DIR/$vg/$lv1" $mount_dir
diff pattern1 $mount_dir/pattern1
diff pattern1 $mount_dir/pattern1.after
+fi
umount $mount_dir
lvchange -an $vg/$lv1
lvremove $vg/$lv1
-fi
vgremove -ff $vg
3 years, 8 months
master - test: Can not attach writecache to active volume
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fc32787c1b7f867008f...
Commit: fc32787c1b7f867008f30444a20ba154e0cdc39c
Parent: 957904933b2b0f94eddc6204ca2fa61e2df741a0
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Wed Mar 18 14:30:09 2020 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Wed Mar 18 14:35:58 2020 +0100
test: Can not attach writecache to active volume
---
test/shell/writecache.sh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/test/shell/writecache.sh b/test/shell/writecache.sh
index 0a7f694bb..a7a2d9564 100644
--- a/test/shell/writecache.sh
+++ b/test/shell/writecache.sh
@@ -139,8 +139,10 @@ mount "$DM_DEV_DIR/$vg/$lv1" $mount_dir
cp pattern1 $mount_dir/pattern1
ls -l $mount_dir
-lvconvert --yes --type writecache --cachevol $lv2 $vg/$lv1
+# TODO BZ 1808012 - can not convert active volume to writecache:
+not lvconvert --yes --type writecache --cachevol $lv2 $vg/$lv1
+if false; then
check lv_field $vg/$lv1 segtype writecache
lvs -a $vg/${lv2}_cvol --noheadings -o segtype >out
@@ -162,6 +164,7 @@ diff pattern1 $mount_dir/pattern1.after
umount $mount_dir
lvchange -an $vg/$lv1
lvremove $vg/$lv1
+fi
vgremove -ff $vg
3 years, 8 months
master - reduce device path error messsages
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=957904933b2b0f94edd...
Commit: 957904933b2b0f94eddc6204ca2fa61e2df741a0
Parent: fbdcc45255497e2f926ac28ba33aa819d53f5c7c
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Thu Mar 12 10:18:51 2020 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Thu Mar 12 10:18:51 2020 -0500
reduce device path error messsages
When /dev entries or sysfs entries are changing
due to concurrent lvm commands, it can cause
warning/error messages about missing paths.
---
lib/device/dev-cache.c | 9 +++++++--
lib/device/dev-io.c | 8 +++++---
lib/device/dev-type.c | 2 +-
3 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/lib/device/dev-cache.c b/lib/device/dev-cache.c
index e17b13f01..6af559cab 100644
--- a/lib/device/dev-cache.c
+++ b/lib/device/dev-cache.c
@@ -357,12 +357,14 @@ static int _get_sysfs_value(const char *path, char *buf, size_t buf_size, int er
int r = 0;
if (!(fp = fopen(path, "r"))) {
- log_sys_error("fopen", path);
+ if (error_if_no_value)
+ log_sys_error("fopen", path);
return 0;
}
if (!fgets(buf, buf_size, fp)) {
- log_sys_error("fgets", path);
+ if (error_if_no_value)
+ log_sys_error("fgets", path);
goto out;
}
@@ -1460,6 +1462,7 @@ struct device *dev_cache_get(struct cmd_context *cmd, const char *name, struct d
_insert(name, info_available ? &buf : NULL, 0, obtain_device_list_from_udev());
d = (struct device *) dm_hash_lookup(_cache.names, name);
if (!d) {
+ log_debug_devs("Device name not found in dev_cache repeat dev_cache_scan for %s", name);
dev_cache_scan();
d = (struct device *) dm_hash_lookup(_cache.names, name);
}
@@ -1535,6 +1538,8 @@ struct device *dev_cache_get_by_devt(struct cmd_context *cmd, dev_t dev, struct
}
}
+ log_debug_devs("Device num not found in dev_cache repeat dev_cache_scan for %d:%d",
+ (int)MAJOR(dev), (int)MINOR(dev));
dev_cache_scan();
d = _dev_cache_seek_devt(dev);
}
diff --git a/lib/device/dev-io.c b/lib/device/dev-io.c
index dd65c3d2e..735441f19 100644
--- a/lib/device/dev-io.c
+++ b/lib/device/dev-io.c
@@ -94,7 +94,7 @@ static int _dev_get_size_dev(struct device *dev, uint64_t *size)
}
if (fd <= 0) {
- if (!dev_open_readonly(dev))
+ if (!dev_open_readonly_quiet(dev))
return_0;
fd = dev_fd(dev);
do_close = 1;
@@ -128,8 +128,10 @@ static int _dev_read_ahead_dev(struct device *dev, uint32_t *read_ahead)
return 1;
}
- if (!dev_open_readonly(dev))
+ if (!dev_open_readonly_quiet(dev)) {
+ log_error("Failed to open to get readahead %s", dev_name(dev));
return_0;
+ }
if (ioctl(dev->fd, BLKRAGET, &read_ahead_long) < 0) {
log_sys_error("ioctl BLKRAGET", dev_name(dev));
@@ -194,7 +196,7 @@ int dev_get_direct_block_sizes(struct device *dev, unsigned int *physical_block_
}
if (fd <= 0) {
- if (!dev_open_readonly(dev))
+ if (!dev_open_readonly_quiet(dev))
return 0;
fd = dev_fd(dev);
do_close = 1;
diff --git a/lib/device/dev-type.c b/lib/device/dev-type.c
index fba4dc917..d225d4d90 100644
--- a/lib/device/dev-type.c
+++ b/lib/device/dev-type.c
@@ -86,7 +86,7 @@ int dev_is_lv(struct device *dev)
return 0;
if (!fgets(buffer, sizeof(buffer), fp))
- log_warn("Failed to read %s.", path);
+ log_debug("Failed to read %s.", path);
else if (!strncmp(buffer, "LVM-", 4))
ret = 1;
3 years, 9 months