Review Request 195: Hardware: Added System Memory Provider

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Hardware: Added System Memory Provider

Added new provider:
 * LMI_MemoryProvider


Diffs
-----

  mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
  src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
  src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
  src/hardware/LMI_MemoryProvider.c PRE-CREATION 
  src/hardware/LMI_ProcessorCacheMemoryProvider.c afc5d7f0488c506dddabd438f7af56578f464856

  src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
  src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
  src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
  src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
  src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
  src/hardware/procfs.h PRE-CREATION 
  src/hardware/procfs.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/


Testing
-------


Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review238
-----------------------------------------------------------



src/hardware/LMI_MemoryProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment144>

    It should be LMI:LMI_Memory:0, not :Memory:



src/hardware/dmidecode.h
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment145>

    These modules are only parsed, but they are never used. Is it something you're
going to work on in the future?



src/hardware/dmidecode.c
<http://reviewboard-openlmi.rhcloud.com/r/195/#comment143>

    What's purpose of this check? 'continue' has no effect here, the loop ends
after 'if' anyway.


- Jan Safranek


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/195/
>  -----------------------------------------------------------
>  
>  (Updated April 15, 2013, 7:02 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added System Memory Provider
>  
>  Added new provider:
>   * LMI_MemoryProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>    src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>    src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>    src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>    src/hardware/LMI_ProcessorCacheMemoryProvider.c
> afc5d7f0488c506dddabd438f7af56578f464856 
>    src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>    src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>    src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>    src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>    src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>    src/hardware/procfs.h PRE-CREATION 
>    src/hardware/procfs.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

>  On April 17, 2013, 10:52 a.m., Jan Safranek wrote:
>  > src/hardware/LMI_MemoryProvider.c, line 94
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/195/diff/1/?file=1161#file1161li...
>  >
>  >     It should be LMI:LMI_Memory:0, not :Memory: 
Ugh, I'm using this format in all LMI classes in Hardware.. I kind of chose it by
myself. Is there and guideline for that?


>  On April 17, 2013, 10:52 a.m., Jan Safranek wrote:
>  > src/hardware/dmidecode.h, lines 79-80
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/195/diff/1/?file=1166#file1166li...
>  >
>  >     These modules are only parsed, but they are never used. Is it something
> you're going to work on in the future? 
Yes, they will be used for LMI_PhysicalMemory classes, which will follow..


>  On April 17, 2013, 10:52 a.m., Jan Safranek wrote:
>  > src/hardware/dmidecode.c, lines 781-784
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/195/diff/1/?file=1167#file1167li...
>  >
>  >     What's purpose of this check? 'continue' has no effect here, the
> loop ends after 'if' anyway. 
Ah, sorry. This will also have effect only with the next patch, where I'll be parsing
more items from that output.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review238
-----------------------------------------------------------


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/195/
>  -----------------------------------------------------------
>  
>  (Updated April 15, 2013, 7:02 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added System Memory Provider
>  
>  Added new provider:
>   * LMI_MemoryProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>    src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>    src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>    src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>    src/hardware/LMI_ProcessorCacheMemoryProvider.c
> afc5d7f0488c506dddabd438f7af56578f464856 
>    src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>    src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>    src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>    src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>    src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>    src/hardware/procfs.h PRE-CREATION 
>    src/hardware/procfs.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

>  On April 17, 2013, 10:52 a.m., Jan Safranek wrote:
>  > src/hardware/LMI_MemoryProvider.c, line 94
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/195/diff/1/?file=1161#file1161li...
>  >
>  >     It should be LMI:LMI_Memory:0, not :Memory:
>  
>  Peter Schiffer wrote:
>      Ugh, I'm using this format in all LMI classes in Hardware.. I kind of chose it by
> myself. Is there and guideline for that? 
I'll rewrite InstanceID in Hardware to complain with the rest of providers in the next
patch.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review238
-----------------------------------------------------------


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/195/
>  -----------------------------------------------------------
>  
>  (Updated April 15, 2013, 7:02 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added System Memory Provider
>  
>  Added new provider:
>   * LMI_MemoryProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>    src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>    src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>    src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>    src/hardware/LMI_ProcessorCacheMemoryProvider.c
> afc5d7f0488c506dddabd438f7af56578f464856 
>    src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>    src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>    src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>    src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>    src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>    src/hardware/procfs.h PRE-CREATION 
>    src/hardware/procfs.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review239
-----------------------------------------------------------

Ship it!


Apart from the issues found, the code looks ok. Still, I would appreciate if someone else
looks at it and add another +1.

- Jan Safranek


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/195/
>  -----------------------------------------------------------
>  
>  (Updated April 15, 2013, 7:02 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added System Memory Provider
>  
>  Added new provider:
>   * LMI_MemoryProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>    src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>    src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>    src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>    src/hardware/LMI_ProcessorCacheMemoryProvider.c
> afc5d7f0488c506dddabd438f7af56578f464856 
>    src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>    src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>    src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>    src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>    src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>    src/hardware/procfs.h PRE-CREATION 
>    src/hardware/procfs.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/#review245
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 15, 2013, 7:02 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/195/
>  -----------------------------------------------------------
>  
>  (Updated April 15, 2013, 7:02 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added System Memory Provider
>  
>  Added new provider:
>   * LMI_MemoryProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
>    src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
>    src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
>    src/hardware/LMI_MemoryProvider.c PRE-CREATION 
>    src/hardware/LMI_ProcessorCacheMemoryProvider.c
> afc5d7f0488c506dddabd438f7af56578f464856 
>    src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
>    src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
>    src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
>    src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
>    src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
>    src/hardware/procfs.h PRE-CREATION 
>    src/hardware/procfs.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/195/
-----------------------------------------------------------

(Updated April 17, 2013, 3:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Hardware: Added System Memory Provider

Added new provider:
 * LMI_MemoryProvider


Diffs
-----

  mof/LMI_Hardware.mof 0964291c81b029d17d4945f9faead08e11005ff7 
  src/hardware/CMakeLists.txt 3949a8ad704581f5d0e9a88ac5fa369511a041ee 
  src/hardware/LMI_Hardware.h 1f30be648ec59f02a4d4ad67aea4a9c6a958d216 
  src/hardware/LMI_MemoryProvider.c PRE-CREATION 
  src/hardware/LMI_ProcessorCacheMemoryProvider.c afc5d7f0488c506dddabd438f7af56578f464856

  src/hardware/LMI_ProcessorProvider.c 99b0fad7d1e36efbb1e823d20cda74bf9b577235 
  src/hardware/cpuinfo.h 5ec5dd5083fe73548a434a3312c0a371c0c0d961 
  src/hardware/cpuinfo.c 6634b059df7d858654c862e88a705bbc574edef0 
  src/hardware/dmidecode.h 9190ea4ac26e82889b24184fc40072f007f9c836 
  src/hardware/dmidecode.c 348c7a23b76f42ab5dae78a86e42c69789a4e021 
  src/hardware/procfs.h PRE-CREATION 
  src/hardware/procfs.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/195/diff/


Testing
-------


Thanks,

Peter Schiffer