----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/#review563 -----------------------------------------------------------
mof/60_LMI_Account.mof http://reviewboard-openlmi.rhcloud.com/r/470/#comment326
Shouldn't parent class be CIM_InstDeletion?
src/account/CMakeLists.txt http://reviewboard-openlmi.rhcloud.com/r/470/#comment327
This looks like that include_directories and target_link_libraries are here twice. Why?
src/account/LMI_AccountInstanceCreationIndicationProvider.c http://reviewboard-openlmi.rhcloud.com/r/470/#comment328
The cast to (CMPIBroker *) shouldn't be required any more, im_create_manager now takes (const CMPIBroker *).
- Radek Novacek
On June 26, 2013, 4:42 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/
(Updated June 26, 2013, 4:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing
Thanks,
Roman Rakus
On June 27, 2013, 9:16 a.m., Radek Novacek wrote:
src/account/CMakeLists.txt, lines 42-50 http://reviewboard-openlmi.rhcloud.com/r/470/diff/1/?file=2747#file2747line42
This looks like that include_directories and target_link_libraries are here twice. Why?
In fact they are trice. I didn't know they can be in one.
- Roman
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/#review563 -----------------------------------------------------------
On June 26, 2013, 2:42 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/
(Updated June 26, 2013, 2:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/ -----------------------------------------------------------
(Updated June 28, 2013, 12:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs (updated) -----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/#review572 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On June 28, 2013, 2:39 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/
(Updated June 28, 2013, 2:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/ -----------------------------------------------------------
(Updated July 1, 2013, 9:33 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Indications for creation and deletion
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/LMI_AccountInstanceDeletionIndicationProvider.c PRE-CREATION src/account/indication_common.h PRE-CREATION src/account/indication_common.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/470/diff/
Testing -------
Thanks,
Roman Rakus
openlmi-reviews@lists.fedorahosted.org