Review Request 809: openlmi-tools [1/2] use NocaseDict instead of dict where appropriate
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/809/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
use NocaseDict instead of dict where appropriate
NocaseDict should be used for properties of instances, instance names
and output parameters of method to allow for case-insesitive
comparisons.
This fixes a bug, where job was not found in output parameters of
asynchronous method, when treating it as a synchronoush one.
Diffs
-----
cli/lmi/shell/LMIInstance.py 17646deedde5e39cd6dc129bae7b84d29c491a6e
cli/lmi/shell/LMIInstanceName.py b4dcc4235437923a392dd26262fdcdddc5db228d
cli/lmi/shell/LMIMethod.py a5bad8dfeb8047f60e6bcd4c7909fd4aa00d2106
cli/lmi/shell/LMIReturnValue.py 92030409b4159a60ad4fbc776f3835e96dcdf0fa
cli/lmi/shell/LMIUtil.py 9f34d21dba408a4a908495a68011c2faef35224b
Diff: http://reviewboard-openlmi.rhcloud.com/r/809/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 8 months
Review Request 690: [1/1] journald: Basic provider implementation
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/690/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Basic provider implementation
This is a fully functional basic implementation of the provider.
Maximum number of enumerated instances is limited, see the code.
Diffs
-----
CMakeLists.txt f150e4c77b3cf0475ff906b019da8bdcfab79676
mof/60_LMI_Journald.mof PRE-CREATION
src/CMakeLists.txt a9dc85d293b82805d4d956f1adbd212c873fd743
src/journald/CMakeLists.txt PRE-CREATION
src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION
src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION
src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION
src/journald/README PRE-CREATION
src/journald/TODO PRE-CREATION
src/journald/cmpiLMI_Journald-cimprovagt PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/journal.h PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/690/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 8 months
Review Request 734: journald: Use lmi logging infrastructure for error messages
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Use lmi logging infrastructure for error messages
--
This is an addendum to review #731
Diffs
-----
src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION
src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION
src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION
src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/journal.h PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 8 months
Review Request 731: journald: Add indications
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/731/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
journald: Add indications
Also contains simple test suite to test indications.
Still contains some TODOs as there's a copy-pasted code that could live in a shared place.
Diffs
-----
mof/60_LMI_Journald.mof PRE-CREATION
src/journald/CMakeLists.txt PRE-CREATION
src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION
src/journald/instutil.h PRE-CREATION
src/journald/instutil.c PRE-CREATION
src/journald/test/TestIndications.py PRE-CREATION
src/journald/test/common.py PRE-CREATION
src/journald/test/localtest.sh PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/731/diff/
Testing
-------
Thanks,
Tomáš Bžatek
10 years, 8 months