Re: Review Request 1759: Add event-based tests for indications (basic set)

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1759/#review2685
-----------------------------------------------------------

Ship it!


After long time trying to understand relations between test classes it finally makes sense
to me. This set is simple and I have no objections against it.

It fails on my machine however, I'm trying to figure out what's wrong at the
moment (likely a race condition somewhere in the provider).

- Tomáš Bžatek


On Kvě. 21, 2014, 3:22 odp., Alois Mahdal wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1759/
>  -----------------------------------------------------------
>  
>  (Updated Kvě. 21, 2014, 3:22 odp.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Basic set of tests with focus on this flow:
>  
>    1. add set of subscriptions
>    2. add set of handlers
>    3. trigger sequence of "interesting" events
>    4. collect indications
>    5. and make assertions as needed
>  
>  Currently the assertions are mostly that correct classes have been
>  delivered, reporting the events in correct order.
>  
>  ~~
>  
>  This is followup to request #1741.
>  
>  Since then:
>  
>   *  Rewrote old and added missing docstrings
>   *  `TestIndicationEventStream` now inherits from
>      `IndicationStreamTestCase` instead using it as mixin
>   *  fixed typos
>   *  removed unnecessary CLASS_NAME and NEEDS_INDICATIONS
>   *  made `handlers` option explicit instead of using
>      `default_driver_args`
>   *  fixed `xtest*` typos
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestIndicationEventStream.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1759/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Alois Mahdal
>  
>