----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/#review1084 -----------------------------------------------------------
src/account/lock.h http://reviewboard-openlmi.rhcloud.com/r/795/#comment609
I know where the "32" comes from but looking just at the header file it's not that obvious -- try to avoid the magic numbers: give them some name, especially if the same number must be used also somewhere else in the code.
#define USERNAME_LEN_MAX 32
...and use the macro instead.
src/account/lock.c http://reviewboard-openlmi.rhcloud.com/r/795/#comment610
Hm... Maybe I have overlooked something but why isn't new_pool actually defined here?
- Tomas Smetana
On Sept. 2, 2013, 11:50 a.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/
(Updated Sept. 2, 2013, 11:50 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Missing files included.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/LMI_AccountProvider.c 5abad7261331c429de0503b8bfb9f8fc180141cf src/account/lock.h PRE-CREATION src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/795/diff/
Testing
Thanks,
Robin Hack