On Sept. 2, 2013, 12:32 p.m., Robin Hack wrote:
Also, please use whitespaces consistently. That means write strcmp(something, here) instead of strcmp ( something, here ).
Jan Synacek wrote: One more thing, you should also probably respect the if structure indentation used in the provider. It uses the gnu style if () { /* code here */ }
Jan Safranek wrote: Well, I would rather rewrite the account provider to adapt to rest of the providers, see https://fedorahosted.org/openlmi/wiki/CodingConventions
Yes, that would be ideal.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/#review1043 -----------------------------------------------------------
On Sept. 2, 2013, 11:50 a.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/
(Updated Sept. 2, 2013, 11:50 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Missing files included.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/LMI_AccountProvider.c 5abad7261331c429de0503b8bfb9f8fc180141cf src/account/lock.h PRE-CREATION src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/795/diff/
Testing
Thanks,
Robin Hack