-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/#review1032
-----------------------------------------------------------
Ship it!
IMHO no further review needed, just one minor issue.
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py
<
http://reviewboard-openlmi.rhcloud.com/r/583/#comment564>
Please check that you're closing LUKSDevice, otherwise you may remove a RAID or
something similar... You never know what happens between cim_method_closeencryptionformat
and _close_encryption_format.
- Jan Safranek
On Aug. 30, 2013, 9:52 a.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/583/
-----------------------------------------------------------
(Updated Aug. 30, 2013, 9:52 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Add LUKS version 1.
Only LMI_LUKSFormat and LMI_ExtentEncryptionConfigurationService are
implemented. Howerever, these two classes add most of the LUKS
functionality. Setting and Capability classes were omitted.
Diffs
-----
mof/LMI_Storage-Luks.mof 3b7ba8e4fd000acdb1cf4232b8ec18120c4a5029
mof/LMI_Storage-MethodParameters.mof 42051181aa2d78bd84c9ec7274bea1b75ef9de04
mof/LMI_Storage.reg cf690b166800bd3e4d15da506d86e60777215080
src/lmi/storage/FormatProvider.py 79c61fa08688db3d1c636fdd7c36a6c518d74255
src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py PRE-CREATION
src/lmi/storage/LMI_LUKSFormat.py PRE-CREATION
src/lmi/storage/LMI_LUKSStorageExtent.py PRE-CREATION
src/lmi/storage/LMI_StorageExtent.py 9aa4a0586a12de70859af64e9ee767df1aa40b0c
src/lmi/storage/ProviderManager.py 3885c7d255694e659b9ccfa0de93550639b26897
src/lmi/storage/cimom_entry.py 0ba9e25ae88d5bde37dd222049676009c7cdfdc1
Diff:
http://reviewboard-openlmi.rhcloud.com/r/583/diff/
Testing
-------
Thanks,
Jan Synacek