Re: Review Request 849: Hardware: Move PCI bus initialization to the Initialize() function

[Stephen Gallagher]

>  On Sept. 11, 2013, 8:14 a.m., Michal Minar wrote:
>  > src/hardware/LMI_PCIBridgeProvider.c, line 31
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/849/diff/1/?file=4653#file4653li...
>  >
>  >     This could be a shared variable for all hw providers. Initialized when the first
> provider is instantiated and freed when the last one is cleaned up.
>  >     
>  >     Although it would need a mutex as a guard. 
I'm not sure if this is worth the effort..


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/849/#review1153
-----------------------------------------------------------


On Sept. 24, 2013, 3:58 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/849/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 24, 2013, 3:58 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Move PCI bus initialization to the Initialize() function
>  
>  Move initialize and cleanup code to the Initialize() and Cleanup() functions.
>  
>  
>  Diffs
>  -----
>  
>    src/hardware/LMI_PCIBridgeProvider.c 33927728a856314cc2ad7b7df1222334fb15841a 
>    src/hardware/LMI_PCIBridgeSystemDeviceProvider.c
> 2151dd56a63240503ef966d198702d41dc3954c9 
>    src/hardware/LMI_PCIDeviceProvider.c cc6adc815c4ced422fc17c8fa8080039d9096eaf 
>    src/hardware/LMI_PCIDeviceSystemDeviceProvider.c
> 897f7bcad840512c82dacc95cba81c9728942990 
>    src/hardware/PCIDev.h 7e4cf0d96cc50a962f7c136ea72d336f77ceaa78 
>    src/hardware/PCIDev.c 40051b30bc59dba7f3b488fdc92e05c51e2cbe82 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/849/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>