On Sept. 30, 2013, 11:54 a.m., Radek Novacek wrote:
> src/account/LMI_GroupProvider.c, line 148
>
<
http://reviewboard-openlmi.rhcloud.com/r/897/diff/1/?file=4983#file4983li...
>
> Wouldn't it be better to return CMPIStatus - it contains both RC and error
string?
I don't see any gain here...
- Roman
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/897/#review1253
-----------------------------------------------------------
On Sept. 30, 2013, 12:18 p.m., Roman Rakus wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/897/
-----------------------------------------------------------
(Updated Sept. 30, 2013, 12:18 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Add DeleteGroup method to be consistent with user's deletion
User deletetion is done by DeleteUser method. Added similar method
to delete a group.
Also do the check if the group isn't a primary group of a user.
Changed documentation accordingly.
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
mof/60_LMI_Account.mof 153222eb477a1e782cb3031507f629e5b5e90d98
src/account/LMI_GroupProvider.c 6e64c2165b5653d00a0ef83312be22658da73514
src/account/doc/source/usage.rst ee88d4045b4a3ad041028ef292fd21479311819d
Diff:
http://reviewboard-openlmi.rhcloud.com/r/897/diff/
Testing
-------
Thanks,
Roman Rakus