Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_save

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Fix migration to lmi_get_system_name_save

There were a lot of methods that were not fixed correctly, the required
CMPIContext instance was not passed everywhere causing the provider to
crash. This change fixes the issue and adds CMPIContext everywhere
consistently.


Diffs
-----

  src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
  src/LMI_EndpointForIPNetworkConnectionProvider.c
60fed0e5b975672fa64460d681bdd7fbd3212afd 
  src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
  src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15

  src/LMI_IPConfigurationServiceAffectsElementProvider.c
a88e88927b1c4470e10f0a4d90f4227135253c13 
  src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
  src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039 
  src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
  src/LMI_LinkAggregationConcreteIdentityProvider.c
efe0ed5b838ead9424bc930e524ed6129d4bc88f 
  src/LMI_NetworkDeviceSAPImplementationProvider.c
cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
  src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
  src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
  src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
  src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
  src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e

  src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
  src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/


Testing
-------


Thanks,

Radek Novacek

Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_safe

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 3:24 p.m.)


Review request for OpenLMI Developers.


Summary (updated)
-----------------

networking [1/1] Fix migration to lmi_get_system_name_safe


Repository: openlmi-networking


Description (updated)
-------

Fix migration to lmi_get_system_name_safe

There were a lot of methods that were not fixed correctly, the required
CMPIContext instance was not passed everywhere causing the provider to
crash. This change fixes the issue and adds CMPIContext everywhere
consistently.


Diffs
-----

  src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
  src/LMI_EndpointForIPNetworkConnectionProvider.c
60fed0e5b975672fa64460d681bdd7fbd3212afd 
  src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
  src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15

  src/LMI_IPConfigurationServiceAffectsElementProvider.c
a88e88927b1c4470e10f0a4d90f4227135253c13 
  src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
  src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039 
  src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
  src/LMI_LinkAggregationConcreteIdentityProvider.c
efe0ed5b838ead9424bc930e524ed6129d4bc88f 
  src/LMI_NetworkDeviceSAPImplementationProvider.c
cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
  src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
  src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
  src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
  src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
  src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e

  src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
  src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/


Testing
-------


Thanks,

Radek Novacek

Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_safe

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/#review3253
-----------------------------------------------------------


Autoscan started for review(s) 1985[1]

- scanbot


On Aug. 28, 2014, 1:24 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1985/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 28, 2014, 1:24 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Fix migration to lmi_get_system_name_safe
>  
>  There were a lot of methods that were not fixed correctly, the required
>  CMPIContext instance was not passed everywhere causing the provider to
>  crash. This change fixes the issue and adds CMPIContext everywhere
>  consistently.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
>    src/LMI_EndpointForIPNetworkConnectionProvider.c
> 60fed0e5b975672fa64460d681bdd7fbd3212afd 
>    src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
>    src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15
>
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> a88e88927b1c4470e10f0a4d90f4227135253c13 
>    src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
>    src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039
>
>    src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
>    src/LMI_LinkAggregationConcreteIdentityProvider.c
> efe0ed5b838ead9424bc930e524ed6129d4bc88f 
>    src/LMI_NetworkDeviceSAPImplementationProvider.c
> cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
>    src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
>    src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
>    src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
>    src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
>    src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e
>
>    src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
>    src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_safe

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/#review3255
-----------------------------------------------------------


Autoscan failed: FAILED
This can indicate any failure like broken buildroot to patch failed to apply. Manual
investigation of scan log is needed.
Scanned reviews: 1985

- scanbot


On Aug. 28, 2014, 1:24 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1985/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 28, 2014, 1:24 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Fix migration to lmi_get_system_name_safe
>  
>  There were a lot of methods that were not fixed correctly, the required
>  CMPIContext instance was not passed everywhere causing the provider to
>  crash. This change fixes the issue and adds CMPIContext everywhere
>  consistently.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
>    src/LMI_EndpointForIPNetworkConnectionProvider.c
> 60fed0e5b975672fa64460d681bdd7fbd3212afd 
>    src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
>    src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15
>
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> a88e88927b1c4470e10f0a4d90f4227135253c13 
>    src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
>    src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039
>
>    src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
>    src/LMI_LinkAggregationConcreteIdentityProvider.c
> efe0ed5b838ead9424bc930e524ed6129d4bc88f 
>    src/LMI_NetworkDeviceSAPImplementationProvider.c
> cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
>    src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
>    src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
>    src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
>    src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
>    src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e
>
>    src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
>    src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_safe

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/#review3266
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Synacek


On Aug. 28, 2014, 3:24 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1985/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 28, 2014, 3:24 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Fix migration to lmi_get_system_name_safe
>  
>  There were a lot of methods that were not fixed correctly, the required
>  CMPIContext instance was not passed everywhere causing the provider to
>  crash. This change fixes the issue and adds CMPIContext everywhere
>  consistently.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
>    src/LMI_EndpointForIPNetworkConnectionProvider.c
> 60fed0e5b975672fa64460d681bdd7fbd3212afd 
>    src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
>    src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15
>
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> a88e88927b1c4470e10f0a4d90f4227135253c13 
>    src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
>    src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039
>
>    src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
>    src/LMI_LinkAggregationConcreteIdentityProvider.c
> efe0ed5b838ead9424bc930e524ed6129d4bc88f 
>    src/LMI_NetworkDeviceSAPImplementationProvider.c
> cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
>    src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
>    src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
>    src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
>    src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
>    src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e
>
>    src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
>    src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

Review Request 1985: networking [1/1] Fix migration to lmi_get_system_name_safe

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1985/
-----------------------------------------------------------

(Updated Aug. 29, 2014, 8:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Fix migration to lmi_get_system_name_safe

There were a lot of methods that were not fixed correctly, the required
CMPIContext instance was not passed everywhere causing the provider to
crash. This change fixes the issue and adds CMPIContext everywhere
consistently.


Diffs
-----

  src/LMI_BindsToLANEndpointProvider.c f710de823d9b300f7563a1e4f267735b9c048889 
  src/LMI_EndpointForIPNetworkConnectionProvider.c
60fed0e5b975672fa64460d681bdd7fbd3212afd 
  src/LMI_EndpointIdentityProvider.c e4476b5c8db5ad21d9e879c5d0a62c465ecf14dc 
  src/LMI_HostedIPConfigurationServiceProvider.c 2ee6926c7425246d5558e45f23b6efef75f33c15

  src/LMI_IPConfigurationServiceAffectsElementProvider.c
a88e88927b1c4470e10f0a4d90f4227135253c13 
  src/LMI_IPElementSettingDataProvider.c 3bbe61a4350477162e80eed53979ae608c9718d1 
  src/LMI_IPVersionElementSettingDataProvider.c 9cda2bb043e55c4108d11d848f72c6f5e0476039 
  src/LMI_LinkAggregationBindsToProvider.c 17a4d52fb4533e6a60094c4ef62d836cbe3c97d5 
  src/LMI_LinkAggregationConcreteIdentityProvider.c
efe0ed5b838ead9424bc930e524ed6129d4bc88f 
  src/LMI_NetworkDeviceSAPImplementationProvider.c
cbb6ace4aaf29de47746ad1ed13fc11dce9dd7de 
  src/LMI_NetworkElementCapabilitiesProvider.c fe1f55471d87b2838520fbd476ee252eda3147f6 
  src/LMI_NetworkHostedAccessPointProvider.c 7ef00986bb2c6ddd5c2226256edbe262a34a1234 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
38bdf2e6f41db9c7cad81dccb6b7935bbefcb9d0 
  src/LMI_NetworkSAPSAPDependencyProvider.c bfb64067ab7c8507e122d3c1d7f7a1fb43935628 
  src/LMI_NetworkSystemDeviceProvider.c 6069d3c5f88b20f9f843a6ba064eab47e19f15ef 
  src/LMI_OrderedIPAssignmentComponentProvider.c 5e14966e760f1b4a14da9d5665a5fb47a811bd5e

  src/ref_factory.h c1f0a7590aa730923c06823d14296d4a700b2a2a 
  src/ref_factory.c 7ddf719063a84b7fe9ad52a9a42f15cc979dc9e3 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1985/diff/


Testing
-------


Thanks,

Radek Novacek