Review Request 695: openlmi-software [1/4] software: let's not presume, that any url is associated with repo

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/695/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

software: let's not presume, that any url is associated with repo

Fixed UnboundLocalError, when expecting, that at least mirror_list
or some base_url of repository is available.


Diffs
-----

  src/software/lmi/software/core/IdentityResource.py
0853442c2ed402861ed0843bbe3845867a3472b5 

Diff: http://reviewboard-openlmi.rhcloud.com/r/695/diff/


Testing
-------


Thanks,

Michal Minar

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/695/#review887
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On Aug. 8, 2013, 12:58 p.m., Michal Minar wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/695/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 8, 2013, 12:58 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  software: let's not presume, that any url is associated with repo
>  
>  Fixed UnboundLocalError, when expecting, that at least mirror_list
>  or some base_url of repository is available.
>  
>  
>  Diffs
>  -----
>  
>    src/software/lmi/software/core/IdentityResource.py
> 0853442c2ed402861ed0843bbe3845867a3472b5 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/695/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Michal Minar
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/695/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 11:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

software: let's not presume, that any url is associated with repo

Fixed UnboundLocalError, when expecting, that at least mirror_list
or some base_url of repository is available.


Diffs
-----

  src/software/lmi/software/core/IdentityResource.py
0853442c2ed402861ed0843bbe3845867a3472b5 

Diff: http://reviewboard-openlmi.rhcloud.com/r/695/diff/


Testing
-------


Thanks,

Michal Minar