----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of __MethodParameters_<method_name>_Result class which derives from __MethodParameters_<method_name> class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs -----
cli/lmi/shell/LMIMethod.py 97b8cb66066ec968c0b05e72de0e7074482abdcb
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/#review3063 -----------------------------------------------------------
Looks sane to me.
- Jan Synacek
On July 14, 2014, 9:37 a.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/
(Updated July 14, 2014, 9:37 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of __MethodParameters_<method_name>_Result class which derives from __MethodParameters_<method_name> class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs
cli/lmi/shell/LMIMethod.py 97b8cb66066ec968c0b05e72de0e7074482abdcb
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/#review3134 -----------------------------------------------------------
cli/lmi/shell/LMIMethod.py http://reviewboard-openlmi.rhcloud.com/r/1896/#comment1751
I am OK with the code; but please, don't use this style of indenting.
- Peter Hatina
On July 14, 2014, 7:37 a.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/
(Updated July 14, 2014, 7:37 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of __MethodParameters_<method_name>_Result class which derives from __MethodParameters_<method_name> class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs
cli/lmi/shell/LMIMethod.py 97b8cb66066ec968c0b05e72de0e7074482abdcb
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/ -----------------------------------------------------------
(Updated Srp. 21, 2014, 1:16 odp.)
Review request for OpenLMI Developers.
Changes -------
Rebased on top of recent master.
Got rid of pretty cool haskell-like indenting.
Summary (updated) -----------------
shell: better handle job output parameters
Repository: openlmi-tools
Description (updated) -------
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of `__MethodParameters_<method_name>_Result` class which derives from `__MethodParameters_<method_name>` class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs (updated) -----
cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/#review3241 -----------------------------------------------------------
Ship it!
Ship It!
- Peter Hatina
On Aug. 21, 2014, 1:16 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/
(Updated Aug. 21, 2014, 1:16 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of `__MethodParameters_<method_name>_Result` class which derives from `__MethodParameters_<method_name>` class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs
cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1896/ -----------------------------------------------------------
(Updated Srp. 21, 2014, 1:38 odp.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters property of job instance is something else then it should be. It's an instance of `__MethodParameters_<method_name>_Result` class which derives from `__MethodParameters_<method_name>` class. The latter contains input parameters of asynchronous method. Therefor JobOutParameters may contain input parameters as well. Let's filter them out because this may confuse client scripts.
Diffs -----
cli/lmi/shell/LMIMethod.py 885f251e4dd64de5261f32e7c538f02a0c55fd17
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing -------
Thanks,
Michal Minar
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher