Review Request 854: [1/1] Account: Added QA test for account provider.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1161
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment693>

    What happened, when delete instance will fail and user remain in system?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment694>

    What happened when group deletion over lmi will fail?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment695>

    Whitespaces.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment696>

    This should be part of tearDown()/cleanup phase which will be independend to lmi.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment697>

    LMI independent code in cleanup phase please.


- Robin Hack


On Sept. 12, 2013, 9:33 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 12, 2013, 9:33 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 7:49 a.m.)


Review request for OpenLMI Developers.


Changes
-------

Fixed bugs.


Summary (updated)
-----------------

[1/1] Account: Added QA test for account provider.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1167
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment704>

    Don't use lmi related code to cleanup.
    Instead please use function from methods.py which is included in upstream account
provider test tree.
    Use methods like:
    clean_account, 



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment707>

    Whitespace on the end of line.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment705>

    Whitespace on the end.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment706>

    Why is user initialized to None and then replaced by instance?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment708>

    Why is there group initialized by None value and then replaced by instance?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment709>

    Use hash for instance filters.
    If this not work, please fill bug or add bug to comment.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment710>

    Why is there double cleaning?
    One in the code (using methods from methods.py) and one in tearDown method (still
using openlmi related code).


- Robin Hack


On Sept. 13, 2013, 7:49 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 13, 2013, 7:49 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 10:44 a.m.)


Review request for OpenLMI Developers.


Changes
-------

Changes from psklenar.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 
  src/software/lmi/software/yumdb/__init__.py 6992c29087b7575d312a7c1711afb1d208b06727 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 10:46 a.m.)


Review request for OpenLMI Developers.


Changes
-------

Fixed review. Changes from psklenar.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/software/lmi/software/yumdb/__init__.py 6992c29087b7575d312a7c1711afb1d208b06727 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 10:47 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 
  src/software/lmi/software/yumdb/__init__.py 6992c29087b7575d312a7c1711afb1d208b06727 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 10:49 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1169
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment712>

    This is cleanup?
    If yes, don't use lmi related code.
    We need clean system after test.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment713>

    I know that is only theoretical, but what will happen, when creating doesn't
fail?
    Cleanup?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment714>

    I know that is only theoretical, but what will happen, when creating doesn't
fail?
    Cleanup?


- Robin Hack


On Sept. 13, 2013, 10:49 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 13, 2013, 10:49 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1171
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment718>

    why is user initialized with lams and then replaced with Account instance?
    Is this part of reproducer?


- Robin Hack


On Sept. 13, 2013, 10:49 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 13, 2013, 10:49 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 13, 2013, 12:41 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1173
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment722>

    Double initialization of user AGAIN!



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment720>

    Why us user initialized two times?



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment721>

    Where is cleanup?
    I know about tearDown method but i what i miss is some: self.user =
    
    Maybe self.user should be self.users and should be list of users which you want to
delete.


- Robin Hack


On Sept. 13, 2013, 12:41 p.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 13, 2013, 12:41 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1174
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment723>

    User really exists? Where is some check?


- Robin Hack


On Sept. 13, 2013, 12:41 p.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 13, 2013, 12:41 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 7:27 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1178
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment728>

    User really exists after this call?
    Assert missing.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment729>

    We need separate test case for deleteing user and group... because we need map this
cases to tcms when test will be parametrized.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment730>

    What is this magic numbers?


- Robin Hack


On Sept. 16, 2013, 7:27 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 16, 2013, 7:27 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Sept. 16, 2013, 8:57 a.m.)


Review request for OpenLMI Developers.


Changes
-------

Qa test from psklenar.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs (updated)
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/#review1179
-----------------------------------------------------------



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment734>

    Magic numbers.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment732>

    Test for the inverse set of characters would be nice. This asserts, that *one char*
usernames are accepted.



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment731>

    These magic numbers are not well readable. Maybe you could use something like:
    badchar = [chr(i) for i in xrange(0, 128) if chr(i) not in set(string.ascii_letters +
string.digits + '$_')]



src/account/test/testAccount.py
<http://reviewboard-openlmi.rhcloud.com/r/854/#comment733>

    If an assertion fails, examiner has to test each character from the badchar set until
he finds out, which one caused it. I'd recommend add some description string like:
    self.assertEqual(user.rval, -1, 'account with invalid username "%s"
created')


- Michal Minar


On Sept. 16, 2013, 8:57 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/854/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 16, 2013, 8:57 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Added QA test for account provider.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/testAccount.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/854/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 1:43 p.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Added QA test for account provider.


Diffs
-----

  src/account/test/testAccount.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/854/diff/


Testing
-------


Thanks,

Robin Hack