Review Request 830: completion [1/1] Completion: bash completion for lmi shell

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/
-----------------------------------------------------------

Review request for OpenLMI Developers.

Repository: openlmi-tools

Description
-------

Completion: bash completion for lmi shell

It allow to complete:
- LMI Shell options (short and long)
- files with .lmi extension
- directories

Signed-off-by: Roman Rakus

Diffs
-----

cli/completion/lmishell.bash PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/

Testing
-------

This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.

Thanks,

Roman Rakus

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1102
-----------------------------------------------------------

How to test tips:
In separate shell (open new terminal) source the script and play with the tab completion of lmishell.
1) open new terminal
2) . path/to/lmishell.bash
3) lmishell <tab>...

- Roman Rakus

On Sept. 6, 2013, 10:31 a.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 6, 2013, 10:31 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1110
-----------------------------------------------------------

cli/completion/lmishell.bash
http://reviewboard-openlmi.rhcloud.com/r/830/#comment625

s/interactive/interact/

cli/completion/lmishell.bash
http://reviewboard-openlmi.rhcloud.com/r/830/#comment626

Shouldn't *.py files complete as well?

- Michal Minar

On Sept. 6, 2013, 10:31 a.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 6, 2013, 10:31 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

> On Sept. 9, 2013, 6:57 a.m., Michal Minar wrote:
> > cli/completion/lmishell.bash, line 26
> > http://reviewboard-openlmi.rhcloud.com/r/830/diff/1/?file=4508#file4508line26
> > s/interactive/interact/

oh... good catch
> On Sept. 9, 2013, 6:57 a.m., Michal Minar wrote:
> > cli/completion/lmishell.bash, line 36
> > http://reviewboard-openlmi.rhcloud.com/r/830/diff/1/?file=4508#file4508line36
> > Shouldn't *.py files complete as well?

That's a question. Not a problem to add it. What others think about it?

- Roman

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1110
-----------------------------------------------------------

On Sept. 6, 2013, 10:31 a.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 6, 2013, 10:31 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

> On Sept. 9, 2013, 8:57 a.m., Michal Minar wrote:
> > cli/completion/lmishell.bash, line 36
> > http://reviewboard-openlmi.rhcloud.com/r/830/diff/1/?file=4508#file4508line36
> > Shouldn't *.py files complete as well?
>
> Roman Rakus wrote:
>     That's a question. Not a problem to add it. What others think about it?

Well, not everybody appends .lmi to the scripts. Maybe we should enforce it, if the scripts are to be run through lmishell. On the other hand, lmi scripts are simply python, even though they usually don't work without lmishell.

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1110
-----------------------------------------------------------

On Sept. 6, 2013, 12:31 p.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 6, 2013, 12:31 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

> On Sept. 9, 2013, 6:57 a.m., Michal Minar wrote:
> > cli/completion/lmishell.bash, line 36
> > http://reviewboard-openlmi.rhcloud.com/r/830/diff/1/?file=4508#file4508line36
> > Shouldn't *.py files complete as well?
>
> Roman Rakus wrote:
>     That's a question. Not a problem to add it. What others think about it?
>
> Jan Synacek wrote:
>     Well, not everybody appends .lmi to the scripts. Maybe we should enforce it, if the scripts are to be run through lmishell. On the other hand, lmi scripts are simply python, even though they usually don't work without lmishell.

At least we should document it.

- Roman

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1110
-----------------------------------------------------------

On Sept. 9, 2013, 11:16 a.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 9, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 11:16 a.m.)

Review request for OpenLMI Developers.

Changes
-------

Added .py extension and fixed typo.

Repository: openlmi-tools

Description
-------

Completion: bash completion for lmi shell

It allow to complete:
- LMI Shell options (short and long)
- files with .lmi extension
- directories

Signed-off-by: Roman Rakus

Diffs (updated)
-----

cli/completion/lmishell.bash PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/

Testing
-------

This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.

Thanks,

Roman Rakus

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/#review1121
-----------------------------------------------------------

Ship it!

Ship It!

- Michal Minar

On Sept. 9, 2013, 11:16 a.m., Roman Rakus wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/830/
>
> (Updated Sept. 9, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-tools
> Description
>
> Completion: bash completion for lmi shell
>
> It allow to complete:
> LMI Shell options (short and long)
> files with .lmi extension
> directories
>
> Signed-off-by: Roman Rakus
> Diffs
>
> cli/completion/lmishell.bash PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/
> Testing
>
> This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.
>
> Thanks,
>
> Roman Rakus

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/830/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 12:49 p.m.)

Status
------

This change has been marked as submitted.

Review request for OpenLMI Developers.

Repository: openlmi-tools

Description
-------

Completion: bash completion for lmi shell

It allow to complete:
- LMI Shell options (short and long)
- files with .lmi extension
- directories

Signed-off-by: Roman Rakus

Diffs
-----

cli/completion/lmishell.bash PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/830/diff/

Testing
-------

This is my very first completion, so please test it. It should properly handle files with spaces. It allow to complete lmishell options, but only if they are before file name.

Thanks,

Roman Rakus