Review Request 840: [1/1] Account: First upstream account test from qa.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: First upstream account test from qa.


Diffs
-----

  src/account/test/TestAccountQA.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1123
-----------------------------------------------------------



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment642>

    Don't put space in front of the paren.


- Jan Synacek


On Sept. 10, 2013, 9:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 9:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1124
-----------------------------------------------------------



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment643>

    Where is DEV_NULL used?



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment644>

    Use hash instead of keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment645>

    This should be standalone test case.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment646>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment647>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment648>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment649>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment650>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment651>

    Use hash, not keys.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment652>

    Use hash, not keys.


- Robin Hack


On Sept. 10, 2013, 7:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 7:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1127
-----------------------------------------------------------


I don't like the name of the file. Could it be renamed to something more descriptive
or merged to TestAccount.py?

- Radek Novacek


On Sept. 10, 2013, 9:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 9:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

>  On Sept. 10, 2013, 7:47 a.m., Radek Novacek wrote:
>  > I don't like the name of the file. Could it be renamed to something more
> descriptive or merged to TestAccount.py? 
This is first proposal of name and yes; name is not pretty.
I think that merging with TestAccount.py is bad idea for now.
Any suggestion?


- Robin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1127
-----------------------------------------------------------


On Sept. 10, 2013, 7:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 7:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1130
-----------------------------------------------------------



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment661>

    Copy and paste everywhere.
    This should be part of setUp or setUpClass.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment658>

    Should be renamed to:
    try_to_create_badass_user?
    :)



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment660>

    Copy and paste everywhere.
    This should be part of setUp or setUpClass.
    
    Ad line 101:
    Why is this inside of for loop?



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment659>

    Copy and paste everywhere.
    This should be part of setUp or setUpClass.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment662>

    This should be part of setUp or setUpClass.


- Robin Hack


On Sept. 10, 2013, 7:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 7:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/#review1131
-----------------------------------------------------------



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment664>

    Not used.



src/account/test/TestAccountQA.py
<http://reviewboard-openlmi.rhcloud.com/r/840/#comment663>

    Which ?random is used? I found only that random is used.


- Robin Hack


On Sept. 10, 2013, 7:10 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/840/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 7:10 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: First upstream account test from qa.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/TestAccountQA.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/840/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 9:33 a.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: First upstream account test from qa.


Diffs
-----

  src/account/test/TestAccountQA.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/840/diff/


Testing
-------


Thanks,

Robin Hack