package-review April 2006

package-review@lists.fedoraproject.org

1 participants
906 discussions

[Bug 177556] Review Request: mod_extract_forwarded
by Red Hat Bugzilla 29 Apr '06

29 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_extract_forwarded https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177556 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs(a)math.uh.edu ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 22:45 EST ------- Well, heck, I worked up this review and then I noticed the NEEDSPONSOR blocker. But I looked through owners.list and I see that rpm(a)timj.co.uk already owns three packages, so perhaps that tag is out of date. I'll go ahead and include the review and just leave this as FE-NEW until things are cleared up. * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: d7aeb59fa81cbe74c485c33873ea1c65 extract_forwarded-2.0.2.tar.gz d7aeb59fa81cbe74c485c33873ea1c65 extract_forwarded-2.0.2.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present, but they're not in the default locations so there's no need to call ldconfig. * package is not relocatable. * creates no directories. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is not present; no upstream test suite. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED, assuming the NEEDSPONSOR blocker is incorrect. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 169345] Review Request: SEC - Simple Event Correlator
by Red Hat Bugzilla 29 Apr '06

29 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SEC - Simple Event Correlator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169345 ------- Additional Comments From jpmahowald(a)gmail.com 2006-04-28 22:07 EST ------- rpmlint: W: sec log-files-without-logrotate /var/log/sec.log W: sec dangerous-command-in-%post rpm W: sec dangerous-command-in-%preun rpm W: sec dangerous-command-in-%postun rpm E: sec no-chkconfig-line /etc/rc.d/init.d/sec W: sec incoherent-subsys /etc/rc.d/init.d/sec $prog The blocker here is the chkconfig line, you should change to something like "chkconfig: - 26 74" so it by default doesn't start in any runlevel. Missing dependancy on service for %postun (package initscripts) Missing dependancy on service for %preun (package initscripts) Missing dependancy on chkconfig for %post (package chkconfig) Missing dependancy on chkconfig for %preun (package chkconfig) You'll need to Require, say, /sin/service and /sbin/chkconfig Source0 doesn't download automatically, http://download.sourceforge.net/simple-evcorr/%{name}-%{version}.tar.gz would be nice. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 180300] Review Request: ccrtp
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

1 0

[Bug 188168] Review Request: gauche - Scheme script interpreter with multibyte character handling
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gauche - Scheme script interpreter with multibyte character handling https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188168 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 17:50 EST ------- Looks great and builds fine. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 188168] Review Request: gauche - Scheme script interpreter with multibyte character handling
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gauche - Scheme script interpreter with multibyte character handling https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188168 ------- Additional Comments From gemi(a)bluewin.ch 2006-04-28 17:38 EST ------- I added the %check and the COPYING file: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/gauche-0.8.7-3.fc5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 180300] Review Request: ccrtp
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ccrtp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180300 tibbs(a)math.uh.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 16:08 EST ------- Issues: src/ccrtp/rtp.h is executable in the source tarball. It gets stuck in the debuginfo package, which causes rpmlint to complain: E: ccrtp-debuginfo script-without-shellbang /usr/src/debug/ccrtp-1.3.7/src/ccrtp/rtp.h I suggest just doing chmod 644 src/ccrtp/rtp.h in %prep. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * license field matches the actual license. * license is open source-compatible and is included in the package as %doc. * source files match upstream: 6621be1852bd90c3dbbafa895618d8f0 ccrtp-1.3.7.tar.gz 6621be1852bd90c3dbbafa895618d8f0 ccrtp-1.3.7.tar.gz-srpm * BuildRequires are proper. * package builds in mock (development, x86_64). X rpmlint complains (see above) * final provides and requires are sane. * shared libraries are present; ldconfig is invoked as necessary. * package is not relocatable. * owns the directoryies it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X rtp.h has inappropriate permissions. * %clean is present. O %check not present; no test suite upstream. * code, not content. O documentation is large, but is all development-related and in the -devel subpackage. * %docs are not necessary for the proper functioning of the package. * headers are in -devel subpackage. * pkgconfig files are in -devel. * unversioned libraries are in the -devel subpackage. * no libtool .la droppings. * not a GUI app. With just one minor issue, I'll go ahead and approve and you can fix it when you check in. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 180300] Review Request: ccrtp
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

1 0

[Bug 188168] Review Request: gauche - Scheme script interpreter with multibyte character handling
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gauche - Scheme script interpreter with multibyte character handling https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188168 ------- Additional Comments From tibbs(a)math.uh.edu 2006-04-28 14:58 EST ------- The build failure seems to be fixed with last night's glibc-kernheaders package update. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 187964] Review Request: bsd-games - A collection of text-based games
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: bsd-games - A collection of text-based games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187964 ------- Additional Comments From wart(a)kobold.org 2006-04-28 13:39 EST ------- FWIW, I discovered that the change from setregid() to setresgid() is superfluous because it turns out, on linux at least, that setregid() will also change the saved gid if the new real gid is not -1, or if the new egid != the old egid. However, the setresgid patch should remain because it adds error checking to the setresgid() call and aborts if the privileges could not be dropped. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 188180] Review Request: qt4: Qt GUI toolkit
by Red Hat Bugzilla 28 Apr '06

28 Apr '06

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qt4: Qt GUI toolkit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188180 rdieter(a)math.unl.edu changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |190189 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
91
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

package-review April 2006