https://bugzilla.redhat.com/show_bug.cgi?id=1662534
--- Comment #2 from Fabio Valentini <decathorpe(a)gmail.com> ---
I have some initial comments:
- This is a pure-python package, so it must have "BuildArch: noarch".
This also means you have can drop the "global debug_package %{nil}".
- "Requires: python3" should be automatically generated, you don't need to
specify it.
- "BuildRequires: python3-devel" includes "BuildRequires: python3", so
you can
drop the latter, too.
- This project has its sources published on pypi, you could use the official
release tarball from there instead of the github tag archive.
- Is the python package supposed to be imported by other scripts other than
"liquidctl" that's shipped with this package?
If so, you should consider splitting it off into a python3-liquidctl
sub-package.
PS: I found that "pyp2rpm" is a really good tool for creating python packages
for fedora - its output usually only requires minor edits for compliant fedora
packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component