[Bug 584666] New: Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Summary: Review Request: lv2-invada-plugins - A collection of
                    LV2 plugins from Invada Records
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://www.davidcornette.com/lv2-invada-plugins.spec
SRPM URL: http://www.davidcornette.com/lv2-invada-plugins-1.2.0-1.fc11.src.rpm
Description:
A collection of LV2 plugins including delay, tube distortion, compressor,
LPF, HPF, phaser, reverb, and utilities, all featuring GUIs.

rpmlint is clean on the spec and rpms.

Scratch builds on koji succeeded.
F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2131512
F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2131526

I am not yet a packager, so I need a sponsor.  This is not my first package
submitted for review.  I also submitted Bug 581104, which is currently blocked
waiting for a required package to be reviewed.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

David Cornette  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #1 from Orcan 'oget' Ogetbil  2010-04-27 16:12:57 EDT ---
I'll review this one

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #2 from Orcan 'oget' Ogetbil  2010-04-27 22:34:51 EDT ---
The package is almost ready to go. Here are the results of my review. *'s are
blockers:

- rpmlint's complaints about the spelling errors can be ignored, since those
are valid technical terms.

! The file README can go to the %doc

* The file plugingui/lv2_ui.h is LGPLv2+, so the license field it the specfile
should be "GPLv2+ and LGPLv2+".
  Please document this in the specfile as a comment.

* Please patch (or sed) the Makefiles so that the build is verbose. The lines
where the compilations occur is important.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #3 from David Cornette  2010-04-28 03:23:52 EDT ---
I have made the requested changes.

* Wed Apr 28 2010 David Cornette  1.2.0-2
-- Added README to doc
-- Changed license to reflect license in plugingui/lv2_ui.h
-- Use sed to make building verbose

SPEC URL: http://www.davidcornette.com/lv2-invada-plugins.spec
SRPM URL: http://www.davidcornette.com/lv2-invada-plugins-1.2.0-2.fc11.src.rpm

Builds on koji:
F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2142389
F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2142378

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #4 from Orcan 'oget' Ogetbil  2010-04-28 03:52:18 EDT ---
Thanks.

* Look at the build log. The Fedora specific optimization flags (%optflags) are
not effective when compiling stuff in plugingui/widgets/

You can see what the flags should look like by doing a
   $ rpm -E %{optflags}

! Other than this, you can use the "find" utility if you don't want to be
over-repetitive, or just use wildcards, when sedding the Makefiles. Such as
   $ find . -name Makefile -exec sed -i 's|-O3|%{optflags}|' {} ;
or 
   $ sed -i 's|-O3|%{optflags}|' */Makefile */*/Makefile
etc. But I leave these all to your taste.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #5 from David Cornette  2010-04-30 01:06:18 EDT ---
The reason that plugingui/widgets/ wasn't using the right optflags was that
rather than trying to replace -O3, i inadvertently typed -O2, so the regex
never matched.  That tipped the balance in favor of using a find and just one
sed command.

New version available:
SPEC URL: http://www.davidcornette.com/lv2-invada-plugins.spec
SRPM URL: http://www.davidcornette.com/lv2-invada-plugins-1.2.0-3.fc11.src.rpm

* Wed Apr 28 2010 David Cornette  1.2.0-3
-- Use find to apply sed command to all Makefiles instead of listing each one
   explicitly to make sure each file is correctly adjusted

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #6 from Orcan 'oget' Ogetbil  2010-04-30 02:12:24 EDT ---
Thanks. This looks good.

Please submit your sponsorship request at Fedora Accounts System (FAS) 
   https://admin.fedoraproject.org/accounts/home
and we will be at the final step.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Orcan 'oget' Ogetbil  2010-04-30 03:32:34 EDT ---
I see that you submitted another review request in bug #581104 which is in good
shape. You also made a comprehensive informal review in bug #581197. These show
that you are capable of following Fedora guidelines. Now I am sponsoring you.
Let me briefly go over the next steps.

Next, you will file a CVS request by following the procedure at
   http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Afterwards please follow the guidelines to install koji tools and learn about
their usage as described in

http://fedoraproject.org/wiki/PackageMaintainers/Join#Install_the_Client_Too...
if you have not done so already.

If you want to import this package to stable releases of Fedora (11, 12, 13 for
the time being) you might want to look at the Bodhi usage page in the wiki:
   http://fedoraproject.org/wiki/Bodhi_Guide
which can be used both from the command line or through the web interface. Note
that this is to be done after officially building the packages in koji in the
respective branch(es).

If you have any questions, feel free to contact me through email, or at
#fedora-devel or at #fedora-music on freenode. If there is an audio production
software (or any other software) that you want to co-maintain, you will need to
ask for permission in pkgdb, by clicking on to appropriate boxes at 
   https://admin.fedoraproject.org/pkgdb/acls/name/<package name>
In normal cases, it is a good idea to contact the primary maintainer first
before doing so.

Moreover, you can now do official reviews.

Lifting FE-NEEDSPONSOR

-----------------------------------------------------
This package (lv2-invada-plugins) is APPROVED by oget
-----------------------------------------------------

Welcome to Fedora.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

David Cornette  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #8 from David Cornette  2010-04-30 12:05:51 EDT ---
New Package CVS Request
=======================
Package Name: lv2-invada-plugins
Short Description: A collection of LV2 plugins from Invada Records
Owners: davidcornette
Branches: F-11 F-12 F-13
InitialCC: oget

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #9 from Kevin Fenzi  2010-04-30 13:45:28 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #10 from Fedora Update System  2010-04-30 17:47:35 EDT ---
lv2-invada-plugins-1.2.0-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc12

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #12 from Fedora Update System  2010-04-30 17:47:43 EDT ---
lv2-invada-plugins-1.2.0-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc11

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #11 from Fedora Update System  2010-04-30 17:47:39 EDT ---
lv2-invada-plugins-1.2.0-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc13

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #13 from Fedora Update System  2010-04-30 19:46:24 EDT ---
lv2-invada-plugins-1.2.0-3.fc13 has been pushed to the Fedora 13 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update lv2-invada-plugins'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc13

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #14 from Fedora Update System  2010-05-03 12:01:35 EDT ---
lv2-invada-plugins-1.2.0-3.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update lv2-invada-plugins'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc11

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #15 from Fedora Update System  2010-05-03 12:02:49 EDT ---
lv2-invada-plugins-1.2.0-3.fc12 has been pushed to the Fedora 12 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update lv2-invada-plugins'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/lv2-invada-plugins-1.2.0-3.fc12

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |lv2-invada-plugins-1.2.0-3.
                   |                            |fc12
         Resolution|                            |ERRATA

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #16 from Fedora Update System  2010-05-17 14:51:08 EDT ---
lv2-invada-plugins-1.2.0-3.fc12 has been pushed to the Fedora 12 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|lv2-invada-plugins-1.2.0-3. |lv2-invada-plugins-1.2.0-3.
                   |fc12                        |fc13

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #17 from Fedora Update System  2010-05-17 15:02:06 EDT ---
lv2-invada-plugins-1.2.0-3.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

--- Comment #18 from Fedora Update System  2010-05-17 15:06:01 EDT ---
lv2-invada-plugins-1.2.0-3.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 584666] Review Request: lv2-invada-plugins - A collection of LV2 plugins from Invada Records

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=584666

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|lv2-invada-plugins-1.2.0-3. |lv2-invada-plugins-1.2.0-3.
                   |fc13                        |fc11