https://bugzilla.redhat.com/show_bug.cgi?id=1542666
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ppisar(a)redhat.com
--- Comment #1 from Petr Pisar <ppisar(a)redhat.com> ---
Few notes:
(1) If you need IO::Pty, then requiring IO::Tty is wrong. You need to require
IO::Pty.
(2) The dependency on IO::Pty is weak because it's optional according to
Net-OpenSSH author, see README:
DEPENDENCIES
This module requires these other modules and libraries:
Test::More
IO::Pty (optional, required for password authentication)
We can change it Fedora, but that won't change user experience for people
installing it from CPAN. If you write a code that rely on presence of module,
you will still have to specify the dependency in your code metadata.
Could you please provide a code that triggers the need for IO::Pty?
(3) The IO::Pty is not the only optional module. There more of them:
lib/Net/OpenSSH.pm:917: _load_module('IO::Pty');
lib/Net/OpenSSH.pm:1497: _load_module('IO::Pty');
lib/Net/OpenSSH.pm:1646: _load_module('Encode');
lib/Net/OpenSSH.pm:2317: _load_module('Net::SFTP::Foreign', '1.47');
lib/Net/OpenSSH.pm:2392: _load_module('Object::Remote') or return;
lib/Net/OpenSSH.pm:2393: _load_module('Net::OpenSSH::ObjectRemote') or
return;
lib/Net/OpenSSH.pm:2400: _load_module('Net::SSH::Any');
Do you think we should turn all of them into a hard dependency?
--
You are receiving this mail because:
You are on the CC list for the bug.