#438: repoclosure test is failing due to change in behavior upstream ---------------------+------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Keywords: Blocked By: | Blocking: ---------------------+------------------------------------------------- Starting with F19, I'm seeing crashes in the repoclosure test on failure:
ref: http://autoqa- stg.fedoraproject.org/results/238806-autotest/virt27.qa/debug/client.0.DEBUG
{{{ 07/16 15:16:41 ERROR| test:0572| Traceback (most recent call last): 07/16 15:16:41 ERROR| test:0572| File "/usr/lib/python2.7/site- packages/autoqa/decorators.py", line 72, in newf 07/16 15:16:41 ERROR| test:0572| f_result = f(*args, **kwargs) #call the decorated function 07/16 15:16:41 ERROR| test:0572| File "/usr/share/autotest/tests/repoclosure/repoclosure.py", line 52, in run_once 07/16 15:16:41 ERROR| test:0572| out = utils.system_output(cmd, retain_output=True) 07/16 15:16:41 ERROR| test:0572| File "/usr/share/autotest/common_lib/base_utils.py", line 931, in system_output 07/16 15:16:41 ERROR| test:0572| args=args).stdout 07/16 15:16:41 ERROR| test:0572| File "/usr/share/autotest/common_lib/base_utils.py", line 658, in run 07/16 15:16:41 ERROR| test:0572| "Command returned non-zero exit status") 07/16 15:16:41 ERROR| test:0572| CmdError: Command <repoclosure --tempcache --newest --repofrompath=target,http://infrastructure.fedoraproject.org/pub/fedora/linux/updates/testing/18/... --repoid=target --repofrompath=parent-1,http://infrastructure.fedoraproject.org/pub/fedora/linux/updates/18/x86_64 --repoid=parent-1 --repofrompath=parent-2,http://infrastructure.fedoraproject.org/pub/fedora/linux/releases/18/Everyth... --repoid=parent-2> failed, rc=1, Command returned non-zero exit status 07/16 15:16:41 ERROR| test:0572| * Command: 07/16 15:16:41 ERROR| test:0572| repoclosure --tempcache --newest --repofrompath=target,http://infrastruct 07/16 15:16:41 ERROR| test:0572| ure.fedoraproject.org/pub/fedora/linux/updates/testing/18/x86_64 07/16 15:16:41 ERROR| test:0572| --repoid=target --repofrompath=parent-1,http://infrastructure.fedoraprojec 07/16 15:16:41 ERROR| test:0572| t.org/pub/fedora/linux/updates/18/x86_64 --repoid=parent-1 --repofrompath= 07/16 15:16:41 ERROR| test:0572| parent-2,http://infrastructure.fedoraproject.org/pub/fedora/linux/releases 07/16 15:16:41 ERROR| test:0572| /18/Everything/x86_64/os --repoid=parent-2 07/16 15:16:41 ERROR| test:0572| Exit status: 1 07/16 15:16:41 ERROR| test:0572| Duration: 195.717083931 }}}
This is causing F19 repoclosure to crash instead of fail and no results are reported
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------------------------
Comment (by kparal):
If I were to decide, I'd just stop executing this test. I don't see anyone checking the results (mostly because we don't have the infrastructure in place to easily check the results and be notified of changes), thus I consider this test not being helpful (at the moment).
Plus, there's a daily report of rawhide repoclosure sent to the test list, and it's damn easy to execute it yourself locally for any our repos if you need to have a look.
I don't think it's currently worth the time to work on fixing the test.
Opinions?
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------------------------
Comment (by tflink):
Replying to [comment:1 kparal]:
I don't think it's currently worth the time to work on fixing the test.
The problem is just that the test is having trouble with the non-zero exit code from repoclosure. I think it would be worth an hour to see if we can get it working, but not a whole lot more than that :)
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------------------------
Comment (by tflink):
As I suspected, this was an easy fix: * [http://autoqa- stg.fedoraproject.org/results/240381-debug_user/virt26.qa/debug/client.0.DEBUG before fix] * [http://autoqa- stg.fedoraproject.org/results/240390-debug_user/virt26.qa/debug/client.0.DEBUG after fix]
{{{ diff --git a/tests/repoclosure/repoclosure.py b/tests/repoclosure/repoclosure.py index 8f942b2..4e2912d 100644 --- a/tests/repoclosure/repoclosure.py +++ b/tests/repoclosure/repoclosure.py @@ -49,7 +49,7 @@ class repoclosure(AutoQATest): cmd += ' --repofrompath=parent-%u,%s --repoid=parent-%u' % (count, parent, count)
# TODO set cachedir etc. to e.g. test.scratchdir? - out = utils.system_output(cmd, retain_output=True) + out = utils.system_output(cmd, retain_output=True, ignore_status=True) self.log(out, printout=False)
unresolved_count = out.count('unresolved deps:') }}}
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------------------------
Comment (by kparal):
Thanks. I assumed the command was crashing, and it was just a non-zero exit code.
Will you commit the patch, or should I?
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------------------------
Comment (by tflink):
Replying to [comment:4 kparal]:
Thanks. I assumed the command was crashing, and it was just a non-zero
exit code.
Will you commit the patch, or should I?
I was going to run stats again to make sure it wasn't still crashing or causing significant other problems before pushing the code.
#438: repoclosure test is failing due to change in behavior upstream --------------------+-------------------------------------------------- Reporter: tflink | Owner: Type: defect | Status: closed Priority: major | Milestone: Package Update Acceptance Test Plan Component: tests | Resolution: fixed Keywords: | Blocked By: Blocking: | --------------------+-------------------------------------------------- Changes (by tflink):
* resolution: => fixed * status: new => closed
Comment:
fix pushed to master: 40414007a5ec40fd5ce51b7eac4e4a6864271670
This will be part of the 0.8.3 release
qa-devel@lists.fedoraproject.org
-
fedora-badges