#439: depcheck crashes almost every time on fc19 ---------------------+---------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Depcheck Component: tests | Keywords: Blocked By: | Blocking: ---------------------+---------------------- While upgrading clients to fc18 and fc19 in staging, I noticed that there were a lot of depcheck crashes on the fc19 clients (120/128 runs crashed).
Example job: http://autoqa-stg.fedoraproject.org/results/238990-autotest/
Traceback:
{{{ Traceback (most recent call last): File "./depcheck", line 112, in <module> profile=opts.profile) File "/usr/share/autotest/tests/depcheck/depcheck_lib.py", line 394, in depcheck_main test_dir=temp_dir, accepted_dir=acc_dir) File "/usr/share/autotest/tests/depcheck/depcheck_lib.py", line 338, in do_depcheck do_mash(test_dir, mash_arches) File "/usr/share/autotest/tests/depcheck/depcheck_lib.py", line 157, in do_mash rc = themash.doMultilib() File "/usr/lib/python2.7/site-packages/mash/__init__.py", line 592, in doMultilib pid = self.doDepSolveAndMultilib(arch, repocache) File "/usr/lib/python2.7/site-packages/mash/__init__.py", line 465, in doDepSolveAndMultilib self.config.rpm_path % {'arch':arch}) File "/usr/lib64/python2.7/posixpath.py", line 75, in join if b.startswith('/'): AttributeError: 'NoneType' object has no attribute 'startswith' Traceback (most recent call last): File "./depcheck", line 112, in <module> profile=opts.profile) File "/usr/share/autotest/tests/depcheck/depcheck_lib.py", line 394, in depcheck_main test_dir=temp_dir, accepted_dir=acc_dir) File "/usr/share/autotest/tests/depcheck/depcheck_lib.py", line 341, in do_depcheck y.pkgSack # populates all package sacks File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 1050, in <lambda> pkgSack = property(fget=lambda self: self._getSacks(), File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 770, in _getSacks self.repos.populateSack(which=repos) File "/usr/lib/python2.7/site-packages/yum/repos.py", line 387, in populateSack sack.populate(repo, mdtype, callback, cacheonly) File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 224, in populate if self._check_db_version(repo, mydbtype): File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 316, in _check_db_version return repo._check_db_version(mdtype) File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1483, in _check_db_version repoXML = self.repoXML File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1669, in <lambda> repoXML = property(fget=lambda self: self._getRepoXML(), File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1665, in _getRepoXML self._loadRepoXML(text=self.ui_id) File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1656, in _loadRepoXML return self._groupLoadRepoXML(text, self._mdpolicy2mdtypes()) File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1630, in _groupLoadRepoXML if self._commonLoadRepoXML(text): File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1455, in _commonLoadRepoXML result = self._getFileRepoXML(local, text) File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1233, in _getFileRepoXML size=102400) # setting max size as 100K File "/usr/lib/python2.7/site-packages/yum/yumRepo.py", line 1029, in _getFile raise Errors.NoMoreMirrorsRepoError(errstr, errors) yum.Errors.NoMoreMirrorsRepoError: failure: repodata/repomd.xml from pending: [Errno 256] No more mirrors to try. file:///tmp/depcheck.oEfOtO/repodata/repomd.xml: [Errno 14] curl#37 - "Couldn't open file /tmp/depcheck.oEfOtO/repodata/repomd.xml" }}}
#439: depcheck crashes almost every time on fc19 --------------------+----------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Depcheck Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-----------------------
Comment (by tflink):
I started digging into this more when I saw the same crash on the f18 clients. I think it is due a change in mash that is looking for config values which we weren't setting: * [https://bugzilla.redhat.com/show_bug.cgi?id=668326 rhbz 668326] * [https://git.fedorahosted.org/cgit/mash/commit/mash/__init__.py?id=e6579e356e... mash change]
The fix appears to be simple (set output_subdir in mash config for do_mash() in depcheck_lib.py), I'm going to test a bit more before pushing a fix
#439: depcheck crashes almost every time post fc17 --------------------+----------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Depcheck Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-----------------------
Comment (by tflink):
I think that the config changed fixed this. I cloned a depcheck job after updating autoqa-stg01 and the job passed this time! * [http://autoqa-stg.fedoraproject.org/results/240338-debug_user/ before fix] * [http://autoqa-stg.fedoraproject.org/results/240362-debug_user/ after fix]
I'm going to leave the fix in stg for a while to make sure it stays working before pushing to git
{{{ diff --git a/tests/depcheck/depcheck_lib.py b/tests/depcheck/depcheck_lib.py index aedda8a..e600323 100644 --- a/tests/depcheck/depcheck_lib.py +++ b/tests/depcheck/depcheck_lib.py @@ -132,6 +132,7 @@ def do_mash(pkgdir, arches, distname=None): dist = mash.config.MashDistroConfig() parser = RawConfigParser() mash_conf = '''[%s] +output_subdir = %s rpm_path = %s strict_keys = False multilib = True @@ -143,7 +144,7 @@ delta = False source = False arches = %s keys = -''' % (distname, pkgdir, arches) +''' % (distname, distname, pkgdir, arches) parser.readfp(StringIO.StringIO(mash_conf)) dist.populate(parser, distname, conf) conf.distros.append(dist) }}}
#439: depcheck crashes almost every time post fc17 --------------------+----------------------- Reporter: tflink | Owner: Type: defect | Status: new Priority: major | Milestone: Depcheck Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-----------------------
Comment (by kparal):
Great job, Tim.
#439: depcheck crashes almost every time post fc17 --------------------+----------------------- Reporter: tflink | Owner: Type: defect | Status: closed Priority: major | Milestone: Depcheck Component: tests | Resolution: fixed Keywords: | Blocked By: Blocking: | --------------------+----------------------- Changes (by tflink):
* resolution: => fixed * status: new => closed
Comment:
pushed to master: f86008c08850e3c009a119ea367caccfafddc0a6
This will be part of the 0.8.3 release
qa-devel@lists.fedoraproject.org