Review Request 58: Display all users that are listed in needinfo flag

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/58/
-----------------------------------------------------------

Review request for blockerbugs.


Repository: blockerbugs


Description
-------

commit 0618ae3bc89431f9d00a3cc103b19fc0376697ed
Author: Martin Krizek <mkrizek(a)redhat.com&gt;
Date:   Wed Nov 20 14:51:17 2013 +0100

    Display all users that are listed in needinfo flag
    
    Also this adds tests for needinfo flag and updateid.
    
    Fixes: T26


Diffs
-----

  testing/testfunc_update_sync.py 14e7efca3b01d29f6d791d5cddce74609161ad66 
  testing/testfunc_bugsync.py f1a106379484330ef16eaf5bd18a91c65919ce98 
  testing/testfunc_bugmodel.py 640a63303c696359d324782ff36c5c16d0f4c357 
  testing/test_updatesync_extract_information.py 771faabf8a4076ed3ee5f9eb3865eb1deda7f7ae

  testing/test_controllers.py 7a6a3725c6570754cc55d916d1156ddc33478f10 
  testing/test_bugsync_extract_information.py e7c8ed08e5a71f5b81c164ebed24e7188e7a69a7 
  blockerbugs/util/bug_sync.py ae077231aea97f4c5918a4f37b21a1655b049984 

Diff: http://reviewboard-tflink.rhcloud.com/r/58/diff/


Testing
-------

Tests included in the patch.


Thanks,

Martin Krizek

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/58/#review119
-----------------------------------------------------------

Ship it!


This looks good to me. It bothers me that so many test corrections were needed, but they
still need to be fixed.

- Tim Flink


On Dec. 10, 2013, 3:56 p.m., Martin Krizek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-tflink.rhcloud.com/r/58/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 10, 2013, 3:56 p.m.)
>  
>  
>  Review request for blockerbugs.
>  
>  
>  Repository: blockerbugs
>  
>  
>  Description
>  -------
>  
>  commit 0618ae3bc89431f9d00a3cc103b19fc0376697ed
>  Author: Martin Krizek <mkrizek(a)redhat.com&gt;
>  Date:   Wed Nov 20 14:51:17 2013 +0100
>  
>      Display all users that are listed in needinfo flag
>      
>      Also this adds tests for needinfo flag and updateid.
>      
>      Fixes: T26
>  
>  
>  Diffs
>  -----
>  
>    testing/testfunc_update_sync.py 14e7efca3b01d29f6d791d5cddce74609161ad66 
>    testing/testfunc_bugsync.py f1a106379484330ef16eaf5bd18a91c65919ce98 
>    testing/testfunc_bugmodel.py 640a63303c696359d324782ff36c5c16d0f4c357 
>    testing/test_updatesync_extract_information.py 771faabf8a4076ed3ee5f9eb3865eb1deda7f7ae
>
>    testing/test_controllers.py 7a6a3725c6570754cc55d916d1156ddc33478f10 
>    testing/test_bugsync_extract_information.py e7c8ed08e5a71f5b81c164ebed24e7188e7a69a7 
>    blockerbugs/util/bug_sync.py ae077231aea97f4c5918a4f37b21a1655b049984 
>  
>  Diff: http://reviewboard-tflink.rhcloud.com/r/58/diff/
>  
>  
>  Testing
>  -------
>  
>  Tests included in the patch.
>  
>  
>  Thanks,
>  
>  Martin Krizek
>  
>

[Martin Krizek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/58/
-----------------------------------------------------------

(Updated Dec. 11, 2013, 11:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for blockerbugs.


Repository: blockerbugs


Description
-------

commit 0618ae3bc89431f9d00a3cc103b19fc0376697ed
Author: Martin Krizek <mkrizek(a)redhat.com&gt;
Date:   Wed Nov 20 14:51:17 2013 +0100

    Display all users that are listed in needinfo flag
    
    Also this adds tests for needinfo flag and updateid.
    
    Fixes: T26


Diffs
-----

  testing/testfunc_update_sync.py 14e7efca3b01d29f6d791d5cddce74609161ad66 
  testing/testfunc_bugsync.py f1a106379484330ef16eaf5bd18a91c65919ce98 
  testing/testfunc_bugmodel.py 640a63303c696359d324782ff36c5c16d0f4c357 
  testing/test_updatesync_extract_information.py 771faabf8a4076ed3ee5f9eb3865eb1deda7f7ae

  testing/test_controllers.py 7a6a3725c6570754cc55d916d1156ddc33478f10 
  testing/test_bugsync_extract_information.py e7c8ed08e5a71f5b81c164ebed24e7188e7a69a7 
  blockerbugs/util/bug_sync.py ae077231aea97f4c5918a4f37b21a1655b049984 

Diff: http://reviewboard-tflink.rhcloud.com/r/58/diff/


Testing
-------

Tests included in the patch.


Thanks,

Martin Krizek